[PATCH] hv_netvsc: Fix potential dereference of NULL pointer

[PATCH] hv_netvsc: Fix potential dereference of NULL pointer

[Yongzhi Liu]

The return value of netvsc_devinfo_get()
needs to be checked to avoid use of NULL
pointer in case of an allocation failure.

Fixes: 0efeea5fb ("hv_netvsc: Add the support of hibernation")

Signed-off-by: Yongzhi Liu <lyz_cs@pku.edu.cn>
---
 drivers/net/hyperv/netvsc_drv.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/net/hyperv/netvsc_drv.c b/drivers/net/hyperv/netvsc_drv.c
index fde1c49..b1dece6 100644
--- a/drivers/net/hyperv/netvsc_drv.c
+++ b/drivers/net/hyperv/netvsc_drv.c
@@ -2671,7 +2671,10 @@ static int netvsc_suspend(struct hv_device *dev)
 
 	/* Save the current config info */
 	ndev_ctx->saved_netvsc_dev_info = netvsc_devinfo_get(nvdev);
-
+	if (!ndev_ctx->saved_netvsc_dev_info) {
+		ret = -ENOMEM;
+		goto out;
+	}
 	ret = netvsc_detach(net, nvdev);
 out:
 	rtnl_unlock();
-- 
2.7.4

RE: [PATCH] hv_netvsc: Fix potential dereference of NULL pointer

[Haiyang Zhang]

> -----Original Message-----
> From: Yongzhi Liu <lyz_cs@pku.edu.cn>
> Sent: Thursday, May 19, 2022 8:10 AM
> To: KY Srinivasan <kys@microsoft.com>; Haiyang Zhang
> <haiyangz@microsoft.com>; Stephen Hemminger
> <sthemmin@microsoft.com>; wei.liu@kernel.org; Dexuan Cui
> <decui@microsoft.com>; davem@davemloft.net; kuba@kernel.org;
> pabeni@redhat.com; sashal@kernel.org
> Cc: linux-hyperv@vger.kernel.org; netdev@vger.kernel.org; linux-
> kernel@vger.kernel.org; fuyq@stu.pku.edu.cn; Yongzhi Liu
> <lyz_cs@pku.edu.cn>
> Subject: [PATCH] hv_netvsc: Fix potential dereference of NULL pointer
> 
> [Some people who received this message don't often get email from
> lyz_cs@pku.edu.cn. Learn why this is important at
> https://aka.ms/LearnAboutSenderIdentification.]
> 
> The return value of netvsc_devinfo_get()
> needs to be checked to avoid use of NULL
> pointer in case of an allocation failure.
> 
> Fixes: 0efeea5fb ("hv_netvsc: Add the support of hibernation")
> 
> Signed-off-by: Yongzhi Liu <lyz_cs@pku.edu.cn>
> ---
>  drivers/net/hyperv/netvsc_drv.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/hyperv/netvsc_drv.c
> b/drivers/net/hyperv/netvsc_drv.c
> index fde1c49..b1dece6 100644
> --- a/drivers/net/hyperv/netvsc_drv.c
> +++ b/drivers/net/hyperv/netvsc_drv.c
> @@ -2671,7 +2671,10 @@ static int netvsc_suspend(struct hv_device *dev)
> 
>         /* Save the current config info */
>         ndev_ctx->saved_netvsc_dev_info = netvsc_devinfo_get(nvdev);
> -
> +       if (!ndev_ctx->saved_netvsc_dev_info) {
> +               ret = -ENOMEM;
> +               goto out;
> +       }
>         ret = netvsc_detach(net, nvdev);
>  out:
>         rtnl_unlock();

Reviewed-by: Haiyang Zhang <haiyangz@microsoft.com>
Thank you!

Re: [PATCH] hv_netvsc: Fix potential dereference of NULL pointer

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net.git (master)
by Jakub Kicinski <kuba@kernel.org>:

On Thu, 19 May 2022 05:09:48 -0700 you wrote:
> The return value of netvsc_devinfo_get()
> needs to be checked to avoid use of NULL
> pointer in case of an allocation failure.
> 
> Fixes: 0efeea5fb ("hv_netvsc: Add the support of hibernation")
> 
> Signed-off-by: Yongzhi Liu <lyz_cs@pku.edu.cn>
> 
> [...]

Here is the summary with links:
  - hv_netvsc: Fix potential dereference of NULL pointer
    https://git.kernel.org/netdev/net/c/eb4c07889647

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html