* [PATCH] igb: use eth_zero_addr() to clear mac address
@ 2020-07-20 8:29 linmiaohe
2020-07-30 18:10 ` Brown, Aaron F
0 siblings, 1 reply; 2+ messages in thread
From: linmiaohe @ 2020-07-20 8:29 UTC (permalink / raw)
To: jeffrey.t.kirsher, davem, kuba
Cc: intel-wired-lan, netdev, linux-kernel, linmiaohe
From: Miaohe Lin <linmiaohe@huawei.com>
Use eth_zero_addr() to clear mac address insetad of memset().
Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
---
drivers/net/ethernet/intel/igb/igb_main.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/igb/igb_main.c
index 8bb3db2cbd41..adedd98f1e3e 100644
--- a/drivers/net/ethernet/intel/igb/igb_main.c
+++ b/drivers/net/ethernet/intel/igb/igb_main.c
@@ -7168,7 +7168,7 @@ static void igb_flush_mac_table(struct igb_adapter *adapter)
for (i = 0; i < hw->mac.rar_entry_count; i++) {
adapter->mac_table[i].state &= ~IGB_MAC_STATE_IN_USE;
- memset(adapter->mac_table[i].addr, 0, ETH_ALEN);
+ eth_zero_addr(adapter->mac_table[i].addr);
adapter->mac_table[i].queue = 0;
igb_rar_set_index(adapter, i);
}
@@ -7317,7 +7317,7 @@ static int igb_del_mac_filter_flags(struct igb_adapter *adapter,
} else {
adapter->mac_table[i].state = 0;
adapter->mac_table[i].queue = 0;
- memset(adapter->mac_table[i].addr, 0, ETH_ALEN);
+ eth_zero_addr(adapter->mac_table[i].addr);
}
igb_rar_set_index(adapter, i);
--
2.19.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* RE: [PATCH] igb: use eth_zero_addr() to clear mac address
2020-07-20 8:29 [PATCH] igb: use eth_zero_addr() to clear mac address linmiaohe
@ 2020-07-30 18:10 ` Brown, Aaron F
0 siblings, 0 replies; 2+ messages in thread
From: Brown, Aaron F @ 2020-07-30 18:10 UTC (permalink / raw)
To: linmiaohe, Kirsher, Jeffrey T, davem, kuba
Cc: intel-wired-lan, netdev, linux-kernel
> From: linmiaohe <linmiaohe@huawei.com>
> Sent: Monday, July 20, 2020 1:29 AM
> To: Kirsher, Jeffrey T <jeffrey.t.kirsher@intel.com>; davem@davemloft.net;
> kuba@kernel.org
> Cc: intel-wired-lan@lists.osuosl.org; netdev@vger.kernel.org; linux-
> kernel@vger.kernel.org; linmiaohe@huawei.com
> Subject: [PATCH] igb: use eth_zero_addr() to clear mac address
>
> From: Miaohe Lin <linmiaohe@huawei.com>
>
> Use eth_zero_addr() to clear mac address insetad of memset().
>
> Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
> ---
> drivers/net/ethernet/intel/igb/igb_main.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Tested-by: Aaron Brown <aaron.f.brown@intel.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-07-30 18:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-20 8:29 [PATCH] igb: use eth_zero_addr() to clear mac address linmiaohe
2020-07-30 18:10 ` Brown, Aaron F
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).