From: Danielle Ratson <danieller@nvidia.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"davem@davemloft.net" <davem@davemloft.net>,
"kuba@kernel.org" <kuba@kernel.org>,
"alobakin@pm.me" <alobakin@pm.me>,
Meir Lichtinger <meirl@nvidia.com>,
"dmurphy@ti.com" <dmurphy@ti.com>,
"mkubecek@suse.cz" <mkubecek@suse.cz>,
"f.fainelli@gmail.com" <f.fainelli@gmail.com>,
"irusskikh@marvell.com" <irusskikh@marvell.com>,
"alexanderduyck@fb.com" <alexanderduyck@fb.com>,
"magnus.karlsson@intel.com" <magnus.karlsson@intel.com>,
"ecree@solarflare.com" <ecree@solarflare.com>,
Ido Schimmel <idosch@nvidia.com>, Jiri Pirko <jiri@nvidia.com>,
mlxsw <mlxsw@nvidia.com>
Subject: RE: [PATCH net-next] ethtool: Move __ethtool_get_link_ksettings() to common file
Date: Thu, 22 Apr 2021 15:38:18 +0000 [thread overview]
Message-ID: <DM6PR12MB451615D959313E7675C3AEF8D8469@DM6PR12MB4516.namprd12.prod.outlook.com> (raw)
In-Reply-To: <YG8KAOtjkpNuEPkN@lunn.ch>
> -----Original Message-----
> From: Andrew Lunn <andrew@lunn.ch>
> Sent: Thursday, April 8, 2021 4:50 PM
> To: Danielle Ratson <danieller@nvidia.com>
> Cc: netdev@vger.kernel.org; davem@davemloft.net; kuba@kernel.org; alobakin@pm.me; Meir Lichtinger <meirl@nvidia.com>;
> dmurphy@ti.com; mkubecek@suse.cz; f.fainelli@gmail.com; irusskikh@marvell.com; alexanderduyck@fb.com;
> magnus.karlsson@intel.com; ecree@solarflare.com; Ido Schimmel <idosch@nvidia.com>; Jiri Pirko <jiri@nvidia.com>; mlxsw
> <mlxsw@nvidia.com>
> Subject: Re: [PATCH net-next] ethtool: Move __ethtool_get_link_ksettings() to common file
>
> On Thu, Apr 08, 2021 at 01:58:13PM +0300, Danielle Ratson wrote:
> > __ethtool_get_link_ksettings() function is shared by both ioctl and
> > netlink ethtool interfaces.
> >
> > Move it to net/ethtool/common.c file, which is the suitable place for
> > a shared code.
> >
> > Signed-off-by: Danielle Ratson <danieller@nvidia.com>
> > Suggested-by: Jakub Kicinski <kuba@kernel.org>
> > Reviewed-by: Ido Schimmel <idosch@nvidia.com>
> > Reviewed-by: Jiri Pirko <jiri@nvidia.com>
>
> Seems sensible.
>
> Did you look to see what else is shared and should move? Rather than doing it one function at a time, can we do it all at once?
>
> Andrew
This is the only one I found that needs to be moved, thanks.
prev parent reply other threads:[~2021-04-22 15:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-08 10:58 [PATCH net-next] ethtool: Move __ethtool_get_link_ksettings() to common file Danielle Ratson
2021-04-08 13:49 ` Andrew Lunn
2021-04-22 15:38 ` Danielle Ratson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM6PR12MB451615D959313E7675C3AEF8D8469@DM6PR12MB4516.namprd12.prod.outlook.com \
--to=danieller@nvidia.com \
--cc=alexanderduyck@fb.com \
--cc=alobakin@pm.me \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=dmurphy@ti.com \
--cc=ecree@solarflare.com \
--cc=f.fainelli@gmail.com \
--cc=idosch@nvidia.com \
--cc=irusskikh@marvell.com \
--cc=jiri@nvidia.com \
--cc=kuba@kernel.org \
--cc=magnus.karlsson@intel.com \
--cc=meirl@nvidia.com \
--cc=mkubecek@suse.cz \
--cc=mlxsw@nvidia.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).