* [PATCH net-next] net: sfp: fix sfp_bus_add_upstream() warning
@ 2019-11-12 11:35 Russell King
2019-11-12 13:26 ` Andrew Lunn
2019-11-12 19:13 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Russell King @ 2019-11-12 11:35 UTC (permalink / raw)
To: Andrew Lunn, Florian Fainelli, Heiner Kallweit
Cc: David S. Miller, netdev, Stephen Rothwell
When building with SFP disabled, the stub for sfp_bus_add_upstream()
missed "inline". Add it.
Fixes: 727b3668b730 ("net: sfp: rework upstream interface")
Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
---
include/linux/sfp.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/linux/sfp.h b/include/linux/sfp.h
index c8464de7cff5..3b35efd85bb1 100644
--- a/include/linux/sfp.h
+++ b/include/linux/sfp.h
@@ -563,8 +563,8 @@ static inline struct sfp_bus *sfp_bus_find_fwnode(struct fwnode_handle *fwnode)
return NULL;
}
-static int sfp_bus_add_upstream(struct sfp_bus *bus, void *upstream,
- const struct sfp_upstream_ops *ops)
+static inline int sfp_bus_add_upstream(struct sfp_bus *bus, void *upstream,
+ const struct sfp_upstream_ops *ops)
{
return 0;
}
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] net: sfp: fix sfp_bus_add_upstream() warning
2019-11-12 11:35 [PATCH net-next] net: sfp: fix sfp_bus_add_upstream() warning Russell King
@ 2019-11-12 13:26 ` Andrew Lunn
2019-11-12 19:13 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Andrew Lunn @ 2019-11-12 13:26 UTC (permalink / raw)
To: Russell King
Cc: Florian Fainelli, Heiner Kallweit, David S. Miller, netdev,
Stephen Rothwell
On Tue, Nov 12, 2019 at 11:35:00AM +0000, Russell King wrote:
> When building with SFP disabled, the stub for sfp_bus_add_upstream()
> missed "inline". Add it.
>
> Fixes: 727b3668b730 ("net: sfp: rework upstream interface")
> Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] net: sfp: fix sfp_bus_add_upstream() warning
2019-11-12 11:35 [PATCH net-next] net: sfp: fix sfp_bus_add_upstream() warning Russell King
2019-11-12 13:26 ` Andrew Lunn
@ 2019-11-12 19:13 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2019-11-12 19:13 UTC (permalink / raw)
To: rmk+kernel; +Cc: andrew, f.fainelli, hkallweit1, netdev, sfr
From: Russell King <rmk+kernel@armlinux.org.uk>
Date: Tue, 12 Nov 2019 11:35:00 +0000
> When building with SFP disabled, the stub for sfp_bus_add_upstream()
> missed "inline". Add it.
>
> Fixes: 727b3668b730 ("net: sfp: rework upstream interface")
> Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-11-12 19:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-12 11:35 [PATCH net-next] net: sfp: fix sfp_bus_add_upstream() warning Russell King
2019-11-12 13:26 ` Andrew Lunn
2019-11-12 19:13 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).