* [PATCH] openvswitch: Fix a possible memory leak on dst_cache
@ 2019-07-18 16:07 Haishuang Yan
2019-07-18 19:08 ` David Miller
2019-07-18 22:12 ` Gregory Rose
0 siblings, 2 replies; 4+ messages in thread
From: Haishuang Yan @ 2019-07-18 16:07 UTC (permalink / raw)
To: Pravin B Shelar, David S. Miller; +Cc: netdev, linux-kernel, Haishuang Yan
dst_cache should be destroyed when fail to add flow actions.
Fixes: d71785ffc7e7 ("net: add dst_cache to ovs vxlan lwtunnel")
Signed-off-by: Haishuang Yan <yanhaishuang@cmss.chinamobile.com>
---
net/openvswitch/flow_netlink.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/net/openvswitch/flow_netlink.c b/net/openvswitch/flow_netlink.c
index d7559c6..1fd1cdd 100644
--- a/net/openvswitch/flow_netlink.c
+++ b/net/openvswitch/flow_netlink.c
@@ -2608,6 +2608,7 @@ static int validate_and_copy_set_tun(const struct nlattr *attr,
sizeof(*ovs_tun), log);
if (IS_ERR(a)) {
dst_release((struct dst_entry *)tun_dst);
+ dst_cache_destroy(&tun_dst->u.tun_info.dst_cache);
return PTR_ERR(a);
}
--
1.8.3.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] openvswitch: Fix a possible memory leak on dst_cache
2019-07-18 16:07 [PATCH] openvswitch: Fix a possible memory leak on dst_cache Haishuang Yan
@ 2019-07-18 19:08 ` David Miller
2019-07-18 22:12 ` Gregory Rose
1 sibling, 0 replies; 4+ messages in thread
From: David Miller @ 2019-07-18 19:08 UTC (permalink / raw)
To: yanhaishuang; +Cc: pshelar, netdev, linux-kernel
From: Haishuang Yan <yanhaishuang@cmss.chinamobile.com>
Date: Fri, 19 Jul 2019 00:07:08 +0800
> dst_cache should be destroyed when fail to add flow actions.
>
> Fixes: d71785ffc7e7 ("net: add dst_cache to ovs vxlan lwtunnel")
> Signed-off-by: Haishuang Yan <yanhaishuang@cmss.chinamobile.com>
OVS folks, please review.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] openvswitch: Fix a possible memory leak on dst_cache
2019-07-18 16:07 [PATCH] openvswitch: Fix a possible memory leak on dst_cache Haishuang Yan
2019-07-18 19:08 ` David Miller
@ 2019-07-18 22:12 ` Gregory Rose
2019-07-19 1:43 ` Haishuang Yan
1 sibling, 1 reply; 4+ messages in thread
From: Gregory Rose @ 2019-07-18 22:12 UTC (permalink / raw)
To: Haishuang Yan, Pravin B Shelar, David S. Miller; +Cc: netdev, linux-kernel
On 7/18/2019 9:07 AM, Haishuang Yan wrote:
> dst_cache should be destroyed when fail to add flow actions.
>
> Fixes: d71785ffc7e7 ("net: add dst_cache to ovs vxlan lwtunnel")
> Signed-off-by: Haishuang Yan <yanhaishuang@cmss.chinamobile.com>
> ---
> net/openvswitch/flow_netlink.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/net/openvswitch/flow_netlink.c b/net/openvswitch/flow_netlink.c
> index d7559c6..1fd1cdd 100644
> --- a/net/openvswitch/flow_netlink.c
> +++ b/net/openvswitch/flow_netlink.c
> @@ -2608,6 +2608,7 @@ static int validate_and_copy_set_tun(const struct nlattr *attr,
> sizeof(*ovs_tun), log);
> if (IS_ERR(a)) {
> dst_release((struct dst_entry *)tun_dst);
> + dst_cache_destroy(&tun_dst->u.tun_info.dst_cache);
> return PTR_ERR(a);
> }
>
Nack.
dst_release will decrement the ref count and will
call_rcu(&dst->rcu_head, dst_destroy_rcu) if the ref count is zero. No
other net drivers call dst_destroy SFAICT.
Haishuang,
are you trying to fix some specific problem here?
Thanks,
- Greg
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] openvswitch: Fix a possible memory leak on dst_cache
2019-07-18 22:12 ` Gregory Rose
@ 2019-07-19 1:43 ` Haishuang Yan
0 siblings, 0 replies; 4+ messages in thread
From: Haishuang Yan @ 2019-07-19 1:43 UTC (permalink / raw)
To: Gregory Rose; +Cc: Pravin B Shelar, David S. Miller, netdev, linux-kernel
> On 2019年7月19日, at 上午6:12, Gregory Rose <gvrose8192@gmail.com> wrote:
>
> On 7/18/2019 9:07 AM, Haishuang Yan wrote:
>> dst_cache should be destroyed when fail to add flow actions.
>>
>> Fixes: d71785ffc7e7 ("net: add dst_cache to ovs vxlan lwtunnel")
>> Signed-off-by: Haishuang Yan <yanhaishuang@cmss.chinamobile.com>
>> ---
>> net/openvswitch/flow_netlink.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/net/openvswitch/flow_netlink.c b/net/openvswitch/flow_netlink.c
>> index d7559c6..1fd1cdd 100644
>> --- a/net/openvswitch/flow_netlink.c
>> +++ b/net/openvswitch/flow_netlink.c
>> @@ -2608,6 +2608,7 @@ static int validate_and_copy_set_tun(const struct nlattr *attr,
>> sizeof(*ovs_tun), log);
>> if (IS_ERR(a)) {
>> dst_release((struct dst_entry *)tun_dst);
>> + dst_cache_destroy(&tun_dst->u.tun_info.dst_cache);
>> return PTR_ERR(a);
>> }
>>
>
> Nack.
>
> dst_release will decrement the ref count and will call_rcu(&dst->rcu_head, dst_destroy_rcu) if the ref count is zero. No other net drivers call dst_destroy SFAICT.
>
> Haishuang,
>
> are you trying to fix some specific problem here?
>
> Thanks,
>
> - Greg
>
>
Greg,
You’re right, dst_cache would be freed in metadata_dst_free:
125
126 if (dst->flags & DST_METADATA)
127 metadata_dst_free((struct metadata_dst *)dst);
128 else
129 kmem_cache_free(dst->ops->kmem_cachep, dst);
130
I thought I encountered a memory leak, but it seems not an issue, thanks for you explanation.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-07-19 1:44 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-18 16:07 [PATCH] openvswitch: Fix a possible memory leak on dst_cache Haishuang Yan
2019-07-18 19:08 ` David Miller
2019-07-18 22:12 ` Gregory Rose
2019-07-19 1:43 ` Haishuang Yan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).