* Subject: [PATCH v3 net-next 2/4] net:phy: Remove phy_reset_after_clk_enable()
@ 2021-01-15 17:21 Badel, Laurent
0 siblings, 0 replies; only message in thread
From: Badel, Laurent @ 2021-01-15 17:21 UTC (permalink / raw)
To: davem, m.felsch, fugang.duan, kuba, andrew, Heiner Kallweit,
linux, p.zabel, lgirdwood, broonie, robh+dt, richard.leitner,
netdev, devicetree, f.fainelli, marex
Extraneous PHY reset is not needed if the PHY is kept in reset when the
REF_CLK is turned off, so remove phy_reset_after_clk_enable() which is not
needed anymore.
Signed-off-by: Laurent Badel <laurentbadel@eaton.com>
---
drivers/net/phy/phy_device.c | 24 ------------------------
include/linux/phy.h | 1 -
2 files changed, 25 deletions(-)
diff --git a/drivers/net/phy/phy_device.c b/drivers/net/phy/phy_device.c
index 80c2e646c093..13bae0ce31b8 100644
--- a/drivers/net/phy/phy_device.c
+++ b/drivers/net/phy/phy_device.c
@@ -1798,30 +1798,6 @@ int phy_loopback(struct phy_device *phydev, bool enable)
}
EXPORT_SYMBOL(phy_loopback);
-/**
- * phy_reset_after_clk_enable - perform a PHY reset if needed
- * @phydev: target phy_device struct
- *
- * Description: Some PHYs are known to need a reset after their refclk was
- * enabled. This function evaluates the flags and perform the reset if it's
- * needed. Returns < 0 on error, 0 if the phy wasn't reset and 1 if the phy
- * was reset.
- */
-int phy_reset_after_clk_enable(struct phy_device *phydev)
-{
- if (!phydev || !phydev->drv)
- return -ENODEV;
-
- if (phydev->drv->flags & PHY_RST_AFTER_CLK_EN) {
- phy_device_reset(phydev, 1);
- phy_device_reset(phydev, 0);
- return 1;
- }
-
- return 0;
-}
-EXPORT_SYMBOL(phy_reset_after_clk_enable);
-
/* Generic PHY support and helper functions */
/**
diff --git a/include/linux/phy.h b/include/linux/phy.h
index 9effb511acde..58b4a2d45df9 100644
--- a/include/linux/phy.h
+++ b/include/linux/phy.h
@@ -1390,7 +1390,6 @@ int phy_speed_down(struct phy_device *phydev, bool sync);
int phy_speed_up(struct phy_device *phydev);
int phy_restart_aneg(struct phy_device *phydev);
-int phy_reset_after_clk_enable(struct phy_device *phydev);
#if IS_ENABLED(CONFIG_PHYLIB)
int phy_start_cable_test(struct phy_device *phydev,
--
2.17.1
-----------------------------
Eaton Industries Manufacturing GmbH ~ Registered place of business: Route de la Longeraie 7, 1110, Morges, Switzerland
-----------------------------
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2021-01-15 17:32 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-15 17:21 Subject: [PATCH v3 net-next 2/4] net:phy: Remove phy_reset_after_clk_enable() Badel, Laurent
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).