Re: [Patch v4 net-next 0/7] ethtool support for fec and link configuration

Re: [Patch v4 net-next 0/7] ethtool support for fec and link configuration

[Hariprasad Kelam]

Hi Jakub,

> -----Original Message-----
> From: Jakub Kicinski <kuba@kernel.org>
> Sent: Tuesday, February 9, 2021 11:56 PM
> To: Hariprasad Kelam <hkelam@marvell.com>
> Cc: netdev@vger.kernel.org; linux-kernel@vger.kernel.org;
> davem@davemloft.net; willemdebruijn.kernel@gmail.com;
> andrew@lunn.ch; Sunil Kovvuri Goutham <sgoutham@marvell.com>; Linu
> Cherian <lcherian@marvell.com>; Geethasowjanya Akula
> <gakula@marvell.com>; Jerin Jacob Kollanukkaran <jerinj@marvell.com>;
> Subbaraya Sundeep Bhatta <sbhatta@marvell.com>
> Subject: [EXT] Re: [Patch v4 net-next 0/7] ethtool support for fec and link
> configuration
> 
> On Tue, 9 Feb 2021 16:05:24 +0530 Hariprasad Kelam wrote:
> > v4:
> > 	- Corrected indentation issues
> > 	- Use FEC_OFF if user requests for FEC_AUTO mode
> > 	- Do not clear fec stats in case of user changes
> > 	  fec mode
> > 	- dont hide fec stats depending on interface mode
> > 	  selection
> 
> What about making autoneg modes symmetric between set and get?

Get supports multi modes such that user can select one of the modes to advertise.
For time being set only supports single mode. Do let me know if you want me to
Add this in commit description.

Thanks,
Hariprasad k

Re: [Patch v4 net-next 0/7] ethtool support for fec and link configuration

[Jakub Kicinski]

On Wed, 10 Feb 2021 17:06:29 +0000 Hariprasad Kelam wrote:
> > On Tue, 9 Feb 2021 16:05:24 +0530 Hariprasad Kelam wrote:  
> > > v4:
> > > 	- Corrected indentation issues
> > > 	- Use FEC_OFF if user requests for FEC_AUTO mode
> > > 	- Do not clear fec stats in case of user changes
> > > 	  fec mode
> > > 	- dont hide fec stats depending on interface mode
> > > 	  selection  
> > 
> > What about making autoneg modes symmetric between set and get?  
> 
> Get supports multi modes such that user can select one of the modes
> to advertise. For time being set only supports single mode. Do let me
> know if you want me to Add this in commit description.

You use the same code for supported and advertising.
Please add a check that there is only one advertising mode 
reported so we don't have to take your word for it.

Thanks.

Re: [Patch v4 net-next 0/7] ethtool support for fec and link configuration

[Jakub Kicinski]

On Tue, 9 Feb 2021 16:05:24 +0530 Hariprasad Kelam wrote:
> v4:
> 	- Corrected indentation issues
> 	- Use FEC_OFF if user requests for FEC_AUTO mode
> 	- Do not clear fec stats in case of user changes
> 	  fec mode
> 	- dont hide fec stats depending on interface mode
> 	  selection

What about making autoneg modes symmetric between set and get?

[Patch v4 net-next 0/7] ethtool support for fec and link configuration

[Hariprasad Kelam]

This series of patches add support for forward error correction(fec) and
physical link configuration. Patches 1&2 adds necessary mbox handlers for fec
mode configuration request and to fetch stats. Patch 3 registers driver
callbacks for fec mode configuration and display. Patch 4&5 adds support of mbox
handlers for configuring link parameters like speed/duplex and autoneg etc.
Patche 6&7 registers driver callbacks for physical link configuration.

Change-log:
v2:
	- Fixed review comments
	- Corrected indentation issues
        - Return -ENOMEM incase of mbox allocation failure
	- added validation for input fecparams bitmask values
        - added more comments

V3:
	- Removed inline functions
        - Make use of ethtool helpers APIs to display supported
          advertised modes
        - corrected indentation issues
        - code changes such that return early in case of failure
          to aid branch prediction
v4:
	- Corrected indentation issues
	- Use FEC_OFF if user requests for FEC_AUTO mode
	- Do not clear fec stats in case of user changes
	  fec mode
	- dont hide fec stats depending on interface mode
	  selection


Christina Jacob (6):
  octeontx2-af: forward error correction configuration
  octeontx2-pf: ethtool fec mode support
  octeontx2-af: Physical link configuration support
  octeontx2-af: advertised link modes support on cgx
  octeontx2-pf: ethtool physical link status
  octeontx2-pf: ethtool physical link configuration

Felix Manlunas (1):
  octeontx2-af: Add new CGX_CMD to get PHY FEC statistics

 drivers/net/ethernet/marvell/octeontx2/af/cgx.c    | 258 +++++++++++++-
 drivers/net/ethernet/marvell/octeontx2/af/cgx.h    |  10 +
 .../net/ethernet/marvell/octeontx2/af/cgx_fw_if.h  |  70 +++-
 drivers/net/ethernet/marvell/octeontx2/af/mbox.h   |  89 ++++-
 drivers/net/ethernet/marvell/octeontx2/af/rvu.h    |   4 +
 .../net/ethernet/marvell/octeontx2/af/rvu_cgx.c    |  82 +++++
 .../ethernet/marvell/octeontx2/nic/otx2_common.c   |  20 ++
 .../ethernet/marvell/octeontx2/nic/otx2_common.h   |   6 +
 .../ethernet/marvell/octeontx2/nic/otx2_ethtool.c  | 381 ++++++++++++++++++++-
 .../net/ethernet/marvell/octeontx2/nic/otx2_pf.c   |   3 +
 10 files changed, 917 insertions(+), 6 deletions(-)

--
2.7.4