Reply: [PATCH] mediatek/mt76: cleanup the code a bit

Reply: [PATCH] mediatek/mt76: cleanup the code a bit

[赵军奎]

-----邮件原件-----
发件人: Kalle Valo <kvalo@kernel.org> 
发送时间: 2022年5月18日 13:11
收件人: 赵军奎 <bernard@vivo.com>
抄送: Felix Fietkau <nbd@nbd.name>; Lorenzo Bianconi <lorenzo@kernel.org>; Ryder Lee <ryder.lee@mediatek.com>; Shayne Chen <shayne.chen@mediatek.com>; Sean Wang <sean.wang@mediatek.com>; David S. Miller <davem@davemloft.net>; Jakub Kicinski <kuba@kernel.org>; Paolo Abeni <pabeni@redhat.com>; Matthias Brugger <matthias.bgg@gmail.com>; linux-wireless@vger.kernel.org; netdev@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-mediatek@lists.infradead.org; linux-kernel@vger.kernel.org; zhaojunkui2008@126.com
主题: Re: [PATCH] mediatek/mt76: cleanup the code a bit

> Bernard Zhao <bernard@vivo.com> writes:

> > Function mt76_register_debugfs just call mt76_register_debugfs_fops 
> > with NULL op parameter.
> > This change is to cleanup the code a bit, elete the meaningless 
> > mt76_register_debugfs, and all call mt76_register_debugfs_fops.
> >
> > Signed-off-by: Bernard Zhao <bernard@vivo.com>

> Please make the title more informative and don't use mediatek in the title, for example something like this:

> mt76: remove simple mt76_register_debugfs() function

> More info:

> https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#commit_title_is_wrong
Hi Kalle Valo:

Got this, I would resubmit a patch of V2 version, thank you very much!

BR//Bernard
> --
> https://patchwork.kernel.org/project/linux-wireless/list/

> https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches