* Re: please drop the nvme code from net-next
@ 2021-06-08 19:51 Shai Malin
2021-06-09 12:13 ` Shai Malin
0 siblings, 1 reply; 6+ messages in thread
From: Shai Malin @ 2021-06-08 19:51 UTC (permalink / raw)
To: Keith Busch, David Miller
Cc: hch, geert, axboe, sagi, Omkar Kulkarni, hare, Dean Balandin,
himanshu.madhani, pmladek, linux-nvme, netdev, linux-kernel,
malin1024
On Tue, Jun 08, 2021 at 10:41:00PM -0700, Keith Busch wrote:
> On Tue, Jun 08, 2021 at 12:08:39PM -0700, David Miller wrote:
> > From: Christoph Hellwig <hch@lst.de>
> > Date: Tue, 8 Jun 2021 15:43:03 +0200
> >
> > > please drop the nvme-offload code from net-next. Code for drivers/nvme/
> > > needs ACKs from us nvme maintainers and for something this significant
> > > also needs to go through the NVMe tree. And this code is not ready yet.
> >
> > Please send me a revert, and I will apply it, thank you.
> >
> > It's tricky because at least one driver uses the new interfaces.
>
> Shouldn't whoever merged un-ACK'ed patches from a different subsystem
> get to own the tricky revert?
Dave, we will provide a revert patch.
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: please drop the nvme code from net-next
2021-06-08 19:51 please drop the nvme code from net-next Shai Malin
@ 2021-06-09 12:13 ` Shai Malin
0 siblings, 0 replies; 6+ messages in thread
From: Shai Malin @ 2021-06-09 12:13 UTC (permalink / raw)
To: Keith Busch, David Miller
Cc: hch, geert, axboe, sagi, Omkar Kulkarni, hare, Dean Balandin,
himanshu.madhani, pmladek, linux-nvme, netdev, linux-kernel,
malin1024, Michal Kalderon, Prabhakar Kushwaha
On Tue, Jun 08, 2021 at 10:51:00PM +0200, Shai Malin wrote:
> On Tue, Jun 08, 2021 at 10:41:00PM -0700, Keith Busch wrote:
> > On Tue, Jun 08, 2021 at 12:08:39PM -0700, David Miller wrote:
> > > From: Christoph Hellwig <hch@lst.de>
> > > Date: Tue, 8 Jun 2021 15:43:03 +0200
> > >
> > > > please drop the nvme-offload code from net-next. Code for drivers/nvme/
> > > > needs ACKs from us nvme maintainers and for something this significant
> > > > also needs to go through the NVMe tree. And this code is not ready yet.
> > >
> > > Please send me a revert, and I will apply it, thank you.
> > >
> > > It's tricky because at least one driver uses the new interfaces.
> >
> > Shouldn't whoever merged un-ACK'ed patches from a different subsystem
> > get to own the tricky revert?
>
> Dave, we will provide a revert patch.
The revert patch was sent to net-next.
https://lore.kernel.org/netdev/20210609104918.10329-1-smalin@marvell.com/
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: please drop the nvme code from net-next
2021-06-08 19:08 ` David Miller
@ 2021-06-08 19:40 ` Keith Busch
0 siblings, 0 replies; 6+ messages in thread
From: Keith Busch @ 2021-06-08 19:40 UTC (permalink / raw)
To: David Miller
Cc: hch, geert, axboe, sagi, okulkarni, hare, dbalandin,
himanshu.madhani, smalin, pmladek, linux-nvme, netdev,
linux-kernel
On Tue, Jun 08, 2021 at 12:08:39PM -0700, David Miller wrote:
> From: Christoph Hellwig <hch@lst.de>
> Date: Tue, 8 Jun 2021 15:43:03 +0200
>
> > please drop the nvme-offload code from net-next. Code for drivers/nvme/
> > needs ACKs from us nvme maintainers and for something this significant
> > also needs to go through the NVMe tree. And this code is not ready yet.
>
> Please send me a revert, and I will apply it, thank you.
>
> It's tricky because at least one driver uses the new interfaces.
Shouldn't whoever merged un-ACK'ed patches from a different subsystem
get to own the tricky revert?
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: please drop the nvme code from net-next
2021-06-08 13:43 ` please drop the nvme code from net-next Christoph Hellwig
@ 2021-06-08 19:08 ` David Miller
2021-06-08 19:40 ` Keith Busch
0 siblings, 1 reply; 6+ messages in thread
From: David Miller @ 2021-06-08 19:08 UTC (permalink / raw)
To: hch
Cc: geert, kbusch, axboe, sagi, okulkarni, hare, dbalandin,
himanshu.madhani, smalin, pmladek, linux-nvme, netdev,
linux-kernel
From: Christoph Hellwig <hch@lst.de>
Date: Tue, 8 Jun 2021 15:43:03 +0200
> please drop the nvme-offload code from net-next. Code for drivers/nvme/
> needs ACKs from us nvme maintainers and for something this significant
> also needs to go through the NVMe tree. And this code is not ready yet.
Please send me a revert, and I will apply it, thank you.
It's tricky because at least one driver uses the new interfaces.
Thank you.
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: please drop the nvme code from net-next
@ 2021-06-08 15:56 Shai Malin
0 siblings, 0 replies; 6+ messages in thread
From: Shai Malin @ 2021-06-08 15:56 UTC (permalink / raw)
To: Christoph Hellwig, Geert Uytterhoeven
Cc: David S . Miller, Keith Busch, Jens Axboe, Sagi Grimberg,
Omkar Kulkarni, Hannes Reinecke, Dean Balandin, Himanshu Madhani,
Petr Mladek, linux-nvme, netdev, Linux Kernel Mailing List
On Tue, Jun 8, 2021 at 4:38 PM Christoph Hellwig <hch@lst.de> wrote:
> Hi Dave,
>
> please drop the nvme-offload code from net-next. Code for drivers/nvme/
> needs ACKs from us nvme maintainers and for something this significant
> also needs to go through the NVMe tree. And this code is not ready yet.
Hi all,
Sorry for any confusion we may have caused. Our plan was for the qed series
to be considered for net-next, and for the nvme-tcp-offload series to be
considered for nvme mailing list.
We attempted to communicate this in the cover letter and the addresses
in to: vs. those in cc:, but perhaps this was not clear enough.
The plan was detailed in the cover latter under the "upstream plan" section
https://lore.kernel.org/netdev/20210531225222.16992-1-smalin@marvell.com/
The series is structured in a modular way so that part 1 (nvme-tcp-offload)
and part 2 (qed) are independent and part 3 (qedn) depends on both parts 1+2.
We have sent the first 2 parts which are independent:
- QED NVMeTCP Offload - https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/commit/?id=eda1bc65b0dc1b03006e427430ba23746ec44714
This part includes the qed infrastructure which was discussed over the RFC.
Our intent for this part was for it to be accepted to net-next, which it was.
Dave, from our perspective this piece can stay in net-next.
- NVMeTCP Offload ULP - https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/commit/?id=5ff5622ea1f16d535f1be4e478e712ef48fe183b
This is the nvme-tcp-offload ULP which we intended the NVMe tree,
and it shouldn't be merged to net-next.
Dave, please revert this from net-next until nvme maintainers are completely
satisfied with it.
Christoph, we would be more than happy to incorporate any feedback you may
provide for any part of the series.
^ permalink raw reply [flat|nested] 6+ messages in thread
* please drop the nvme code from net-next
2021-06-08 13:37 ` Geert Uytterhoeven
@ 2021-06-08 13:43 ` Christoph Hellwig
2021-06-08 19:08 ` David Miller
0 siblings, 1 reply; 6+ messages in thread
From: Christoph Hellwig @ 2021-06-08 13:43 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: David S . Miller, Keith Busch, Jens Axboe, Sagi Grimberg,
Omkar Kulkarni, Hannes Reinecke, Dean Balandin, Himanshu Madhani,
Shai Malin, Petr Mladek, linux-nvme, netdev,
Linux Kernel Mailing List
Hi Dave,
please drop the nvme-offload code from net-next. Code for drivers/nvme/
needs ACKs from us nvme maintainers and for something this significant
also needs to go through the NVMe tree. And this code is not ready yet.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-06-09 12:14 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-08 19:51 please drop the nvme code from net-next Shai Malin
2021-06-09 12:13 ` Shai Malin
-- strict thread matches above, loose matches on Subject: below --
2021-06-08 15:56 Shai Malin
2021-06-08 10:56 [PATCH] nvme: NVME_TCP_OFFLOAD should not default to m Geert Uytterhoeven
2021-06-08 12:19 ` Christoph Hellwig
2021-06-08 13:37 ` Geert Uytterhoeven
2021-06-08 13:43 ` please drop the nvme code from net-next Christoph Hellwig
2021-06-08 19:08 ` David Miller
2021-06-08 19:40 ` Keith Busch
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).