[PATCH] dpaa2-eth: fix draining of S/G cache

[PATCH] dpaa2-eth: fix draining of S/G cache

[Ioana Ciornei]

On link down, the draining of the S/G cache should be done on all
_possible_ CPUs not just the ones that are online in that moment.
Fix this by changing the iterator.

Fixes: d70446ee1f40 ("dpaa2-eth: send a scatter-gather FD instead of realloc-ing")
Reported-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Ioana Ciornei <ioana.ciornei@nxp.com>
---
 drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c b/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c
index bc1f1e0117b6..d0cc1dc49aaa 100644
--- a/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c
+++ b/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c
@@ -1261,7 +1261,7 @@ static void dpaa2_eth_sgt_cache_drain(struct dpaa2_eth_priv *priv)
 	u16 count;
 	int k, i;
 
-	for_each_online_cpu(k) {
+	for_each_possible_cpu(k) {
 		sgt_cache = per_cpu_ptr(priv->sgt_cache, k);
 		count = sgt_cache->count;
 
-- 
2.25.1

Re: [PATCH] dpaa2-eth: fix draining of S/G cache

[David Miller]

From: Ioana Ciornei <ioana.ciornei@nxp.com>
Date: Mon,  6 Jul 2020 17:55:54 +0300

> On link down, the draining of the S/G cache should be done on all
> _possible_ CPUs not just the ones that are online in that moment.
> Fix this by changing the iterator.
> 
> Fixes: d70446ee1f40 ("dpaa2-eth: send a scatter-gather FD instead of realloc-ing")
> Reported-by: Jakub Kicinski <kuba@kernel.org>
> Signed-off-by: Ioana Ciornei <ioana.ciornei@nxp.com>

Applied to net-next.

Please explicitly specify the target tree in your Subject lines, "net-next"
in this case.

Otherwise I have to guess and do some trial and error to figure out where
your patch applied.  That wastes my time.

Thank you.

Re: [PATCH] dpaa2-eth: fix draining of S/G cache

[Ioana Ciornei]

On 7/6/20 11:01 PM, David Miller wrote:
> From: Ioana Ciornei <ioana.ciornei@nxp.com>
> Date: Mon,  6 Jul 2020 17:55:54 +0300
> 
>> On link down, the draining of the S/G cache should be done on all
>> _possible_ CPUs not just the ones that are online in that moment.
>> Fix this by changing the iterator.
>>
>> Fixes: d70446ee1f40 ("dpaa2-eth: send a scatter-gather FD instead of realloc-ing")
>> Reported-by: Jakub Kicinski <kuba@kernel.org>
>> Signed-off-by: Ioana Ciornei <ioana.ciornei@nxp.com>
> 
> Applied to net-next.
> 
> Please explicitly specify the target tree in your Subject lines, "net-next"
> in this case.
> 
> Otherwise I have to guess and do some trial and error to figure out where
> your patch applied.  That wastes my time.
> 
> Thank you.
> 

Sorry, my mistake.