netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Claudiu Manoil <claudiu.manoil@nxp.com>
To: "HEMANT RAMDASI (hramdasi)" <hramdasi@cisco.com>,
	"Daniel Walker (danielwa)" <danielwa@cisco.com>
Cc: "David S . Miller" <davem@davemloft.net>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"Sathish Jarugumalli -X (sjarugum - ARICENT TECHNOLOGIES
	HOLDINGS LIMITED at Cisco)" <sjarugum@cisco.com>
Subject: RE: [PATCH net] gianfar: Don't force RGMII mode after reset, use defaults
Date: Wed, 13 Nov 2019 16:01:39 +0000	[thread overview]
Message-ID: <VI1PR04MB48805B8F4AE80B3E72D14E7B96760@VI1PR04MB4880.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <79AEA72F-38A7-447C-812E-4CA31BFC4B55@cisco.com>

>-----Original Message-----
>From: HEMANT RAMDASI (hramdasi) <hramdasi@cisco.com>
[..]
>
>>> This bit must be set when in half-duplex mode (MACCFG2[Full_Duplex] is cleared).
>>
>> Should the bit be clear when in full duplex or it does not matter?
>>
>
>> From my tests, in full duplex mode small frames won't get padded if this bit is disabled,
>> and will be counted as undersize frames and dropped. So this bit needs to be set
>> in full duplex mode to get packets smaller than 64B past the MAC (w/o software padding).
>
>This is little strange as we do not see this problem on all pkt type, icmp passes
>well and we observed issue with tftp ack.

I tested on a 1Gbit (full duplex) link, and ARP and small ICMP ipv4 packets were not passing
with the PAD_CRC bit disabled.

  reply	other threads:[~2019-11-13 16:16 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-12 14:55 [PATCH net] gianfar: Don't force RGMII mode after reset, use defaults Claudiu Manoil
2019-11-12 16:47 ` Daniel Walker
2019-11-12 16:55   ` HEMANT RAMDASI (hramdasi)
2019-11-12 17:09     ` Claudiu Manoil
2019-11-12 17:28       ` HEMANT RAMDASI (hramdasi)
2019-11-13 14:00         ` Claudiu Manoil
2019-11-13 14:21           ` HEMANT RAMDASI (hramdasi)
2019-11-13 16:01             ` Claudiu Manoil [this message]
2020-02-19 18:57               ` Daniel Walker (danielwa)
2020-02-20 11:42                 ` Claudiu Manoil
2019-11-21 15:58 ` Daniel Walker (danielwa)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=VI1PR04MB48805B8F4AE80B3E72D14E7B96760@VI1PR04MB4880.eurprd04.prod.outlook.com \
    --to=claudiu.manoil@nxp.com \
    --cc=danielwa@cisco.com \
    --cc=davem@davemloft.net \
    --cc=hramdasi@cisco.com \
    --cc=netdev@vger.kernel.org \
    --cc=sjarugum@cisco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).