* [PATCH net-next] net: phy: at803x: use phy_modify_mmd()
@ 2021-01-10 14:54 Russell King
2021-01-10 16:51 ` Andrew Lunn
0 siblings, 1 reply; 3+ messages in thread
From: Russell King @ 2021-01-10 14:54 UTC (permalink / raw)
To: Andrew Lunn, Heiner Kallweit; +Cc: David S. Miller, netdev, Jakub Kicinski
Convert at803x_clk_out_config() to use phy_modify_mmd().
Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
---
drivers/net/phy/at803x.c | 11 ++---------
1 file changed, 2 insertions(+), 9 deletions(-)
diff --git a/drivers/net/phy/at803x.c b/drivers/net/phy/at803x.c
index d0b36fd6c265..9636edb8d618 100644
--- a/drivers/net/phy/at803x.c
+++ b/drivers/net/phy/at803x.c
@@ -529,19 +529,12 @@ static void at803x_remove(struct phy_device *phydev)
static int at803x_clk_out_config(struct phy_device *phydev)
{
struct at803x_priv *priv = phydev->priv;
- int val;
if (!priv->clk_25m_mask)
return 0;
- val = phy_read_mmd(phydev, MDIO_MMD_AN, AT803X_MMD7_CLK25M);
- if (val < 0)
- return val;
-
- val &= ~priv->clk_25m_mask;
- val |= priv->clk_25m_reg;
-
- return phy_write_mmd(phydev, MDIO_MMD_AN, AT803X_MMD7_CLK25M, val);
+ return phy_modify_mmd(phydev, MDIO_MMD_AN, AT803X_MMD7_CLK25M,
+ priv->clk_25m_mask, priv->clk_25m_reg);
}
static int at8031_pll_config(struct phy_device *phydev)
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] net: phy: at803x: use phy_modify_mmd()
2021-01-10 14:54 [PATCH net-next] net: phy: at803x: use phy_modify_mmd() Russell King
@ 2021-01-10 16:51 ` Andrew Lunn
2021-01-12 0:31 ` Jakub Kicinski
0 siblings, 1 reply; 3+ messages in thread
From: Andrew Lunn @ 2021-01-10 16:51 UTC (permalink / raw)
To: Russell King; +Cc: Heiner Kallweit, David S. Miller, netdev, Jakub Kicinski
On Sun, Jan 10, 2021 at 02:54:36PM +0000, Russell King wrote:
> Convert at803x_clk_out_config() to use phy_modify_mmd().
>
> Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] net: phy: at803x: use phy_modify_mmd()
2021-01-10 16:51 ` Andrew Lunn
@ 2021-01-12 0:31 ` Jakub Kicinski
0 siblings, 0 replies; 3+ messages in thread
From: Jakub Kicinski @ 2021-01-12 0:31 UTC (permalink / raw)
To: Andrew Lunn, Russell King; +Cc: Heiner Kallweit, David S. Miller, netdev
On Sun, 10 Jan 2021 17:51:30 +0100 Andrew Lunn wrote:
> On Sun, Jan 10, 2021 at 02:54:36PM +0000, Russell King wrote:
> > Convert at803x_clk_out_config() to use phy_modify_mmd().
> >
> > Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
>
> Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Applied, thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-01-12 0:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-10 14:54 [PATCH net-next] net: phy: at803x: use phy_modify_mmd() Russell King
2021-01-10 16:51 ` Andrew Lunn
2021-01-12 0:31 ` Jakub Kicinski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).