* [PATCH net] atm: idt77252: call pci_disable_device() on error path
@ 2020-12-19 11:01 Dan Carpenter
2020-12-22 1:40 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2020-12-19 11:01 UTC (permalink / raw)
To: Chas Williams
Cc: chas williams - CONTRACTOR, David S. Miller, linux-atm-general,
netdev, kernel-janitors
This error path needs to disable the pci device before returning.
Fixes: ede58ef28e10 ("atm: remove deprecated use of pci api")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
drivers/atm/idt77252.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/atm/idt77252.c b/drivers/atm/idt77252.c
index 65a3886f68c9..5f0472c18bcb 100644
--- a/drivers/atm/idt77252.c
+++ b/drivers/atm/idt77252.c
@@ -3607,7 +3607,7 @@ static int idt77252_init_one(struct pci_dev *pcidev,
if ((err = dma_set_mask_and_coherent(&pcidev->dev, DMA_BIT_MASK(32)))) {
printk("idt77252: can't enable DMA for PCI device at %s\n", pci_name(pcidev));
- return err;
+ goto err_out_disable_pdev;
}
card = kzalloc(sizeof(struct idt77252_dev), GFP_KERNEL);
--
2.29.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net] atm: idt77252: call pci_disable_device() on error path
2020-12-19 11:01 [PATCH net] atm: idt77252: call pci_disable_device() on error path Dan Carpenter
@ 2020-12-22 1:40 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2020-12-22 1:40 UTC (permalink / raw)
To: Dan Carpenter
Cc: 3chas3, chas, davem, linux-atm-general, netdev, kernel-janitors
Hello:
This patch was applied to netdev/net.git (refs/heads/master):
On Sat, 19 Dec 2020 14:01:44 +0300 you wrote:
> This error path needs to disable the pci device before returning.
>
> Fixes: ede58ef28e10 ("atm: remove deprecated use of pci api")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> drivers/atm/idt77252.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Here is the summary with links:
- [net] atm: idt77252: call pci_disable_device() on error path
https://git.kernel.org/netdev/net/c/8df66af5c1e5
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-12-22 1:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-19 11:01 [PATCH net] atm: idt77252: call pci_disable_device() on error path Dan Carpenter
2020-12-22 1:40 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).