* [PATCH] net/mlx5e: remove unused list in arfs
@ 2022-10-31 16:56 Anisse Astier
2022-11-06 18:22 ` Leon Romanovsky
2022-11-11 22:26 ` [PATCH] " Saeed Mahameed
0 siblings, 2 replies; 4+ messages in thread
From: Anisse Astier @ 2022-10-31 16:56 UTC (permalink / raw)
To: netdev
Cc: Anisse Astier, Erwan Velu, Maor Gottlieb, Saeed Mahameed,
Leon Romanovsky, David S . Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, linux-rdma, Anisse Astier
This is never used, and probably something that was intended to be used
before per-protocol hash tables were chosen instead.
Signed-off-by: Anisse Astier <anisse@astier.eu>
---
drivers/net/ethernet/mellanox/mlx5/core/en_arfs.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_arfs.c b/drivers/net/ethernet/mellanox/mlx5/core/en_arfs.c
index 0ae1865086ff..bed0c2d043e7 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/en_arfs.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/en_arfs.c
@@ -57,7 +57,6 @@ struct mlx5e_arfs_tables {
struct arfs_table arfs_tables[ARFS_NUM_TYPES];
/* Protect aRFS rules list */
spinlock_t arfs_lock;
- struct list_head rules;
int last_filter_id;
struct workqueue_struct *wq;
};
@@ -376,7 +375,6 @@ int mlx5e_arfs_create_tables(struct mlx5e_flow_steering *fs,
return -ENOMEM;
spin_lock_init(&arfs->arfs_lock);
- INIT_LIST_HEAD(&arfs->rules);
arfs->wq = create_singlethread_workqueue("mlx5e_arfs");
if (!arfs->wq)
goto err;
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] net/mlx5e: remove unused list in arfs
2022-10-31 16:56 [PATCH] net/mlx5e: remove unused list in arfs Anisse Astier
@ 2022-11-06 18:22 ` Leon Romanovsky
2022-11-09 16:59 ` [PATCH net-next] " Anisse Astier
2022-11-11 22:26 ` [PATCH] " Saeed Mahameed
1 sibling, 1 reply; 4+ messages in thread
From: Leon Romanovsky @ 2022-11-06 18:22 UTC (permalink / raw)
To: Anisse Astier
Cc: netdev, Anisse Astier, Erwan Velu, Maor Gottlieb, Saeed Mahameed,
David S . Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
linux-rdma
On Mon, Oct 31, 2022 at 05:56:04PM +0100, Anisse Astier wrote:
> This is never used, and probably something that was intended to be used
> before per-protocol hash tables were chosen instead.
>
> Signed-off-by: Anisse Astier <anisse@astier.eu>
> ---
> drivers/net/ethernet/mellanox/mlx5/core/en_arfs.c | 2 --
> 1 file changed, 2 deletions(-)
>
The patch subject should be "[PATCH net-next] ..."
Thanks,
Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH net-next] net/mlx5e: remove unused list in arfs
2022-11-06 18:22 ` Leon Romanovsky
@ 2022-11-09 16:59 ` Anisse Astier
0 siblings, 0 replies; 4+ messages in thread
From: Anisse Astier @ 2022-11-09 16:59 UTC (permalink / raw)
To: Leon Romanovsky, netdev
Cc: Anisse Astier, Erwan Velu, Maor Gottlieb, Saeed Mahameed,
David S . Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
linux-rdma, Anisse Astier, Leon Romanovsky
This is never used, and probably something that was intended to be used
before one per-protocol hash tables were chosen instead.
Signed-off-by: Anisse Astier <anisse@astier.eu>
Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
---
drivers/net/ethernet/mellanox/mlx5/core/en_arfs.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_arfs.c b/drivers/net/ethernet/mellanox/mlx5/core/en_arfs.c
index 0ae1865086ff..bed0c2d043e7 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/en_arfs.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/en_arfs.c
@@ -57,7 +57,6 @@ struct mlx5e_arfs_tables {
struct arfs_table arfs_tables[ARFS_NUM_TYPES];
/* Protect aRFS rules list */
spinlock_t arfs_lock;
- struct list_head rules;
int last_filter_id;
struct workqueue_struct *wq;
};
@@ -376,7 +375,6 @@ int mlx5e_arfs_create_tables(struct mlx5e_flow_steering *fs,
return -ENOMEM;
spin_lock_init(&arfs->arfs_lock);
- INIT_LIST_HEAD(&arfs->rules);
arfs->wq = create_singlethread_workqueue("mlx5e_arfs");
if (!arfs->wq)
goto err;
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] net/mlx5e: remove unused list in arfs
2022-10-31 16:56 [PATCH] net/mlx5e: remove unused list in arfs Anisse Astier
2022-11-06 18:22 ` Leon Romanovsky
@ 2022-11-11 22:26 ` Saeed Mahameed
1 sibling, 0 replies; 4+ messages in thread
From: Saeed Mahameed @ 2022-11-11 22:26 UTC (permalink / raw)
To: Anisse Astier
Cc: netdev, Anisse Astier, Erwan Velu, Maor Gottlieb, Saeed Mahameed,
Leon Romanovsky, David S . Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, linux-rdma
On 31 Oct 17:56, Anisse Astier wrote:
>This is never used, and probably something that was intended to be used
>before per-protocol hash tables were chosen instead.
>
applied to net-next-mlx5, thank you!
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-11-11 22:26 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-31 16:56 [PATCH] net/mlx5e: remove unused list in arfs Anisse Astier
2022-11-06 18:22 ` Leon Romanovsky
2022-11-09 16:59 ` [PATCH net-next] " Anisse Astier
2022-11-11 22:26 ` [PATCH] " Saeed Mahameed
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).