[PATCH net-next] sctp: change to include linux/sctp.h in net/sctp/checksum.h

[PATCH net-next] sctp: change to include linux/sctp.h in net/sctp/checksum.h

[Xin Long]

Currently "net/sctp/checksum.h" including "net/sctp/sctp.h" is
included in quite some places in netfilter and openswitch and
net/sched. It's not necessary to include "net/sctp/sctp.h" if
a module does not have dependence on SCTP, "linux/sctp.h" is
the right one to include.

Signed-off-by: Xin Long <lucien.xin@gmail.com>
---
 include/net/sctp/checksum.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/net/sctp/checksum.h b/include/net/sctp/checksum.h
index 5a9bb09f32b6..f514a0aa849e 100644
--- a/include/net/sctp/checksum.h
+++ b/include/net/sctp/checksum.h
@@ -24,7 +24,7 @@
 #define __sctp_checksum_h__
 
 #include <linux/types.h>
-#include <net/sctp/sctp.h>
+#include <linux/sctp.h>
 #include <linux/crc32c.h>
 #include <linux/crc32.h>
 
-- 
2.31.1

Re: [PATCH net-next] sctp: change to include linux/sctp.h in net/sctp/checksum.h

[Saeed Mahameed]

On 15 Nov 10:39, Xin Long wrote:
>Currently "net/sctp/checksum.h" including "net/sctp/sctp.h" is
>included in quite some places in netfilter and openswitch and
>net/sched. It's not necessary to include "net/sctp/sctp.h" if
>a module does not have dependence on SCTP, "linux/sctp.h" is
>the right one to include.
>
>Signed-off-by: Xin Long <lucien.xin@gmail.com>

LGTM as long as it builds:
Reviewed-by: Saeed Mahameed <saeed@kernel.org>

Re: [PATCH net-next] sctp: change to include linux/sctp.h in net/sctp/checksum.h

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net-next.git (master)
by Jakub Kicinski <kuba@kernel.org>:

On Tue, 15 Nov 2022 10:39:53 -0500 you wrote:
> Currently "net/sctp/checksum.h" including "net/sctp/sctp.h" is
> included in quite some places in netfilter and openswitch and
> net/sched. It's not necessary to include "net/sctp/sctp.h" if
> a module does not have dependence on SCTP, "linux/sctp.h" is
> the right one to include.
> 
> Signed-off-by: Xin Long <lucien.xin@gmail.com>
> 
> [...]

Here is the summary with links:
  - [net-next] sctp: change to include linux/sctp.h in net/sctp/checksum.h
    https://git.kernel.org/netdev/net-next/c/b78c4162823d

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html