* [PATCH net] octeontx2-af: cn10k: mcs: Fix copy and paste bug in mcs_bbe_intr_handler()
@ 2022-11-18 15:07 Dan Carpenter
2022-11-21 8:00 ` [EXT] " Geethasowjanya Akula
2022-11-21 13:10 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Dan Carpenter @ 2022-11-18 15:07 UTC (permalink / raw)
To: Sunil Goutham, Geetha sowjanya
Cc: Linu Cherian, Jerin Jacob, hariprasad, Subbaraya Sundeep,
David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
Vamsi Attunuru, netdev, kernel-janitors
This code accidentally uses the RX macro twice instead of the RX and TX.
Fixes: 6c635f78c474 ("octeontx2-af: cn10k: mcs: Handle MCS block interrupts")
Signed-off-by: Dan Carpenter <error27@gmail.com>
---
Applies to net.
drivers/net/ethernet/marvell/octeontx2/af/mcs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/marvell/octeontx2/af/mcs.c b/drivers/net/ethernet/marvell/octeontx2/af/mcs.c
index 4a343f853b28..c0bedf402da9 100644
--- a/drivers/net/ethernet/marvell/octeontx2/af/mcs.c
+++ b/drivers/net/ethernet/marvell/octeontx2/af/mcs.c
@@ -951,7 +951,7 @@ static void mcs_bbe_intr_handler(struct mcs *mcs, u64 intr, enum mcs_direction d
else
event.intr_mask = (dir == MCS_RX) ?
MCS_BBE_RX_PLFIFO_OVERFLOW_INT :
- MCS_BBE_RX_PLFIFO_OVERFLOW_INT;
+ MCS_BBE_TX_PLFIFO_OVERFLOW_INT;
/* Notify the lmac_id info which ran into BBE fatal error */
event.lmac_id = i & 0x3ULL;
--
2.35.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [EXT] [PATCH net] octeontx2-af: cn10k: mcs: Fix copy and paste bug in mcs_bbe_intr_handler()
2022-11-18 15:07 [PATCH net] octeontx2-af: cn10k: mcs: Fix copy and paste bug in mcs_bbe_intr_handler() Dan Carpenter
@ 2022-11-21 8:00 ` Geethasowjanya Akula
2022-11-21 13:10 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Geethasowjanya Akula @ 2022-11-21 8:00 UTC (permalink / raw)
To: Dan Carpenter, Sunil Kovvuri Goutham
Cc: Linu Cherian, Jerin Jacob Kollanukkaran, Hariprasad Kelam,
Subbaraya Sundeep Bhatta, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, Vamsi Krishna Attunuru, netdev,
kernel-janitors
ACK.
Thanks for the patch.
Geetha.
________________________________________
From: Dan Carpenter <error27@gmail.com>
Sent: Friday, November 18, 2022 8:37 PM
To: Sunil Kovvuri Goutham; Geethasowjanya Akula
Cc: Linu Cherian; Jerin Jacob Kollanukkaran; Hariprasad Kelam; Subbaraya Sundeep Bhatta; David S. Miller; Eric Dumazet; Jakub Kicinski; Paolo Abeni; Vamsi Krishna Attunuru; netdev@vger.kernel.org; kernel-janitors@vger.kernel.org
Subject: [EXT] [PATCH net] octeontx2-af: cn10k: mcs: Fix copy and paste bug in mcs_bbe_intr_handler()
External Email
----------------------------------------------------------------------
This code accidentally uses the RX macro twice instead of the RX and TX.
Fixes: 6c635f78c474 ("octeontx2-af: cn10k: mcs: Handle MCS block interrupts")
Signed-off-by: Dan Carpenter <error27@gmail.com>
---
Applies to net.
drivers/net/ethernet/marvell/octeontx2/af/mcs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/marvell/octeontx2/af/mcs.c b/drivers/net/ethernet/marvell/octeontx2/af/mcs.c
index 4a343f853b28..c0bedf402da9 100644
--- a/drivers/net/ethernet/marvell/octeontx2/af/mcs.c
+++ b/drivers/net/ethernet/marvell/octeontx2/af/mcs.c
@@ -951,7 +951,7 @@ static void mcs_bbe_intr_handler(struct mcs *mcs, u64 intr, enum mcs_direction d
else
event.intr_mask = (dir == MCS_RX) ?
MCS_BBE_RX_PLFIFO_OVERFLOW_INT :
- MCS_BBE_RX_PLFIFO_OVERFLOW_INT;
+ MCS_BBE_TX_PLFIFO_OVERFLOW_INT;
/* Notify the lmac_id info which ran into BBE fatal error */
event.lmac_id = i & 0x3ULL;
--
2.35.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net] octeontx2-af: cn10k: mcs: Fix copy and paste bug in mcs_bbe_intr_handler()
2022-11-18 15:07 [PATCH net] octeontx2-af: cn10k: mcs: Fix copy and paste bug in mcs_bbe_intr_handler() Dan Carpenter
2022-11-21 8:00 ` [EXT] " Geethasowjanya Akula
@ 2022-11-21 13:10 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2022-11-21 13:10 UTC (permalink / raw)
To: Dan Carpenter
Cc: sgoutham, gakula, lcherian, jerinj, hkelam, sbhatta, davem,
edumazet, kuba, pabeni, vattunuru, netdev, kernel-janitors
Hello:
This patch was applied to netdev/net.git (master)
by David S. Miller <davem@davemloft.net>:
On Fri, 18 Nov 2022 18:07:54 +0300 you wrote:
> This code accidentally uses the RX macro twice instead of the RX and TX.
>
> Fixes: 6c635f78c474 ("octeontx2-af: cn10k: mcs: Handle MCS block interrupts")
> Signed-off-by: Dan Carpenter <error27@gmail.com>
> ---
> Applies to net.
>
> [...]
Here is the summary with links:
- [net] octeontx2-af: cn10k: mcs: Fix copy and paste bug in mcs_bbe_intr_handler()
https://git.kernel.org/netdev/net/c/badbda1a0186
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-11-21 13:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-18 15:07 [PATCH net] octeontx2-af: cn10k: mcs: Fix copy and paste bug in mcs_bbe_intr_handler() Dan Carpenter
2022-11-21 8:00 ` [EXT] " Geethasowjanya Akula
2022-11-21 13:10 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).