[Need Help] tls selftest failed

[Need Help] tls selftest failed

[Hangbin Liu]

Hi Jakub,

The RedHat CKI got failures when run the net/tls selftest on net-next 6.1.0-rc4
and mainline 6.1.0-rc5 kernel. Here is an example failure[1] with mainline
6.1.0-rc5 kernel[2]. The config link is here[3]. Would you please help
check if there is issue with the test? Please tell me if you can't
access the URLs, then I will attach the config file.

ok 200 tls.13_chacha.shutdown_unsent
#  RUN           tls.13_chacha.shutdown_reuse ...
#            OK  tls.13_chacha.shutdown_reuse
ok 201 tls.13_chacha.shutdown_reuse
#  RUN           tls.13_sm4_gcm.sendfile ...
# tls.c:323:sendfile:Expected ret (-1) == 0 (0)
# sendfile: Test terminated by assertion
#          FAIL  tls.13_sm4_gcm.sendfile
not ok 202 tls.13_sm4_gcm.sendfile
#  RUN           tls.13_sm4_gcm.send_then_sendfile ...
# tls.c:323:send_then_sendfile:Expected ret (-1) == 0 (0)
# send_then_sendfile: Test terminated by assertion
#          FAIL  tls.13_sm4_gcm.send_then_sendfile
not ok 203 tls.13_sm4_gcm.send_then_sendfile
#  RUN           tls.13_sm4_gcm.multi_chunk_sendfile ...
# tls.c:323:multi_chunk_sendfile:Expected ret (-1) == 0 (0)
# multi_chunk_sendfile: Test terminated by assertion
#          FAIL  tls.13_sm4_gcm.multi_chunk_sendfile
not ok 204 tls.13_sm4_gcm.multi_chunk_sendfile
#  RUN           tls.13_sm4_gcm.recv_max ...
# tls.c:323:recv_max:Expected ret (-1) == 0 (0)
# recv_max: Test terminated by assertion
#          FAIL  tls.13_sm4_gcm.recv_max
not ok 205 tls.13_sm4_gcm.recv_max
[...snip...]
not ok 298 tls.13_sm4_ccm.shutdown_unsent
#  RUN           tls.13_sm4_ccm.shutdown_reuse ...
# tls.c:323:shutdown_reuse:Expected ret (-1) == 0 (0)
# shutdown_reuse: Test terminated by assertion
#          FAIL  tls.13_sm4_ccm.shutdown_reuse
not ok 299 tls.13_sm4_ccm.shutdown_reuse
#  RUN           tls.12_aes_ccm.sendfile ...
#            OK  tls.12_aes_ccm.sendfile
ok 300 tls.12_aes_ccm.sendfile

[1] https://s3.amazonaws.com/arr-cki-prod-trusted-artifacts/trusted-artifacts/698017956/test%20x86_64%20debug/3340789088/artifacts/run.done.02/results_0001/RESULTS_J%3A7251979_0_R_12962453_T_38_test-kselftest/kselftests.6..82%20selftests%3A%20net%3Atls%20%5BFAIL%5D/resultoutputfile.log
[2] https://datawarehouse.cki-project.org/kcidb/checkouts/60286
[3] https://s3.amazonaws.com/arr-cki-prod-trusted-artifacts/index.html?prefix=trusted-artifacts/698017956/build%20x86_64%20debug/3340789060/artifacts/

Thanks
Hangbin

Re: [Need Help] tls selftest failed

[Jakub Kicinski]

On Fri, 18 Nov 2022 16:09:48 +0800 Hangbin Liu wrote:
> Hi Jakub,
> 
> The RedHat CKI got failures when run the net/tls selftest on net-next 6.1.0-rc4
> and mainline 6.1.0-rc5 kernel. Here is an example failure[1] with mainline
> 6.1.0-rc5 kernel[2]. The config link is here[3]. Would you please help
> check if there is issue with the test? Please tell me if you can't
> access the URLs, then I will attach the config file.

Hm, looks like a config problem. CRYPTO_SM4 is not enabled in the
config, even tho it's listed in tools/testing/selftests/net/config. 
Maybe it's not the right symbol to list in the test, or there is
a dependency we missed?

Re: [Need Help] tls selftest failed

[Hangbin Liu]

On Fri, Nov 18, 2022 at 08:13:09AM -0800, Jakub Kicinski wrote:
> On Fri, 18 Nov 2022 16:09:48 +0800 Hangbin Liu wrote:
> > Hi Jakub,
> > 
> > The RedHat CKI got failures when run the net/tls selftest on net-next 6.1.0-rc4
> > and mainline 6.1.0-rc5 kernel. Here is an example failure[1] with mainline
> > 6.1.0-rc5 kernel[2]. The config link is here[3]. Would you please help
> > check if there is issue with the test? Please tell me if you can't
> > access the URLs, then I will attach the config file.
> 
> Hm, looks like a config problem. CRYPTO_SM4 is not enabled in the
> config, even tho it's listed in tools/testing/selftests/net/config. 
> Maybe it's not the right symbol to list in the test, or there is
> a dependency we missed?

From the build log[1], the CKI will read selftests/net/config and reset
CONFIGs if it is not defined or need redefined. e.g.

```
Value of CONFIG_MPLS_IPTUNNEL is redefined by fragment
./tools/testing/selftests/net/config:
Previous value: CONFIG_MPLS_IPTUNNEL=y
New value: CONFIG_MPLS_IPTUNNEL=m

Value of CONFIG_NET_SCH_INGRESS is redefined by fragment
./tools/testing/selftests/net/config:
Previous value: CONFIG_NET_SCH_INGRESS=y
New value: CONFIG_NET_SCH_INGRESS=m

Value of CONFIG_NET_CLS_FLOWER is redefined by fragment
./tools/testing/selftests/net/config:
Previous value: CONFIG_NET_CLS_FLOWER=y
New value: CONFIG_NET_CLS_FLOWER=m
```

And in the config file[2], all the CONFIGs in selftests/net/config are
set correctly except CONFIG_CRYPTO_SM4. I saw in the config file it shows

# CONFIG_CRYPTO_SM4_GENERIC is not set

Is there any dependence for CONFIG_CRYPTO_SM4?

[1] https://s3.amazonaws.com/arr-cki-prod-trusted-artifacts/trusted-artifacts/698017956/build%20x86_64%20debug/3340789060/artifacts/build.log
[2]
https://s3.amazonaws.com/arr-cki-prod-trusted-artifacts/trusted-artifacts/698017956/build%20x86_64%20debug/3340789060/artifacts/kernel-mainline.kernel.org-redhat_698017956_x86_64_debug.config

Thanks
Hangbin

Re: [Need Help] tls selftest failed

[Jakub Kicinski]

On Sun, 20 Nov 2022 11:17:17 +0800 Hangbin Liu wrote:
> On Fri, Nov 18, 2022 at 08:13:09AM -0800, Jakub Kicinski wrote:
> > Hm, looks like a config problem. CRYPTO_SM4 is not enabled in the
> > config, even tho it's listed in tools/testing/selftests/net/config. 
> > Maybe it's not the right symbol to list in the test, or there is
> > a dependency we missed?  
> 
> From the build log[1], the CKI will read selftests/net/config and reset
> CONFIGs if it is not defined or need redefined. e.g.
> 
> ```
> Value of CONFIG_MPLS_IPTUNNEL is redefined by fragment
> ./tools/testing/selftests/net/config:
> Previous value: CONFIG_MPLS_IPTUNNEL=y
> New value: CONFIG_MPLS_IPTUNNEL=m
> 
> Value of CONFIG_NET_SCH_INGRESS is redefined by fragment
> ./tools/testing/selftests/net/config:
> Previous value: CONFIG_NET_SCH_INGRESS=y
> New value: CONFIG_NET_SCH_INGRESS=m
> 
> Value of CONFIG_NET_CLS_FLOWER is redefined by fragment
> ./tools/testing/selftests/net/config:
> Previous value: CONFIG_NET_CLS_FLOWER=y
> New value: CONFIG_NET_CLS_FLOWER=m
> ```

But these only list downgrades from =y to =m,
none of them actually enable things.
 
> And in the config file[2], all the CONFIGs in selftests/net/config are
> set correctly except CONFIG_CRYPTO_SM4. I saw in the config file it shows
> 
> # CONFIG_CRYPTO_SM4_GENERIC is not set
> 
> Is there any dependence for CONFIG_CRYPTO_SM4?

none that I can see:

config CRYPTO_SM4
        tristate

Re: [Need Help] tls selftest failed

[Hangbin Liu]

On Mon, Nov 21, 2022 at 09:33:24AM -0800, Jakub Kicinski wrote:
> > Value of CONFIG_NET_CLS_FLOWER is redefined by fragment
> > ./tools/testing/selftests/net/config:
> > Previous value: CONFIG_NET_CLS_FLOWER=y
> > New value: CONFIG_NET_CLS_FLOWER=m
> > ```
> 
> But these only list downgrades from =y to =m,
> none of them actually enable things.

There are some configs upgrades from m to y, e.g.

Value of CONFIG_NET_SCH_NETEM is redefined by fragment ./tools/testing/selftests/net/config:
Previous value: CONFIG_NET_SCH_NETEM=m
New value: CONFIG_NET_SCH_NETEM=y

>  
> > And in the config file[2], all the CONFIGs in selftests/net/config are
> > set correctly except CONFIG_CRYPTO_SM4. I saw in the config file it shows
> > 
> > # CONFIG_CRYPTO_SM4_GENERIC is not set
> > 
> > Is there any dependence for CONFIG_CRYPTO_SM4?
> 
> none that I can see:
> 
> config CRYPTO_SM4
>         tristate

Thanks for the info. There should has mis-configs somewhere. I will check it.

Hangbin