From: Greg KH <greg@kroah.com>
To: "Bjørn Mork" <bjorn@mork.no>
Cc: Jakub Kicinski <kuba@kernel.org>,
Andre Przywara <andre.przywara@arm.com>,
Paolo Abeni <pabeni@redhat.com>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
linux-usb@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] r8152; preserve device list format
Date: Thu, 12 Jan 2023 11:21:58 +0100 [thread overview]
Message-ID: <Y7/fRlDqFRUOle7a@kroah.com> (raw)
In-Reply-To: <87cz7k6ooc.fsf@miraculix.mork.no>
On Thu, Jan 12, 2023 at 11:18:59AM +0100, Bjørn Mork wrote:
> Greg KH <greg@kroah.com> writes:
> > On Thu, Jan 12, 2023 at 11:01:00AM +0100, Bjørn Mork wrote:
> >> This is a partial revert of commit ec51fbd1b8a2 ("r8152:
> >> add USB device driver for config selection")
> >>
> >> Keep a simplified version of the REALTEK_USB_DEVICE macro
> >> to avoid unnecessary reformatting of the device list. This
> >> makes new device ID additions apply cleanly across driver
> >> versions.
> >>
> >> Fixes: ec51fbd1b8a2 ("r8152: add USB device driver for config selection")
> >> Signed-off-by: Bjørn Mork <bjorn@mork.no>
> >> ---
> >> The patch in
> >> https://lore.kernel.org/lkml/20230111133228.190801-1-andre.przywara@arm.com/
> >> will apply cleanly on top of this.
> >>
> >> This fix will also prevent a lot of stable backporting hassle.
> >
> > No need for this, just backport the original change to older kernels and
> > all will be fine.
> >
> > Don't live with stuff you don't want to because of stable kernels,
> > that's not how this whole process works at all :)
>
> OK, thanks. Will prepare a patch for stable instead then.
>
> But I guess the original patch is unacceptable for stable as-is? It
> changes how Linux react to these devces, and includes a completely new
> USB device driver (i.e not interface driver).
That's up to you all. We don't add new support for new hardware to
older kernels _UNLESS_ it's just a new device id. Otherwise it's just
better to tell people to upgrade to the newer kernel.
If you split things up and added a whole new driver, then just leave it
alone, no need to backport anything, sorry, I didn't realize that.
greg k-h
next prev parent reply other threads:[~2023-01-12 10:26 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-11 13:32 [PATCH net-next] r8152: add vendor/device ID pair for Microsoft Devkit Andre Przywara
2023-01-12 5:31 ` Jakub Kicinski
2023-01-12 8:33 ` Bjørn Mork
2023-01-12 10:00 ` Greg KH
2023-01-12 10:01 ` [PATCH net-next] r8152; preserve device list format Bjørn Mork
2023-01-12 10:12 ` Greg KH
2023-01-12 10:18 ` Bjørn Mork
2023-01-12 10:21 ` Greg KH [this message]
2023-01-12 10:29 ` Bjørn Mork
2023-01-12 10:36 ` Greg KH
2023-01-13 10:16 ` Bjørn Mork
2023-01-13 19:54 ` Jakub Kicinski
2023-01-12 10:51 ` [PATCH net-next] r8152: add vendor/device ID pair for Microsoft Devkit Andre Przywara
2023-01-12 11:39 ` Paolo Abeni
2023-01-12 11:56 ` Andre Przywara
2023-01-12 13:08 ` Paolo Abeni
2023-01-12 13:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y7/fRlDqFRUOle7a@kroah.com \
--to=greg@kroah.com \
--cc=andre.przywara@arm.com \
--cc=bjorn@mork.no \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).