From: Greg KH <greg@kroah.com>
To: "Bjørn Mork" <bjorn@mork.no>
Cc: Jakub Kicinski <kuba@kernel.org>,
Andre Przywara <andre.przywara@arm.com>,
Paolo Abeni <pabeni@redhat.com>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
linux-usb@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] r8152; preserve device list format
Date: Thu, 12 Jan 2023 11:36:31 +0100 [thread overview]
Message-ID: <Y7/ir/zcJQUVec72@kroah.com> (raw)
In-Reply-To: <878ri86o6j.fsf@miraculix.mork.no>
On Thu, Jan 12, 2023 at 11:29:40AM +0100, Bjørn Mork wrote:
> Bjørn Mork <bjorn@mork.no> writes:
> > Greg KH <greg@kroah.com> writes:
> >
> >> No need for this, just backport the original change to older kernels and
> >> all will be fine.
> >>
> >> Don't live with stuff you don't want to because of stable kernels,
> >> that's not how this whole process works at all :)
> >
> > OK, thanks. Will prepare a patch for stable instead then.
> >
> > But I guess the original patch is unacceptable for stable as-is? It
> > changes how Linux react to these devces, and includes a completely new
> > USB device driver (i.e not interface driver).
>
> Doh! I gotta start thinking before I send email. Will start right
> after sending this one ;-)
>
> We cannot backport the device-id table change to stable without taking
> the rest of the patch. The strategy used by the old driver needs two
> entries per device ID, which is why the macro was there.
>
> So the question is: Can commit ec51fbd1b8a2 ("r8152: add USB device
> driver for config selection") be accepted in stable?
>
> ( Direct link for convenience since it's not yet in mainline:
> https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/commit/drivers/net/usb/r8152.c?id=ec51fbd1b8a2bca2948dede99c14ec63dc57ff6b
> )
>
> This is not within the rules as I read them, but it's your call...
Ah, yeah, that's simple enough, I'd take it if you send it to me :)
greg k-h
next prev parent reply other threads:[~2023-01-12 10:42 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-11 13:32 [PATCH net-next] r8152: add vendor/device ID pair for Microsoft Devkit Andre Przywara
2023-01-12 5:31 ` Jakub Kicinski
2023-01-12 8:33 ` Bjørn Mork
2023-01-12 10:00 ` Greg KH
2023-01-12 10:01 ` [PATCH net-next] r8152; preserve device list format Bjørn Mork
2023-01-12 10:12 ` Greg KH
2023-01-12 10:18 ` Bjørn Mork
2023-01-12 10:21 ` Greg KH
2023-01-12 10:29 ` Bjørn Mork
2023-01-12 10:36 ` Greg KH [this message]
2023-01-13 10:16 ` Bjørn Mork
2023-01-13 19:54 ` Jakub Kicinski
2023-01-12 10:51 ` [PATCH net-next] r8152: add vendor/device ID pair for Microsoft Devkit Andre Przywara
2023-01-12 11:39 ` Paolo Abeni
2023-01-12 11:56 ` Andre Przywara
2023-01-12 13:08 ` Paolo Abeni
2023-01-12 13:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y7/ir/zcJQUVec72@kroah.com \
--to=greg@kroah.com \
--cc=andre.przywara@arm.com \
--cc=bjorn@mork.no \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).