* [PATCH] netdevsim: fib: remove unneeded semicolon
@ 2021-02-22 9:47 Jiapeng Chong
2021-02-22 9:58 ` Ido Schimmel
0 siblings, 1 reply; 2+ messages in thread
From: Jiapeng Chong @ 2021-02-22 9:47 UTC (permalink / raw)
To: kuba; +Cc: davem, netdev, linux-kernel, Jiapeng Chong
Fix the following coccicheck warnings:
./drivers/net/netdevsim/fib.c:564:2-3: Unneeded semicolon.
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
drivers/net/netdevsim/fib.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/netdevsim/fib.c b/drivers/net/netdevsim/fib.c
index 46fb414..11b43ce 100644
--- a/drivers/net/netdevsim/fib.c
+++ b/drivers/net/netdevsim/fib.c
@@ -561,7 +561,7 @@ static void nsim_fib6_rt_nh_del(struct nsim_fib6_rt *fib6_rt,
err_fib6_rt_nh_del:
for (i--; i >= 0; i--) {
nsim_fib6_rt_nh_del(fib6_rt, rt_arr[i]);
- };
+ }
nsim_fib_rt_fini(&fib6_rt->common);
kfree(fib6_rt);
return ERR_PTR(err);
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] netdevsim: fib: remove unneeded semicolon
2021-02-22 9:47 [PATCH] netdevsim: fib: remove unneeded semicolon Jiapeng Chong
@ 2021-02-22 9:58 ` Ido Schimmel
0 siblings, 0 replies; 2+ messages in thread
From: Ido Schimmel @ 2021-02-22 9:58 UTC (permalink / raw)
To: Jiapeng Chong; +Cc: kuba, davem, netdev, linux-kernel
On Mon, Feb 22, 2021 at 05:47:04PM +0800, Jiapeng Chong wrote:
> Fix the following coccicheck warnings:
>
> ./drivers/net/netdevsim/fib.c:564:2-3: Unneeded semicolon.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
> drivers/net/netdevsim/fib.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/netdevsim/fib.c b/drivers/net/netdevsim/fib.c
> index 46fb414..11b43ce 100644
> --- a/drivers/net/netdevsim/fib.c
> +++ b/drivers/net/netdevsim/fib.c
> @@ -561,7 +561,7 @@ static void nsim_fib6_rt_nh_del(struct nsim_fib6_rt *fib6_rt,
> err_fib6_rt_nh_del:
> for (i--; i >= 0; i--) {
> nsim_fib6_rt_nh_del(fib6_rt, rt_arr[i]);
> - };
> + }
You can simply remove the braces since they are not needed
> nsim_fib_rt_fini(&fib6_rt->common);
> kfree(fib6_rt);
> return ERR_PTR(err);
> --
> 1.8.3.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-02-22 9:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-22 9:47 [PATCH] netdevsim: fib: remove unneeded semicolon Jiapeng Chong
2021-02-22 9:58 ` Ido Schimmel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).