netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Pavel Balaev <mail@void.so>
To: netdev@vger.kernel.org
Cc: christophe.jaillet@wanadoo.fr, kuba@kernel.org,
	yoshfuji@linux-ipv6.org, dsahern@kernel.org
Subject: Re: [PATCH v3 net-next] net: multipath routing: configurable seed
Date: Wed, 14 Apr 2021 10:45:47 +0300	[thread overview]
Message-ID: <YHadq3m1bBWrPQn7@rnd> (raw)
In-Reply-To: <20210413.161521.2301224176572441397.davem@davemloft.net>

On Tue, Apr 13, 2021 at 04:15:21PM -0700, David Miller wrote:
> From: Balaev Pavel <balaevpa@infotecs.ru>
> Date: Tue, 13 Apr 2021 14:55:04 +0300
> 
> > @@ -222,6 +230,9 @@ struct netns_ipv4 {
> >  #ifdef CONFIG_IP_ROUTE_MULTIPATH
> >  	u8 sysctl_fib_multipath_use_neigh;
> >  	u8 sysctl_fib_multipath_hash_policy;
> > +	int sysctl_fib_multipath_hash_seed;
> > +	struct multipath_seed_ctx __rcu *fib_multipath_hash_seed_ctx;
> > +	spinlock_t fib_multipath_hash_seed_ctx_lock;
> 
> Maybe use the rtnl mutex instead of this custom spinlock?
> 
> Thanks.
Thanks for advise, I will use it in next patch version.

  reply	other threads:[~2021-04-14  7:47 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-13 11:55 [PATCH v3 net-next] net: multipath routing: configurable seed Balaev Pavel
2021-04-13 23:15 ` David Miller
2021-04-14  7:45   ` Pavel Balaev [this message]
2021-04-14  3:28 ` David Ahern
2021-04-14  7:33   ` Pavel Balaev
2021-04-15  3:24     ` David Ahern
2021-04-15  8:20       ` Pavel Balaev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YHadq3m1bBWrPQn7@rnd \
    --to=mail@void.so \
    --cc=christophe.jaillet@wanadoo.fr \
    --cc=dsahern@kernel.org \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=yoshfuji@linux-ipv6.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).