From: Pavel Balaev <mail@void.so>
To: netdev@vger.kernel.org
Subject: Re: [PATCH v3 net-next] net: multipath routing: configurable seed
Date: Thu, 15 Apr 2021 11:20:46 +0300 [thread overview]
Message-ID: <YHf3XtDOhDfUppSS@rnd> (raw)
In-Reply-To: <bcf3a5d5-bfbd-d8d3-05e9-ad506e6a689e@gmail.com>
On Wed, Apr 14, 2021 at 08:24:11PM -0700, David Ahern wrote:
> On 4/14/21 12:33 AM, Pavel Balaev wrote:
> >>
> >> This should work the same for IPv6.
> > I wanted to add IPv6 support after IPv4 will be approved,
> > anyway no problem, will add IPv6 in next version
> >> And please add test cases under tools/testing/selftests/net.
> > This feature cannot be tested whithin one host instance, becasue the same seed
> > will be used by default for all netns, so results will be the same
> > anyway, should I use QEMU for this tests?
> >
> >
>
> why not make the seed per namespace?
In patch seed is maked per namespace. I mean that I cannot check default
behaviour whitin one host: sysctl net.ipv4.fib_multipath_hash_seed=random.
In this case system random seed will be used (same for all netns,
as it was before my patch).
We can only test two cases:
netns0: net.ipv4.fib_multipath_hash_seed=${SEED_0}
netns1: net.ipv4.fib_multipath_hash_seed=${SEED_1}
flows direction will not be the same.
netns0: net.ipv4.fib_multipath_hash_seed=${SEED_0}
netns1: net.ipv4.fib_multipath_hash_seed=${SEED_0}
flows direction will be the same.
Is this enough?
prev parent reply other threads:[~2021-04-15 8:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-13 11:55 [PATCH v3 net-next] net: multipath routing: configurable seed Balaev Pavel
2021-04-13 23:15 ` David Miller
2021-04-14 7:45 ` Pavel Balaev
2021-04-14 3:28 ` David Ahern
2021-04-14 7:33 ` Pavel Balaev
2021-04-15 3:24 ` David Ahern
2021-04-15 8:20 ` Pavel Balaev [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YHf3XtDOhDfUppSS@rnd \
--to=mail@void.so \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).