From: Andrew Lunn <andrew@lunn.ch>
To: Liang Xu <lxu@maxlinear.com>
Cc: "hkallweit1@gmail.com" <hkallweit1@gmail.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"davem@davemloft.net" <davem@davemloft.net>,
"kuba@kernel.org" <kuba@kernel.org>,
"vee.khee.wong@linux.intel.com" <vee.khee.wong@linux.intel.com>,
"linux@armlinux.org.uk" <linux@armlinux.org.uk>,
Hauke Mehrtens <hmehrtens@maxlinear.com>,
Thomas Mohren <tmohren@maxlinear.com>
Subject: Re: [PATCH v2] net: phy: add Maxlinear GPY115/21x/24x driver
Date: Mon, 7 Jun 2021 14:15:49 +0200 [thread overview]
Message-ID: <YL4N9XMFKOrRdH4l@lunn.ch> (raw)
In-Reply-To: <f329dca8-9962-0b43-eaa7-cbed838d5dc0@maxlinear.com>
> Yes, they all have same product number.
>
> They are one IP.
O.K, this is the sort of information which is useful to have in the
commit message. Basically anything which is odd about your PHY it is
good to mention, because reviewers are probably going to notice and
ask.
> The difference is feature set it's enabled by fusing in silicon.
>
> For example, GPY115 has 10/100/1000Mbps support, so in the ability
> register 2.5G capable is 0.
>
> GPY211 has 10/100/1000/2500Mbps support, so in the capability register
> 2.5G capable is 1.
I assume it is more than just the capability register? Linux could
easily ignore that and make use of 2.5G if it still actually works.
Andrew
next prev parent reply other threads:[~2021-06-07 12:16 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-03 7:34 [PATCH v2] net: phy: add Maxlinear GPY115/21x/24x driver Xu Liang
2021-06-03 9:17 ` Russell King (Oracle)
2021-06-03 10:36 ` Liang Xu
2021-06-03 15:10 ` Liang Xu
2021-06-03 15:21 ` Andrew Lunn
2021-06-03 15:32 ` Liang Xu
2021-06-03 17:05 ` Andrew Lunn
2021-06-03 17:54 ` Liang Xu
2021-06-04 12:09 ` Andrew Lunn
2021-06-04 12:39 ` Liang Xu
2021-06-04 12:15 ` Andrew Lunn
2021-06-04 12:52 ` Liang Xu
2021-06-04 20:39 ` Andrew Lunn
2021-06-05 3:46 ` Liang Xu
2021-06-05 14:37 ` Andrew Lunn
2021-06-07 4:04 ` Liang Xu
2021-06-07 12:15 ` Andrew Lunn [this message]
2021-06-07 13:28 ` Liang Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YL4N9XMFKOrRdH4l@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=hkallweit1@gmail.com \
--cc=hmehrtens@maxlinear.com \
--cc=kuba@kernel.org \
--cc=linux@armlinux.org.uk \
--cc=lxu@maxlinear.com \
--cc=netdev@vger.kernel.org \
--cc=tmohren@maxlinear.com \
--cc=vee.khee.wong@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).