From: Andrew Lunn <andrew@lunn.ch>
To: Liang Xu <lxu@maxlinear.com>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
"hkallweit1@gmail.com" <hkallweit1@gmail.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"davem@davemloft.net" <davem@davemloft.net>,
"kuba@kernel.org" <kuba@kernel.org>,
"vee.khee.wong@linux.intel.com" <vee.khee.wong@linux.intel.com>,
"linux@armlinux.org.uk" <linux@armlinux.org.uk>,
Hauke Mehrtens <hmehrtens@maxlinear.com>,
Thomas Mohren <tmohren@maxlinear.com>
Subject: Re: [PATCH v3] net: phy: add Maxlinear GPY115/21x/24x driver
Date: Mon, 21 Jun 2021 04:30:39 +0200 [thread overview]
Message-ID: <YM/5z1hgIkx6Fq6I@lunn.ch> (raw)
In-Reply-To: <2f6c23fd-724e-c9e0-83f2-791cb747d846@maxlinear.com>
On Fri, Jun 18, 2021 at 03:36:35PM +0000, Liang Xu wrote:
> On 18/6/2021 10:01 pm, Andrew Lunn wrote:
> > This email was sent from outside of MaxLinear.
> >
> >
> >> Net-next:
> >>
> >> int genphy_loopback(struct phy_device *phydev, bool enable)
> >> {
> >> if (enable) {
> >> u16 val, ctl = BMCR_LOOPBACK;
> >> int ret;
> >>
> >> if (phydev->speed == SPEED_1000)
> >> ctl |= BMCR_SPEED1000;
> >> else if (phydev->speed == SPEED_100)
> >> ctl |= BMCR_SPEED100;
> The problem happens in the speed change no matter it's forced or
> auto-neg in our device.
You say speed change. So do you just need to add support for 10Mbps,
so there is no speed change? Or are you saying phydev->speed does not
match the actual speed?
Andrew
next prev parent reply other threads:[~2021-06-21 2:30 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-04 16:12 [PATCH v3] net: phy: add Maxlinear GPY115/21x/24x driver Xu Liang
2021-06-04 16:24 ` Florian Fainelli
2021-06-04 18:24 ` Liang Xu
2021-06-04 20:10 ` Andrew Lunn
2021-06-05 3:35 ` Liang Xu
2021-06-05 14:51 ` Andrew Lunn
2021-06-07 4:06 ` Liang Xu
2021-06-18 9:17 ` Liang Xu
2021-06-18 14:01 ` Andrew Lunn
2021-06-18 15:36 ` Liang Xu
2021-06-21 2:30 ` Andrew Lunn [this message]
2021-06-21 5:05 ` Liang Xu
2021-06-21 12:48 ` Andrew Lunn
2021-06-21 13:07 ` Liang Xu
2021-06-04 18:37 ` Liang Xu
2021-06-04 19:44 ` Martin Blumenstingl
2021-06-05 3:32 ` Liang Xu
2021-06-05 17:24 ` Andrew Lunn
2021-06-07 4:37 ` Liang Xu
2021-06-07 20:28 ` Martin Blumenstingl
[not found] ` <MWHPR19MB0077D01E4EAFA9FE521D83ECBD0D9@MWHPR19MB0077.namprd19.prod.outlook.com>
[not found] ` <766ab274-25ff-c9a2-1ed6-fe2aa44b4660@maxlinear.com>
2021-06-23 21:09 ` Martin Blumenstingl
2021-06-24 1:06 ` Andrew Lunn
2021-06-22 4:21 Ismail, Mohammad Athari
2021-06-22 13:16 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YM/5z1hgIkx6Fq6I@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=hmehrtens@maxlinear.com \
--cc=kuba@kernel.org \
--cc=linux@armlinux.org.uk \
--cc=lxu@maxlinear.com \
--cc=netdev@vger.kernel.org \
--cc=tmohren@maxlinear.com \
--cc=vee.khee.wong@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).