From: Liang Xu <lxu@maxlinear.com>
To: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc: "andrew@lunn.ch" <andrew@lunn.ch>,
"davem@davemloft.net" <davem@davemloft.net>,
"hkallweit1@gmail.com" <hkallweit1@gmail.com>,
Hauke Mehrtens <hmehrtens@maxlinear.com>,
"kuba@kernel.org" <kuba@kernel.org>,
"linux@armlinux.org.uk" <linux@armlinux.org.uk>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Thomas Mohren <tmohren@maxlinear.com>,
"vee.khee.wong@linux.intel.com" <vee.khee.wong@linux.intel.com>
Subject: Re: [PATCH v3] net: phy: add Maxlinear GPY115/21x/24x driver
Date: Sat, 5 Jun 2021 03:32:39 +0000 [thread overview]
Message-ID: <b01a8ac2-b77e-32aa-7c9b-57de4f2d3a95@maxlinear.com> (raw)
In-Reply-To: <20210604194428.2276092-1-martin.blumenstingl@googlemail.com>
On 5/6/2021 3:44 am, Martin Blumenstingl wrote:
> This email was sent from outside of MaxLinear.
>
>
> Hello,
>
>> Add driver to support the Maxlinear GPY115, GPY211, GPY212, GPY215,
>> GPY241, GPY245 PHYs.
> to me this seems like an evolution of the Lantiq XWAY PHYs for which
> we already have a driver: intel-xway.c.
> Intel took over Lantiq some years ago and last year MaxLinear then
> took over what was formerly Lantiq from Intel.
>
> From what I can tell right away: the interrupt handling still seems
> to be the same. Also the GPHY firmware version register also was there
> on older SoCs (with two or more GPHYs embedded into the SoC). SGMII
> support is new. And I am not sure about Wake-on-LAN.
>
> Have you considered adding support for these new PHYs to intel-xway.c?
>
>
>
> Best regards,
> Martin
>
I'm thinking to separate them.
They are based on different IP and have many differences.
The XWAY PHYs are going to EoL (or maybe already EoL).
It creates difficulty for the test coverage to put together.
next prev parent reply other threads:[~2021-06-05 3:32 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-04 16:12 [PATCH v3] net: phy: add Maxlinear GPY115/21x/24x driver Xu Liang
2021-06-04 16:24 ` Florian Fainelli
2021-06-04 18:24 ` Liang Xu
2021-06-04 20:10 ` Andrew Lunn
2021-06-05 3:35 ` Liang Xu
2021-06-05 14:51 ` Andrew Lunn
2021-06-07 4:06 ` Liang Xu
2021-06-18 9:17 ` Liang Xu
2021-06-18 14:01 ` Andrew Lunn
2021-06-18 15:36 ` Liang Xu
2021-06-21 2:30 ` Andrew Lunn
2021-06-21 5:05 ` Liang Xu
2021-06-21 12:48 ` Andrew Lunn
2021-06-21 13:07 ` Liang Xu
2021-06-04 18:37 ` Liang Xu
2021-06-04 19:44 ` Martin Blumenstingl
2021-06-05 3:32 ` Liang Xu [this message]
2021-06-05 17:24 ` Andrew Lunn
2021-06-07 4:37 ` Liang Xu
2021-06-07 20:28 ` Martin Blumenstingl
[not found] ` <MWHPR19MB0077D01E4EAFA9FE521D83ECBD0D9@MWHPR19MB0077.namprd19.prod.outlook.com>
[not found] ` <766ab274-25ff-c9a2-1ed6-fe2aa44b4660@maxlinear.com>
2021-06-23 21:09 ` Martin Blumenstingl
2021-06-24 1:06 ` Andrew Lunn
2021-06-22 4:21 Ismail, Mohammad Athari
2021-06-22 13:16 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b01a8ac2-b77e-32aa-7c9b-57de4f2d3a95@maxlinear.com \
--to=lxu@maxlinear.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=hkallweit1@gmail.com \
--cc=hmehrtens@maxlinear.com \
--cc=kuba@kernel.org \
--cc=linux@armlinux.org.uk \
--cc=martin.blumenstingl@googlemail.com \
--cc=netdev@vger.kernel.org \
--cc=tmohren@maxlinear.com \
--cc=vee.khee.wong@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).