[PATCH net-next 1/1] qed: add prints if request_firmware() failed

[PATCH net-next 1/1] qed: add prints if request_firmware() failed

[Venkata Sudheer Kumar Bhavaraju]

If driver load failed due to request_firmware() not finding the device
firmware file, add prints that help remedy the situation.

Signed-off-by: Ariel Elior <aelior@marvell.com>
Signed-off-by: Alok Prasad <palok@marvell.com>
Signed-off-by: Venkata Sudheer Kumar Bhavaraju <vbhavaraju@marvell.com>
---
 drivers/net/ethernet/qlogic/qed/qed_main.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/net/ethernet/qlogic/qed/qed_main.c b/drivers/net/ethernet/qlogic/qed/qed_main.c
index 46d4207f22a3..4f5d5a1e786c 100644
--- a/drivers/net/ethernet/qlogic/qed/qed_main.c
+++ b/drivers/net/ethernet/qlogic/qed/qed_main.c
@@ -65,6 +65,9 @@ MODULE_LICENSE("GPL");
 
 MODULE_FIRMWARE(QED_FW_FILE_NAME);
 
+#define QED_FW_REPO		\
+	"https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git"
+
 /* MFW speed capabilities maps */
 
 struct qed_mfw_speed_map {
@@ -1285,6 +1288,9 @@ static int qed_slowpath_start(struct qed_dev *cdev,
 			DP_NOTICE(cdev,
 				  "Failed to find fw file - /lib/firmware/%s\n",
 				  QED_FW_FILE_NAME);
+			DP_NOTICE(cdev,
+				  "you may need to download firmware from %s",
+				  QED_FW_REPO);
 			goto err;
 		}
 
-- 
2.27.0

Re: [PATCH net-next 1/1] qed: add prints if request_firmware() failed

[Andrew Lunn]

On Sat, Dec 25, 2021 at 04:14:08PM -0800, Venkata Sudheer Kumar Bhavaraju wrote:
> If driver load failed due to request_firmware() not finding the device
> firmware file, add prints that help remedy the situation.
> 
> Signed-off-by: Ariel Elior <aelior@marvell.com>
> Signed-off-by: Alok Prasad <palok@marvell.com>
> Signed-off-by: Venkata Sudheer Kumar Bhavaraju <vbhavaraju@marvell.com>
> ---
>  drivers/net/ethernet/qlogic/qed/qed_main.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/drivers/net/ethernet/qlogic/qed/qed_main.c b/drivers/net/ethernet/qlogic/qed/qed_main.c
> index 46d4207f22a3..4f5d5a1e786c 100644
> --- a/drivers/net/ethernet/qlogic/qed/qed_main.c
> +++ b/drivers/net/ethernet/qlogic/qed/qed_main.c
> @@ -65,6 +65,9 @@ MODULE_LICENSE("GPL");
>  
>  MODULE_FIRMWARE(QED_FW_FILE_NAME);
>  
> +#define QED_FW_REPO		\
> +	"https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git"

linux-firmware is vendor/product neutral. So i would suggest dropping
the QED prefix. This URL is also used in a couple of other drivers, so
you could consider places it somewhere under include/linux/

    Andrew