* [PATCH] USB: zaurus: support another broken Zaurus
@ 2022-02-10 12:26 Oliver Neukum
2022-02-10 12:58 ` Greg KH
0 siblings, 1 reply; 6+ messages in thread
From: Oliver Neukum @ 2022-02-10 12:26 UTC (permalink / raw)
To: bids.7405, linux-usb, netdev, davem, kuba, gregKH; +Cc: Oliver Neukum
This SL-6000 says Direct Line, not Ethernet
Signed-off-by: Oliver Neukum <oneukum@suse.com>
---
drivers/net/usb/cdc_ether.c | 12 ++++++++++++
drivers/net/usb/zaurus.c | 12 ++++++++++++
2 files changed, 24 insertions(+)
diff --git a/drivers/net/usb/cdc_ether.c b/drivers/net/usb/cdc_ether.c
index eb3817d70f2b..9b4dfa3001d6 100644
--- a/drivers/net/usb/cdc_ether.c
+++ b/drivers/net/usb/cdc_ether.c
@@ -583,6 +583,11 @@ static const struct usb_device_id products[] = {
.bInterfaceSubClass = USB_CDC_SUBCLASS_ETHERNET, \
.bInterfaceProtocol = USB_CDC_PROTO_NONE
+#define ZAURUS_FAKE_INTERFACE \
+ .bInterfaceClass = USB_CLASS_COMM, \
+ .bInterfaceSubClass = USB_CDC_SUBCLASS_MDLM, \
+ .bInterfaceProtocol = USB_CDC_PROTO_NONE
+
/* SA-1100 based Sharp Zaurus ("collie"), or compatible;
* wire-incompatible with true CDC Ethernet implementations.
* (And, it seems, needlessly so...)
@@ -636,6 +641,13 @@ static const struct usb_device_id products[] = {
.idProduct = 0x9032, /* SL-6000 */
ZAURUS_MASTER_INTERFACE,
.driver_info = 0,
+}, {
+ .match_flags = USB_DEVICE_ID_MATCH_INT_INFO
+ | USB_DEVICE_ID_MATCH_DEVICE,
+ .idVendor = 0x04DD,
+ .idProduct = 0x9032, /* SL-6000 */
+ ZAURUS_FAKE_INTERFACE,
+ .driver_info = 0,
}, {
.match_flags = USB_DEVICE_ID_MATCH_INT_INFO
| USB_DEVICE_ID_MATCH_DEVICE,
diff --git a/drivers/net/usb/zaurus.c b/drivers/net/usb/zaurus.c
index 8e717a0b559b..9243be9bd2aa 100644
--- a/drivers/net/usb/zaurus.c
+++ b/drivers/net/usb/zaurus.c
@@ -256,6 +256,11 @@ static const struct usb_device_id products [] = {
.bInterfaceSubClass = USB_CDC_SUBCLASS_ETHERNET, \
.bInterfaceProtocol = USB_CDC_PROTO_NONE
+#define ZAURUS_FAKE_INTERFACE \
+ .bInterfaceClass = USB_CLASS_COMM, \
+ .bInterfaceSubClass = USB_CDC_SUBCLASS_MDLM, \
+ .bInterfaceProtocol = USB_CDC_PROTO_NONE
+
/* SA-1100 based Sharp Zaurus ("collie"), or compatible. */
{
.match_flags = USB_DEVICE_ID_MATCH_INT_INFO
@@ -313,6 +318,13 @@ static const struct usb_device_id products [] = {
.idProduct = 0x9032, /* SL-6000 */
ZAURUS_MASTER_INTERFACE,
.driver_info = ZAURUS_PXA_INFO,
+}, {
+ .match_flags = USB_DEVICE_ID_MATCH_INT_INFO
+ | USB_DEVICE_ID_MATCH_DEVICE,
+ .idVendor = 0x04DD,
+ .idProduct = 0x9032, /* SL-6000 */
+ ZAURUS_FAKE_INTERFACE,
+ .driver_info = (unsigned long) &bogus_mdlm_info,
}, {
.match_flags = USB_DEVICE_ID_MATCH_INT_INFO
| USB_DEVICE_ID_MATCH_DEVICE,
--
2.34.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] USB: zaurus: support another broken Zaurus
2022-02-10 12:26 [PATCH] USB: zaurus: support another broken Zaurus Oliver Neukum
@ 2022-02-10 12:58 ` Greg KH
2022-02-10 14:13 ` Oliver Neukum
0 siblings, 1 reply; 6+ messages in thread
From: Greg KH @ 2022-02-10 12:58 UTC (permalink / raw)
To: Oliver Neukum; +Cc: bids.7405, linux-usb, netdev, davem, kuba
On Thu, Feb 10, 2022 at 01:26:43PM +0100, Oliver Neukum wrote:
> This SL-6000 says Direct Line, not Ethernet
>
> Signed-off-by: Oliver Neukum <oneukum@suse.com>
> ---
> drivers/net/usb/cdc_ether.c | 12 ++++++++++++
> drivers/net/usb/zaurus.c | 12 ++++++++++++
> 2 files changed, 24 insertions(+)
>
> diff --git a/drivers/net/usb/cdc_ether.c b/drivers/net/usb/cdc_ether.c
> index eb3817d70f2b..9b4dfa3001d6 100644
> --- a/drivers/net/usb/cdc_ether.c
> +++ b/drivers/net/usb/cdc_ether.c
> @@ -583,6 +583,11 @@ static const struct usb_device_id products[] = {
> .bInterfaceSubClass = USB_CDC_SUBCLASS_ETHERNET, \
> .bInterfaceProtocol = USB_CDC_PROTO_NONE
>
> +#define ZAURUS_FAKE_INTERFACE \
> + .bInterfaceClass = USB_CLASS_COMM, \
> + .bInterfaceSubClass = USB_CDC_SUBCLASS_MDLM, \
> + .bInterfaceProtocol = USB_CDC_PROTO_NONE
> +
> /* SA-1100 based Sharp Zaurus ("collie"), or compatible;
> * wire-incompatible with true CDC Ethernet implementations.
> * (And, it seems, needlessly so...)
> @@ -636,6 +641,13 @@ static const struct usb_device_id products[] = {
> .idProduct = 0x9032, /* SL-6000 */
> ZAURUS_MASTER_INTERFACE,
> .driver_info = 0,
> +}, {
> + .match_flags = USB_DEVICE_ID_MATCH_INT_INFO
> + | USB_DEVICE_ID_MATCH_DEVICE,
> + .idVendor = 0x04DD,
> + .idProduct = 0x9032, /* SL-6000 */
> + ZAURUS_FAKE_INTERFACE,
> + .driver_info = 0,
> }, {
> .match_flags = USB_DEVICE_ID_MATCH_INT_INFO
> | USB_DEVICE_ID_MATCH_DEVICE,
> diff --git a/drivers/net/usb/zaurus.c b/drivers/net/usb/zaurus.c
> index 8e717a0b559b..9243be9bd2aa 100644
> --- a/drivers/net/usb/zaurus.c
> +++ b/drivers/net/usb/zaurus.c
> @@ -256,6 +256,11 @@ static const struct usb_device_id products [] = {
> .bInterfaceSubClass = USB_CDC_SUBCLASS_ETHERNET, \
> .bInterfaceProtocol = USB_CDC_PROTO_NONE
>
> +#define ZAURUS_FAKE_INTERFACE \
> + .bInterfaceClass = USB_CLASS_COMM, \
> + .bInterfaceSubClass = USB_CDC_SUBCLASS_MDLM, \
> + .bInterfaceProtocol = USB_CDC_PROTO_NONE
> +
> /* SA-1100 based Sharp Zaurus ("collie"), or compatible. */
> {
> .match_flags = USB_DEVICE_ID_MATCH_INT_INFO
> @@ -313,6 +318,13 @@ static const struct usb_device_id products [] = {
> .idProduct = 0x9032, /* SL-6000 */
> ZAURUS_MASTER_INTERFACE,
> .driver_info = ZAURUS_PXA_INFO,
> +}, {
> + .match_flags = USB_DEVICE_ID_MATCH_INT_INFO
> + | USB_DEVICE_ID_MATCH_DEVICE,
> + .idVendor = 0x04DD,
> + .idProduct = 0x9032, /* SL-6000 */
> + ZAURUS_FAKE_INTERFACE,
> + .driver_info = (unsigned long) &bogus_mdlm_info,
No tabs here?
And isn't there a needed "Reported-by:" for this one as it came from a
bug report?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] USB: zaurus: support another broken Zaurus
2022-02-10 12:58 ` Greg KH
@ 2022-02-10 14:13 ` Oliver Neukum
2022-02-10 14:17 ` Greg KH
0 siblings, 1 reply; 6+ messages in thread
From: Oliver Neukum @ 2022-02-10 14:13 UTC (permalink / raw)
To: Greg KH, Oliver Neukum; +Cc: bids.7405, linux-usb, netdev, davem, kuba
On 10.02.22 13:58, Greg KH wrote:
> On Thu, Feb 10, 2022 at 01:26:43PM +0100, Oliver Neukum wrote:
>> This SL-6000 says Direct Line, not Ethernet
>>
>> Signed-off-by: Oliver Neukum <oneukum@suse.com>
>> ---
>> drivers/net/usb/cdc_ether.c | 12 ++++++++++++
>> drivers/net/usb/zaurus.c | 12 ++++++++++++
>> 2 files changed, 24 insertions(+)
>>
>> diff --git a/drivers/net/usb/cdc_ether.c b/drivers/net/usb/cdc_ether.c
>> index eb3817d70f2b..9b4dfa3001d6 100644
>> --- a/drivers/net/usb/cdc_ether.c
>> +++ b/drivers/net/usb/cdc_ether.c
>> @@ -583,6 +583,11 @@ static const struct usb_device_id products[] = {
>> .bInterfaceSubClass = USB_CDC_SUBCLASS_ETHERNET, \
>> .bInterfaceProtocol = USB_CDC_PROTO_NONE
>>
>> +#define ZAURUS_FAKE_INTERFACE \
>> + .bInterfaceClass = USB_CLASS_COMM, \
>> + .bInterfaceSubClass = USB_CDC_SUBCLASS_MDLM, \
>> + .bInterfaceProtocol = USB_CDC_PROTO_NONE
>> +
>> /* SA-1100 based Sharp Zaurus ("collie"), or compatible;
>> * wire-incompatible with true CDC Ethernet implementations.
>> * (And, it seems, needlessly so...)
>> @@ -636,6 +641,13 @@ static const struct usb_device_id products[] = {
>> .idProduct = 0x9032, /* SL-6000 */
>> ZAURUS_MASTER_INTERFACE,
>> .driver_info = 0,
>> +}, {
>> + .match_flags = USB_DEVICE_ID_MATCH_INT_INFO
>> + | USB_DEVICE_ID_MATCH_DEVICE,
>> + .idVendor = 0x04DD,
>> + .idProduct = 0x9032, /* SL-6000 */
>> + ZAURUS_FAKE_INTERFACE,
>> + .driver_info = 0,
>> }, {
>> .match_flags = USB_DEVICE_ID_MATCH_INT_INFO
>> | USB_DEVICE_ID_MATCH_DEVICE,
>> diff --git a/drivers/net/usb/zaurus.c b/drivers/net/usb/zaurus.c
>> index 8e717a0b559b..9243be9bd2aa 100644
>> --- a/drivers/net/usb/zaurus.c
>> +++ b/drivers/net/usb/zaurus.c
>> @@ -256,6 +256,11 @@ static const struct usb_device_id products [] = {
>> .bInterfaceSubClass = USB_CDC_SUBCLASS_ETHERNET, \
>> .bInterfaceProtocol = USB_CDC_PROTO_NONE
>>
>> +#define ZAURUS_FAKE_INTERFACE \
>> + .bInterfaceClass = USB_CLASS_COMM, \
>> + .bInterfaceSubClass = USB_CDC_SUBCLASS_MDLM, \
>> + .bInterfaceProtocol = USB_CDC_PROTO_NONE
>> +
>> /* SA-1100 based Sharp Zaurus ("collie"), or compatible. */
>> {
>> .match_flags = USB_DEVICE_ID_MATCH_INT_INFO
>> @@ -313,6 +318,13 @@ static const struct usb_device_id products [] = {
>> .idProduct = 0x9032, /* SL-6000 */
>> ZAURUS_MASTER_INTERFACE,
>> .driver_info = ZAURUS_PXA_INFO,
>> +}, {
>> + .match_flags = USB_DEVICE_ID_MATCH_INT_INFO
>> + | USB_DEVICE_ID_MATCH_DEVICE,
>> + .idVendor = 0x04DD,
>> + .idProduct = 0x9032, /* SL-6000 */
>> + ZAURUS_FAKE_INTERFACE,
>> + .driver_info = (unsigned long) &bogus_mdlm_info,
> No tabs here?
Checking ...
>
> And isn't there a needed "Reported-by:" for this one as it came from a
> bug report?
Do we do these for reports by the kernel.org bugzilla?
Regards
Oliver
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] USB: zaurus: support another broken Zaurus
2022-02-10 14:13 ` Oliver Neukum
@ 2022-02-10 14:17 ` Greg KH
2022-02-10 14:20 ` Oliver Neukum
0 siblings, 1 reply; 6+ messages in thread
From: Greg KH @ 2022-02-10 14:17 UTC (permalink / raw)
To: Oliver Neukum; +Cc: bids.7405, linux-usb, netdev, davem, kuba
On Thu, Feb 10, 2022 at 03:13:49PM +0100, Oliver Neukum wrote:
>
> On 10.02.22 13:58, Greg KH wrote:
> > On Thu, Feb 10, 2022 at 01:26:43PM +0100, Oliver Neukum wrote:
> >> This SL-6000 says Direct Line, not Ethernet
> >>
> >> Signed-off-by: Oliver Neukum <oneukum@suse.com>
> >> ---
> >> drivers/net/usb/cdc_ether.c | 12 ++++++++++++
> >> drivers/net/usb/zaurus.c | 12 ++++++++++++
> >> 2 files changed, 24 insertions(+)
> >>
> >> diff --git a/drivers/net/usb/cdc_ether.c b/drivers/net/usb/cdc_ether.c
> >> index eb3817d70f2b..9b4dfa3001d6 100644
> >> --- a/drivers/net/usb/cdc_ether.c
> >> +++ b/drivers/net/usb/cdc_ether.c
> >> @@ -583,6 +583,11 @@ static const struct usb_device_id products[] = {
> >> .bInterfaceSubClass = USB_CDC_SUBCLASS_ETHERNET, \
> >> .bInterfaceProtocol = USB_CDC_PROTO_NONE
> >>
> >> +#define ZAURUS_FAKE_INTERFACE \
> >> + .bInterfaceClass = USB_CLASS_COMM, \
> >> + .bInterfaceSubClass = USB_CDC_SUBCLASS_MDLM, \
> >> + .bInterfaceProtocol = USB_CDC_PROTO_NONE
> >> +
> >> /* SA-1100 based Sharp Zaurus ("collie"), or compatible;
> >> * wire-incompatible with true CDC Ethernet implementations.
> >> * (And, it seems, needlessly so...)
> >> @@ -636,6 +641,13 @@ static const struct usb_device_id products[] = {
> >> .idProduct = 0x9032, /* SL-6000 */
> >> ZAURUS_MASTER_INTERFACE,
> >> .driver_info = 0,
> >> +}, {
> >> + .match_flags = USB_DEVICE_ID_MATCH_INT_INFO
> >> + | USB_DEVICE_ID_MATCH_DEVICE,
> >> + .idVendor = 0x04DD,
> >> + .idProduct = 0x9032, /* SL-6000 */
> >> + ZAURUS_FAKE_INTERFACE,
> >> + .driver_info = 0,
> >> }, {
> >> .match_flags = USB_DEVICE_ID_MATCH_INT_INFO
> >> | USB_DEVICE_ID_MATCH_DEVICE,
> >> diff --git a/drivers/net/usb/zaurus.c b/drivers/net/usb/zaurus.c
> >> index 8e717a0b559b..9243be9bd2aa 100644
> >> --- a/drivers/net/usb/zaurus.c
> >> +++ b/drivers/net/usb/zaurus.c
> >> @@ -256,6 +256,11 @@ static const struct usb_device_id products [] = {
> >> .bInterfaceSubClass = USB_CDC_SUBCLASS_ETHERNET, \
> >> .bInterfaceProtocol = USB_CDC_PROTO_NONE
> >>
> >> +#define ZAURUS_FAKE_INTERFACE \
> >> + .bInterfaceClass = USB_CLASS_COMM, \
> >> + .bInterfaceSubClass = USB_CDC_SUBCLASS_MDLM, \
> >> + .bInterfaceProtocol = USB_CDC_PROTO_NONE
> >> +
> >> /* SA-1100 based Sharp Zaurus ("collie"), or compatible. */
> >> {
> >> .match_flags = USB_DEVICE_ID_MATCH_INT_INFO
> >> @@ -313,6 +318,13 @@ static const struct usb_device_id products [] = {
> >> .idProduct = 0x9032, /* SL-6000 */
> >> ZAURUS_MASTER_INTERFACE,
> >> .driver_info = ZAURUS_PXA_INFO,
> >> +}, {
> >> + .match_flags = USB_DEVICE_ID_MATCH_INT_INFO
> >> + | USB_DEVICE_ID_MATCH_DEVICE,
> >> + .idVendor = 0x04DD,
> >> + .idProduct = 0x9032, /* SL-6000 */
> >> + ZAURUS_FAKE_INTERFACE,
> >> + .driver_info = (unsigned long) &bogus_mdlm_info,
> > No tabs here?
> Checking ...
> >
> > And isn't there a needed "Reported-by:" for this one as it came from a
> > bug report?
> Do we do these for reports by the kernel.org bugzilla?
We should, why not?
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] USB: zaurus: support another broken Zaurus
2022-02-10 14:17 ` Greg KH
@ 2022-02-10 14:20 ` Oliver Neukum
2022-02-10 14:49 ` Greg KH
0 siblings, 1 reply; 6+ messages in thread
From: Oliver Neukum @ 2022-02-10 14:20 UTC (permalink / raw)
To: Greg KH, Oliver Neukum; +Cc: bids.7405, linux-usb, netdev, davem, kuba
On 10.02.22 15:17, Greg KH wrote:
> On Thu, Feb 10, 2022 at 03:13:49PM +0100, Oliver Neukum wrote:
>>
>>> And isn't there a needed "Reported-by:" for this one as it came from a
>>> bug report?
>> Do we do these for reports by the kernel.org bugzilla?
> We should, why not?
Hi,
because it sort of implies that it was reported to a mailing list.
If there is a bugzilla for it, shouldn't we reference it?
Regards
Oliver
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] USB: zaurus: support another broken Zaurus
2022-02-10 14:20 ` Oliver Neukum
@ 2022-02-10 14:49 ` Greg KH
0 siblings, 0 replies; 6+ messages in thread
From: Greg KH @ 2022-02-10 14:49 UTC (permalink / raw)
To: Oliver Neukum; +Cc: bids.7405, linux-usb, netdev, davem, kuba
On Thu, Feb 10, 2022 at 03:20:38PM +0100, Oliver Neukum wrote:
>
> On 10.02.22 15:17, Greg KH wrote:
> > On Thu, Feb 10, 2022 at 03:13:49PM +0100, Oliver Neukum wrote:
> >>
> >>> And isn't there a needed "Reported-by:" for this one as it came from a
> >>> bug report?
> >> Do we do these for reports by the kernel.org bugzilla?
> > We should, why not?
>
> Hi,
>
>
> because it sort of implies that it was reported to a mailing list.
> If there is a bugzilla for it, shouldn't we reference it?
Yes please do that as well, that's what the "Link:" tag is for.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-02-10 14:49 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-10 12:26 [PATCH] USB: zaurus: support another broken Zaurus Oliver Neukum
2022-02-10 12:58 ` Greg KH
2022-02-10 14:13 ` Oliver Neukum
2022-02-10 14:17 ` Greg KH
2022-02-10 14:20 ` Oliver Neukum
2022-02-10 14:49 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).