netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Antonio Quartulli <antonio@openvpn.net>
Cc: Xin Long <lucien.xin@gmail.com>,
	davem@davemloft.net, Jakub Kicinski <kuba@kernel.org>,
	network dev <netdev@vger.kernel.org>,
	Willem de Bruijn <willemb@google.com>
Subject: Re: [PATCHv5 net-next 1/2] udp: call udp_encap_enable for v6 sockets when enabling encap
Date: Tue, 29 Mar 2022 15:30:40 +0200	[thread overview]
Message-ID: <YkMKAGujYMNOJMU6@kroah.com> (raw)
In-Reply-To: <3842df54-8323-e6e7-9a06-de1e78e099ae@openvpn.net>

On Tue, Mar 29, 2022 at 03:24:49PM +0200, Antonio Quartulli wrote:
> Hi all,
> 
> On 03/02/2021 09:54, Xin Long wrote:
> > When enabling encap for a ipv6 socket without udp_encap_needed_key
> > increased, UDP GRO won't work for v4 mapped v6 address packets as
> > sk will be NULL in udp4_gro_receive().
> > 
> > This patch is to enable it by increasing udp_encap_needed_key for
> > v6 sockets in udp_tunnel_encap_enable(), and correspondingly
> > decrease udp_encap_needed_key in udpv6_destroy_sock().
> > 
> 
> This is a non-negligible issue that other users (in or out of tree) may hit
> as well.
> 
> At OpenVPN we are developing a kernel device driver that has the same
> problem as UDP GRO. So far the only workaround is to let users upgrade to
> v5.12+.
> 
> I would like to propose to take this patch in stable releases.
> Greg, is this an option?
> 
> Commit in the linux kernel is:
> a4a600dd301ccde6ea239804ec1f19364a39d643


What stable tree(s) should this apply to, and where have you tested it?

thanks,

greg k-h

  reply	other threads:[~2022-03-29 13:30 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-03  8:54 [PATCHv5 net-next 0/2] net: enable udp v6 sockets receiving v4 packets with UDP Xin Long
2021-02-03  8:54 ` [PATCHv5 net-next 1/2] udp: call udp_encap_enable for v6 sockets when enabling encap Xin Long
2021-02-03  8:54   ` [PATCHv5 net-next 2/2] rxrpc: call udp_tunnel_encap_enable in rxrpc_open_socket Xin Long
2021-02-03  9:50   ` David Howells
2022-03-29 13:24   ` [PATCHv5 net-next 1/2] udp: call udp_encap_enable for v6 sockets when enabling encap Antonio Quartulli
2022-03-29 13:30     ` Greg Kroah-Hartman [this message]
2022-03-31 13:06       ` Antonio Quartulli
2022-04-02 11:28         ` Greg Kroah-Hartman
2021-02-05  3:00 ` [PATCHv5 net-next 0/2] net: enable udp v6 sockets receiving v4 packets with UDP patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YkMKAGujYMNOJMU6@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=antonio@openvpn.net \
    --cc=davem@davemloft.net \
    --cc=kuba@kernel.org \
    --cc=lucien.xin@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=willemb@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).