* [PATCH -next 1/3] net: mdio: mux-meson-g12a: Switch to use dev_err_probe() helper
@ 2022-09-15 6:50 Yang Yingliang
2022-09-15 6:50 ` [PATCH -next 2/3] net: mdio: mux-mmioreg: " Yang Yingliang
` (3 more replies)
0 siblings, 4 replies; 7+ messages in thread
From: Yang Yingliang @ 2022-09-15 6:50 UTC (permalink / raw)
To: netdev; +Cc: andrew, hkallweit1, davem, kuba
dev_err() can be replace with dev_err_probe() which will check if error
code is -EPROBE_DEFER.
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
drivers/net/mdio/mdio-mux-meson-g12a.c | 20 +++++++-------------
1 file changed, 7 insertions(+), 13 deletions(-)
diff --git a/drivers/net/mdio/mdio-mux-meson-g12a.c b/drivers/net/mdio/mdio-mux-meson-g12a.c
index b8866bc3f2e8..4a2e94faf57e 100644
--- a/drivers/net/mdio/mdio-mux-meson-g12a.c
+++ b/drivers/net/mdio/mdio-mux-meson-g12a.c
@@ -233,11 +233,9 @@ static int g12a_ephy_glue_clk_register(struct device *dev)
snprintf(in_name, sizeof(in_name), "clkin%d", i);
clk = devm_clk_get(dev, in_name);
- if (IS_ERR(clk)) {
- if (PTR_ERR(clk) != -EPROBE_DEFER)
- dev_err(dev, "Missing clock %s\n", in_name);
- return PTR_ERR(clk);
- }
+ if (IS_ERR(clk))
+ return dev_err_probe(dev, PTR_ERR(clk),
+ "Missing clock %s\n", in_name);
parent_names[i] = __clk_get_name(clk);
}
@@ -317,12 +315,9 @@ static int g12a_mdio_mux_probe(struct platform_device *pdev)
return PTR_ERR(priv->regs);
priv->pclk = devm_clk_get(dev, "pclk");
- if (IS_ERR(priv->pclk)) {
- ret = PTR_ERR(priv->pclk);
- if (ret != -EPROBE_DEFER)
- dev_err(dev, "failed to get peripheral clock\n");
- return ret;
- }
+ if (IS_ERR(priv->pclk))
+ return dev_err_probe(dev, PTR_ERR(priv->pclk),
+ "failed to get peripheral clock\n");
/* Make sure the device registers are clocked */
ret = clk_prepare_enable(priv->pclk);
@@ -339,8 +334,7 @@ static int g12a_mdio_mux_probe(struct platform_device *pdev)
ret = mdio_mux_init(dev, dev->of_node, g12a_mdio_switch_fn,
&priv->mux_handle, dev, NULL);
if (ret) {
- if (ret != -EPROBE_DEFER)
- dev_err(dev, "mdio multiplexer init failed: %d", ret);
+ dev_err_probe(dev, ret, "mdio multiplexer init failed\n");
goto err;
}
--
2.25.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* [PATCH -next 2/3] net: mdio: mux-mmioreg: Switch to use dev_err_probe() helper
2022-09-15 6:50 [PATCH -next 1/3] net: mdio: mux-meson-g12a: Switch to use dev_err_probe() helper Yang Yingliang
@ 2022-09-15 6:50 ` Yang Yingliang
2022-09-15 12:34 ` Andrew Lunn
2022-09-15 6:50 ` [PATCH -next 3/3] net: mdio: mux-multiplexer: " Yang Yingliang
` (2 subsequent siblings)
3 siblings, 1 reply; 7+ messages in thread
From: Yang Yingliang @ 2022-09-15 6:50 UTC (permalink / raw)
To: netdev; +Cc: andrew, hkallweit1, davem, kuba
dev_err() can be replace with dev_err_probe() which will check if error
code is -EPROBE_DEFER.
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
drivers/net/mdio/mdio-mux-mmioreg.c | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/net/mdio/mdio-mux-mmioreg.c b/drivers/net/mdio/mdio-mux-mmioreg.c
index c02fb2a067ee..c02c9c660016 100644
--- a/drivers/net/mdio/mdio-mux-mmioreg.c
+++ b/drivers/net/mdio/mdio-mux-mmioreg.c
@@ -159,12 +159,9 @@ static int mdio_mux_mmioreg_probe(struct platform_device *pdev)
ret = mdio_mux_init(&pdev->dev, pdev->dev.of_node,
mdio_mux_mmioreg_switch_fn,
&s->mux_handle, s, NULL);
- if (ret) {
- if (ret != -EPROBE_DEFER)
- dev_err(&pdev->dev,
- "failed to register mdio-mux bus %pOF\n", np);
- return ret;
- }
+ if (ret)
+ return dev_err_probe(&pdev->dev, ret,
+ "failed to register mdio-mux bus %pOF\n", np);
pdev->dev.platform_data = s;
--
2.25.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* [PATCH -next 3/3] net: mdio: mux-multiplexer: Switch to use dev_err_probe() helper
2022-09-15 6:50 [PATCH -next 1/3] net: mdio: mux-meson-g12a: Switch to use dev_err_probe() helper Yang Yingliang
2022-09-15 6:50 ` [PATCH -next 2/3] net: mdio: mux-mmioreg: " Yang Yingliang
@ 2022-09-15 6:50 ` Yang Yingliang
2022-09-15 12:35 ` Andrew Lunn
2022-09-15 12:34 ` [PATCH -next 1/3] net: mdio: mux-meson-g12a: " Andrew Lunn
2022-09-20 15:50 ` patchwork-bot+netdevbpf
3 siblings, 1 reply; 7+ messages in thread
From: Yang Yingliang @ 2022-09-15 6:50 UTC (permalink / raw)
To: netdev; +Cc: andrew, hkallweit1, davem, kuba
dev_err() can be replace with dev_err_probe() which will check if error
code is -EPROBE_DEFER.
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
drivers/net/mdio/mdio-mux-multiplexer.c | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/net/mdio/mdio-mux-multiplexer.c b/drivers/net/mdio/mdio-mux-multiplexer.c
index 527acfc3c045..bfa5af577b0a 100644
--- a/drivers/net/mdio/mdio-mux-multiplexer.c
+++ b/drivers/net/mdio/mdio-mux-multiplexer.c
@@ -72,12 +72,9 @@ static int mdio_mux_multiplexer_probe(struct platform_device *pdev)
return -ENOMEM;
s->muxc = devm_mux_control_get(dev, NULL);
- if (IS_ERR(s->muxc)) {
- ret = PTR_ERR(s->muxc);
- if (ret != -EPROBE_DEFER)
- dev_err(&pdev->dev, "Failed to get mux: %d\n", ret);
- return ret;
- }
+ if (IS_ERR(s->muxc))
+ return dev_err_probe(&pdev->dev, PTR_ERR(s->muxc),
+ "Failed to get mux\n");
platform_set_drvdata(pdev, s);
--
2.25.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH -next 1/3] net: mdio: mux-meson-g12a: Switch to use dev_err_probe() helper
2022-09-15 6:50 [PATCH -next 1/3] net: mdio: mux-meson-g12a: Switch to use dev_err_probe() helper Yang Yingliang
2022-09-15 6:50 ` [PATCH -next 2/3] net: mdio: mux-mmioreg: " Yang Yingliang
2022-09-15 6:50 ` [PATCH -next 3/3] net: mdio: mux-multiplexer: " Yang Yingliang
@ 2022-09-15 12:34 ` Andrew Lunn
2022-09-20 15:50 ` patchwork-bot+netdevbpf
3 siblings, 0 replies; 7+ messages in thread
From: Andrew Lunn @ 2022-09-15 12:34 UTC (permalink / raw)
To: Yang Yingliang; +Cc: netdev, hkallweit1, davem, kuba
On Thu, Sep 15, 2022 at 02:50:41PM +0800, Yang Yingliang wrote:
> dev_err() can be replace with dev_err_probe() which will check if error
> code is -EPROBE_DEFER.
>
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH -next 1/3] net: mdio: mux-meson-g12a: Switch to use dev_err_probe() helper
2022-09-15 6:50 [PATCH -next 1/3] net: mdio: mux-meson-g12a: Switch to use dev_err_probe() helper Yang Yingliang
` (2 preceding siblings ...)
2022-09-15 12:34 ` [PATCH -next 1/3] net: mdio: mux-meson-g12a: " Andrew Lunn
@ 2022-09-20 15:50 ` patchwork-bot+netdevbpf
3 siblings, 0 replies; 7+ messages in thread
From: patchwork-bot+netdevbpf @ 2022-09-20 15:50 UTC (permalink / raw)
To: Yang Yingliang; +Cc: netdev, andrew, hkallweit1, davem, kuba
Hello:
This series was applied to netdev/net-next.git (master)
by Jakub Kicinski <kuba@kernel.org>:
On Thu, 15 Sep 2022 14:50:41 +0800 you wrote:
> dev_err() can be replace with dev_err_probe() which will check if error
> code is -EPROBE_DEFER.
>
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> ---
> drivers/net/mdio/mdio-mux-meson-g12a.c | 20 +++++++-------------
> 1 file changed, 7 insertions(+), 13 deletions(-)
Here is the summary with links:
- [-next,1/3] net: mdio: mux-meson-g12a: Switch to use dev_err_probe() helper
https://git.kernel.org/netdev/net-next/c/de0665c871b7
- [-next,2/3] net: mdio: mux-mmioreg: Switch to use dev_err_probe() helper
https://git.kernel.org/netdev/net-next/c/770aac8dc05d
- [-next,3/3] net: mdio: mux-multiplexer: Switch to use dev_err_probe() helper
https://git.kernel.org/netdev/net-next/c/4633b39183c5
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2022-09-20 15:50 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-15 6:50 [PATCH -next 1/3] net: mdio: mux-meson-g12a: Switch to use dev_err_probe() helper Yang Yingliang
2022-09-15 6:50 ` [PATCH -next 2/3] net: mdio: mux-mmioreg: " Yang Yingliang
2022-09-15 12:34 ` Andrew Lunn
2022-09-15 6:50 ` [PATCH -next 3/3] net: mdio: mux-multiplexer: " Yang Yingliang
2022-09-15 12:35 ` Andrew Lunn
2022-09-15 12:34 ` [PATCH -next 1/3] net: mdio: mux-meson-g12a: " Andrew Lunn
2022-09-20 15:50 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).