netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* patch for iproute2
@ 2019-05-18  3:52 Martin Kealey
  2019-05-20  8:09 ` Hangbin Liu
  0 siblings, 1 reply; 2+ messages in thread
From: Martin Kealey @ 2019-05-18  3:52 UTC (permalink / raw)
  To: netdev


Hello iproute2 maintainer.

(Sorry, I don't know your name)

I recently noticed a discrepancy: the internal documentation for the ip
command says that an *RTT* value can be sufficed with "s" (second) or "ms"
(millisecond), but in practice no suffix of any kind is accepted.

I found that that commit 697ac63905cb5ca5389cd840462ee9868123b77f to
git://git.kernel.org/pub/scm/network/iproute2/iproute2.git caused this
regression; it was over-zealous in disallowing non-digits in *all* contexts
where a number is expected.

As far as I can tell, this does not have any kernel-related impact, merely
it affects what arguments are accepted by the "ip" command.

I have a suitable patch for fixing this; what is the procedure for
submitting it?

-Martin

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: patch for iproute2
  2019-05-18  3:52 patch for iproute2 Martin Kealey
@ 2019-05-20  8:09 ` Hangbin Liu
  0 siblings, 0 replies; 2+ messages in thread
From: Hangbin Liu @ 2019-05-20  8:09 UTC (permalink / raw)
  To: Martin Kealey; +Cc: netdev

On Sat, May 18, 2019 at 01:52:36PM +1000, Martin Kealey wrote:
> 
> Hello iproute2 maintainer.
> 
> (Sorry, I don't know your name)
> 
> I recently noticed a discrepancy: the internal documentation for the ip
> command says that an *RTT* value can be sufficed with "s" (second) or "ms"
> (millisecond), but in practice no suffix of any kind is accepted.
> 
> I found that that commit 697ac63905cb5ca5389cd840462ee9868123b77f to
> git://git.kernel.org/pub/scm/network/iproute2/iproute2.git caused this
> regression; it was over-zealous in disallowing non-digits in *all* contexts
> where a number is expected.
> 
> As far as I can tell, this does not have any kernel-related impact, merely
> it affects what arguments are accepted by the "ip" command.
> 
> I have a suitable patch for fixing this; what is the procedure for
> submitting it?

It's the same process with submitting patch to netdev[1]. If you are familiar
with git. Just format a patch and send it to detdev@. Be careful with the
subject prefix, Signed-off info and fixes tags.

[1] https://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git/tree/Documentation/networking/netdev-FAQ.rst#n257

Thanks
Hangbin

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-05-20  8:10 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-18  3:52 patch for iproute2 Martin Kealey
2019-05-20  8:09 ` Hangbin Liu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).