From: Joseph Gasparakis <joseph.gasparakis@intel.com>
To: Or Gerlitz <or.gerlitz@gmail.com>
Cc: Joseph Gasparakis <joseph.gasparakis@intel.com>,
Pravin Shelar <pshelar@nicira.com>,
Or Gerlitz <ogerlitz@mellanox.com>,
netdev <netdev@vger.kernel.org>
Subject: Re: issues with vxlan RX checksum offload under OVS datapath
Date: Tue, 21 Jan 2014 14:35:40 -0800 (PST) [thread overview]
Message-ID: <alpine.LFD.2.03.1401211410560.16080@intel.com> (raw)
In-Reply-To: <CAJZOPZKdSmuEQv6dcuLb8E8CqBuTvpywQXZypFTp+j3Xnw2E0w@mail.gmail.com>
On Tue, 21 Jan 2014, Or Gerlitz wrote:
> On Tue, Jan 21, 2014, Joseph Gasparakis <joseph.gasparakis@intel.com> wrote:
> > On Tue, 21 Jan 2014, Or Gerlitz wrote:
>
> >> To be a bit more precise/concrete here, do we agree that the both paths must >> skb->encapsulation = 0;
> >> which is done now only by the non-ovs path
>
> > Originally skb->encapsulation had (and still has) the meaning of "does
> > this skb have outer *and* (valid) inner headers? If so, it is an
> > encapsulated packet".
> > So based on this skb->encapsulation should be set as soon an (inner)
> > packet gets encapsulated and unset when decapsulation takes place, and
> > ideally this should happen in the ovs path too.
>
> I would say critically not ideally... e.g when the packet is
> destinat-ed to a VM and goes through tap netdevice plugged to OVS --
> without this de-assignment weird things happen after the point in time
> where the ovs TX path calls dev_queue_xmit() in
> net/openvswitch/vport-netdev.c
>
> > Together with skb->encapsulation the inner headers should be correctly set.
>
> That's interesting point, what might break if this isn't done?
Well, the inner headers, same as the generic (outer) headers are pointers
or offsets that are going to be added to the packet data pointer. If for
any reason we try to access these pointers when they are invalid anything
can go wrong... The way to indicate if they are valid or not should be
skb->encapsulation.
>
prev parent reply other threads:[~2014-01-21 22:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-19 22:05 issues with vxlan RX checksum offload under OVS datapath Or Gerlitz
2014-01-21 17:30 ` Pravin Shelar
2014-01-21 17:37 ` Jesse Gross
2014-01-21 20:55 ` Or Gerlitz
2014-01-21 21:47 ` Joseph Gasparakis
2014-01-21 21:43 ` Or Gerlitz
2014-01-21 22:35 ` Joseph Gasparakis [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.03.1401211410560.16080@intel.com \
--to=joseph.gasparakis@intel.com \
--cc=netdev@vger.kernel.org \
--cc=ogerlitz@mellanox.com \
--cc=or.gerlitz@gmail.com \
--cc=pshelar@nicira.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).