* [PATCHv2 net 0/2] ipv4: fix problems from the RTNH_F_LINKDOWN introduction @ 2015-10-26 21:59 Julian Anastasov 2015-10-26 21:59 ` [PATCHv2 net 1/2] ipv4: fix to not remove local route on link down Julian Anastasov 2015-10-26 21:59 ` [PATCHv2 net 2/2] ipv4: update RTNH_F_LINKDOWN flag on UP event Julian Anastasov 0 siblings, 2 replies; 8+ messages in thread From: Julian Anastasov @ 2015-10-26 21:59 UTC (permalink / raw) To: David Miller; +Cc: netdev, Andy Gospodarek Fix two problems from the change that introduced RTNH_F_LINKDOWN flag. The first patch deals with the removal of local route on DOWN event. The second patch makes sure the RTNH_F_LINKDOWN flag is properly updated on UP event because the DOWN event sets it in all cases. v1->v2: - forgot to add ifconfig dummy0 down in the test case - split to 2 patches Julian Anastasov (2): ipv4: fix to not remove local route on link down ipv4: update RTNH_F_LINKDOWN flag on UP event include/net/ip_fib.h | 2 +- net/ipv4/fib_frontend.c | 13 +++++++------ net/ipv4/fib_semantics.c | 18 +++++++++++++++--- 3 files changed, 23 insertions(+), 10 deletions(-) -- 1.9.3 ^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCHv2 net 1/2] ipv4: fix to not remove local route on link down 2015-10-26 21:59 [PATCHv2 net 0/2] ipv4: fix problems from the RTNH_F_LINKDOWN introduction Julian Anastasov @ 2015-10-26 21:59 ` Julian Anastasov 2015-10-30 3:18 ` David Miller 2015-10-26 21:59 ` [PATCHv2 net 2/2] ipv4: update RTNH_F_LINKDOWN flag on UP event Julian Anastasov 1 sibling, 1 reply; 8+ messages in thread From: Julian Anastasov @ 2015-10-26 21:59 UTC (permalink / raw) To: David Miller; +Cc: netdev, Andy Gospodarek When fib_netdev_event calls fib_disable_ip on NETDEV_DOWN event we should not delete the local routes if the local address is still present. The confusion comes from the fact that both fib_netdev_event and fib_inetaddr_event use the NETDEV_DOWN constant. Fix it by returning back the variable 'force'. Steps to reproduce: modprobe dummy ifconfig dummy0 192.168.168.1 up ifconfig dummy0 down ip route list table local | grep dummy | grep host local 192.168.168.1 dev dummy0 proto kernel scope host src 192.168.168.1 Fixes: 8a3d03166f19 ("net: track link-status of ipv4 nexthops") Signed-off-by: Julian Anastasov <ja@ssi.bg> --- include/net/ip_fib.h | 2 +- net/ipv4/fib_frontend.c | 13 +++++++------ net/ipv4/fib_semantics.c | 11 ++++++++--- 3 files changed, 16 insertions(+), 10 deletions(-) diff --git a/include/net/ip_fib.h b/include/net/ip_fib.h index 727d6e9..654aec1 100644 --- a/include/net/ip_fib.h +++ b/include/net/ip_fib.h @@ -317,7 +317,7 @@ void fib_flush_external(struct net *net); /* Exported by fib_semantics.c */ int ip_fib_check_default(__be32 gw, struct net_device *dev); -int fib_sync_down_dev(struct net_device *dev, unsigned long event); +int fib_sync_down_dev(struct net_device *dev, unsigned long event, int force); int fib_sync_down_addr(struct net *net, __be32 local); int fib_sync_up(struct net_device *dev, unsigned int nh_flags); void fib_select_multipath(struct fib_result *res); diff --git a/net/ipv4/fib_frontend.c b/net/ipv4/fib_frontend.c index 690bcbc..4826a22 100644 --- a/net/ipv4/fib_frontend.c +++ b/net/ipv4/fib_frontend.c @@ -1110,9 +1110,10 @@ static void nl_fib_lookup_exit(struct net *net) net->ipv4.fibnl = NULL; } -static void fib_disable_ip(struct net_device *dev, unsigned long event) +static void fib_disable_ip(struct net_device *dev, unsigned long event, + int force) { - if (fib_sync_down_dev(dev, event)) + if (fib_sync_down_dev(dev, event, force)) fib_flush(dev_net(dev)); rt_cache_flush(dev_net(dev)); arp_ifdown(dev); @@ -1140,7 +1141,7 @@ static int fib_inetaddr_event(struct notifier_block *this, unsigned long event, /* Last address was deleted from this interface. * Disable IP. */ - fib_disable_ip(dev, event); + fib_disable_ip(dev, event, 1); } else { rt_cache_flush(dev_net(dev)); } @@ -1157,7 +1158,7 @@ static int fib_netdev_event(struct notifier_block *this, unsigned long event, vo unsigned int flags; if (event == NETDEV_UNREGISTER) { - fib_disable_ip(dev, event); + fib_disable_ip(dev, event, 2); rt_flush_dev(dev); return NOTIFY_DONE; } @@ -1178,14 +1179,14 @@ static int fib_netdev_event(struct notifier_block *this, unsigned long event, vo rt_cache_flush(net); break; case NETDEV_DOWN: - fib_disable_ip(dev, event); + fib_disable_ip(dev, event, 0); break; case NETDEV_CHANGE: flags = dev_get_flags(dev); if (flags & (IFF_RUNNING | IFF_LOWER_UP)) fib_sync_up(dev, RTNH_F_LINKDOWN); else - fib_sync_down_dev(dev, event); + fib_sync_down_dev(dev, event, 0); /* fall through */ case NETDEV_CHANGEMTU: rt_cache_flush(net); diff --git a/net/ipv4/fib_semantics.c b/net/ipv4/fib_semantics.c index 064bd3c..f493eff 100644 --- a/net/ipv4/fib_semantics.c +++ b/net/ipv4/fib_semantics.c @@ -1281,7 +1281,13 @@ int fib_sync_down_addr(struct net *net, __be32 local) return ret; } -int fib_sync_down_dev(struct net_device *dev, unsigned long event) +/* Event force Flags Description + * NETDEV_CHANGE 0 LINKDOWN Carrier OFF, not for scope host + * NETDEV_DOWN 0 LINKDOWN|DEAD Link down, not for scope host + * NETDEV_DOWN 1 LINKDOWN|DEAD Last address removed + * NETDEV_UNREGISTER 2 LINKDOWN|DEAD Device removed + */ +int fib_sync_down_dev(struct net_device *dev, unsigned long event, int force) { int ret = 0; int scope = RT_SCOPE_NOWHERE; @@ -1290,8 +1296,7 @@ int fib_sync_down_dev(struct net_device *dev, unsigned long event) struct hlist_head *head = &fib_info_devhash[hash]; struct fib_nh *nh; - if (event == NETDEV_UNREGISTER || - event == NETDEV_DOWN) + if (force) scope = -1; hlist_for_each_entry(nh, head, nh_hash) { -- 1.9.3 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCHv2 net 1/2] ipv4: fix to not remove local route on link down 2015-10-26 21:59 ` [PATCHv2 net 1/2] ipv4: fix to not remove local route on link down Julian Anastasov @ 2015-10-30 3:18 ` David Miller 0 siblings, 0 replies; 8+ messages in thread From: David Miller @ 2015-10-30 3:18 UTC (permalink / raw) To: ja; +Cc: netdev, gospo From: Julian Anastasov <ja@ssi.bg> Date: Mon, 26 Oct 2015 23:59:12 +0200 ... > -int fib_sync_down_dev(struct net_device *dev, unsigned long event) > +/* Event force Flags Description > + * NETDEV_CHANGE 0 LINKDOWN Carrier OFF, not for scope host > + * NETDEV_DOWN 0 LINKDOWN|DEAD Link down, not for scope host > + * NETDEV_DOWN 1 LINKDOWN|DEAD Last address removed > + * NETDEV_UNREGISTER 2 LINKDOWN|DEAD Device removed > + */ > +int fib_sync_down_dev(struct net_device *dev, unsigned long event, int force) > { > int ret = 0; > int scope = RT_SCOPE_NOWHERE; > @@ -1290,8 +1296,7 @@ int fib_sync_down_dev(struct net_device *dev, unsigned long event) > struct hlist_head *head = &fib_info_devhash[hash]; > struct fib_nh *nh; > > - if (event == NETDEV_UNREGISTER || > - event == NETDEV_DOWN) > + if (force) > scope = -1; Julian the force variable is only used in a boolean manner, and in fact 'event' + a boolean is enough to distinguish all of the necessary cases so really using a non-bool for 'force' does not convey any extra information. So please use 'bool' and 'true/false' for 'force'. Thanks. ^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCHv2 net 2/2] ipv4: update RTNH_F_LINKDOWN flag on UP event 2015-10-26 21:59 [PATCHv2 net 0/2] ipv4: fix problems from the RTNH_F_LINKDOWN introduction Julian Anastasov 2015-10-26 21:59 ` [PATCHv2 net 1/2] ipv4: fix to not remove local route on link down Julian Anastasov @ 2015-10-26 21:59 ` Julian Anastasov 2015-10-27 4:52 ` Andy Gospodarek 1 sibling, 1 reply; 8+ messages in thread From: Julian Anastasov @ 2015-10-26 21:59 UTC (permalink / raw) To: David Miller; +Cc: netdev, Andy Gospodarek When nexthop is part of multipath route we should clear the LINKDOWN flag when link goes UP or when first address is added. This is needed because we always set LINKDOWN flag when DEAD flag was set but now on UP the nexthop is not dead anymore. Examples when LINKDOWN bit can be forgotten when no NETDEV_CHANGE is delivered: - link goes down (LINKDOWN is set), then link goes UP and device shows carrier OK but LINKDOWN remains set - last address is deleted (LINKDOWN is set), then address is added and device shows carrier OK but LINKDOWN remains set Steps to reproduce: modprobe dummy ifconfig dummy0 192.168.168.1 up here add a multipath route where one nexthop is for dummy0: ip route add 1.2.3.4 nexthop dummy0 nexthop SOME_OTHER_DEVICE ifconfig dummy0 down ifconfig dummy0 up now ip route shows nexthop that is not dead. Now set the sysctl var: echo 1 > /proc/sys/net/ipv4/conf/dummy0/ignore_routes_with_linkdown now ip route will show a dead nexthop because the forgotten RTNH_F_LINKDOWN is propagated as RTNH_F_DEAD. Fixes: 8a3d03166f19 ("net: track link-status of ipv4 nexthops") Signed-off-by: Julian Anastasov <ja@ssi.bg> --- net/ipv4/fib_semantics.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/net/ipv4/fib_semantics.c b/net/ipv4/fib_semantics.c index f493eff..f657418 100644 --- a/net/ipv4/fib_semantics.c +++ b/net/ipv4/fib_semantics.c @@ -1445,6 +1445,13 @@ int fib_sync_up(struct net_device *dev, unsigned int nh_flags) if (!(dev->flags & IFF_UP)) return 0; + if (nh_flags & RTNH_F_DEAD) { + unsigned int flags = dev_get_flags(dev); + + if (flags & (IFF_RUNNING | IFF_LOWER_UP)) + nh_flags |= RTNH_F_LINKDOWN; + } + prev_fi = NULL; hash = fib_devindex_hashfn(dev->ifindex); head = &fib_info_devhash[hash]; -- 1.9.3 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCHv2 net 2/2] ipv4: update RTNH_F_LINKDOWN flag on UP event 2015-10-26 21:59 ` [PATCHv2 net 2/2] ipv4: update RTNH_F_LINKDOWN flag on UP event Julian Anastasov @ 2015-10-27 4:52 ` Andy Gospodarek 2015-10-27 7:42 ` Julian Anastasov 0 siblings, 1 reply; 8+ messages in thread From: Andy Gospodarek @ 2015-10-27 4:52 UTC (permalink / raw) To: Julian Anastasov; +Cc: David Miller, netdev On Mon, Oct 26, 2015 at 11:59:13PM +0200, Julian Anastasov wrote: > When nexthop is part of multipath route we should clear the > LINKDOWN flag when link goes UP or when first address is added. > This is needed because we always set LINKDOWN flag when DEAD flag > was set but now on UP the nexthop is not dead anymore. Examples when > LINKDOWN bit can be forgotten when no NETDEV_CHANGE is delivered: > > - link goes down (LINKDOWN is set), then link goes UP and device > shows carrier OK but LINKDOWN remains set > > - last address is deleted (LINKDOWN is set), then address is > added and device shows carrier OK but LINKDOWN remains set > > Steps to reproduce: > modprobe dummy > ifconfig dummy0 192.168.168.1 up > > here add a multipath route where one nexthop is for dummy0: > > ip route add 1.2.3.4 nexthop dummy0 nexthop SOME_OTHER_DEVICE > ifconfig dummy0 down > ifconfig dummy0 up > > now ip route shows nexthop that is not dead. Now set the sysctl var: > > echo 1 > /proc/sys/net/ipv4/conf/dummy0/ignore_routes_with_linkdown > > now ip route will show a dead nexthop because the forgotten > RTNH_F_LINKDOWN is propagated as RTNH_F_DEAD. I tested this patch and I now see that your reported problem is a result of dummy never taking carrier down. There was a presumption that carrier notification would go down when hardware went down (or when the logical device backing the hardware went down, but this is clearly not always the case. > Fixes: 8a3d03166f19 ("net: track link-status of ipv4 nexthops") > Signed-off-by: Julian Anastasov <ja@ssi.bg> > --- > net/ipv4/fib_semantics.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/net/ipv4/fib_semantics.c b/net/ipv4/fib_semantics.c > index f493eff..f657418 100644 > --- a/net/ipv4/fib_semantics.c > +++ b/net/ipv4/fib_semantics.c > @@ -1445,6 +1445,13 @@ int fib_sync_up(struct net_device *dev, unsigned int nh_flags) > if (!(dev->flags & IFF_UP)) > return 0; > > + if (nh_flags & RTNH_F_DEAD) { > + unsigned int flags = dev_get_flags(dev); > + > + if (flags & (IFF_RUNNING | IFF_LOWER_UP)) > + nh_flags |= RTNH_F_LINKDOWN; > + } > + > prev_fi = NULL; > hash = fib_devindex_hashfn(dev->ifindex); > head = &fib_info_devhash[hash]; Logically this patch makes sense, but I feel as though there may be a slightly better option. Possibly this: diff --git a/net/ipv4/fib_semantics.c b/net/ipv4/fib_semantics.c index 42778d9..7eb7c40 100644 --- a/net/ipv4/fib_semantics.c +++ b/net/ipv4/fib_semantics.c @@ -1376,7 +1376,8 @@ int fib_sync_down_dev(struct net_device *dev, unsigned long event) nexthop_nh->nh_flags |= RTNH_F_DEAD; /* fall through */ case NETDEV_CHANGE: - nexthop_nh->nh_flags |= RTNH_F_LINKDOWN; + if (!netif_carrier_ok(dev)) + nexthop_nh->nh_flags |= RTNH_F_LINKDOWN; break; } dead++; @@ -1396,7 +1397,8 @@ int fib_sync_down_dev(struct net_device *dev, unsigned long event) fi->fib_flags |= RTNH_F_DEAD; /* fall through */ case NETDEV_CHANGE: - fi->fib_flags |= RTNH_F_LINKDOWN; + if (!netif_carrier_ok(dev)) + fi->fib_flags |= RTNH_F_LINKDOWN; break; } ret++; ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCHv2 net 2/2] ipv4: update RTNH_F_LINKDOWN flag on UP event 2015-10-27 4:52 ` Andy Gospodarek @ 2015-10-27 7:42 ` Julian Anastasov 2015-10-27 18:37 ` Andy Gospodarek 0 siblings, 1 reply; 8+ messages in thread From: Julian Anastasov @ 2015-10-27 7:42 UTC (permalink / raw) To: Andy Gospodarek; +Cc: David Miller, netdev Hello, On Tue, 27 Oct 2015, Andy Gospodarek wrote: > I tested this patch and I now see that your reported problem is a result > of dummy never taking carrier down. There was a presumption that > carrier notification would go down when hardware went down (or when the > logical device backing the hardware went down, but this is clearly not > always the case. It seems not all devices play with the carrier after IFF_UP is set and we can not rely on NETDEV_CHANGE to update the flag. > > + if (nh_flags & RTNH_F_DEAD) { > > + unsigned int flags = dev_get_flags(dev); > > + > > + if (flags & (IFF_RUNNING | IFF_LOWER_UP)) > > + nh_flags |= RTNH_F_LINKDOWN; > > + } > > + > > prev_fi = NULL; > > hash = fib_devindex_hashfn(dev->ifindex); > > head = &fib_info_devhash[hash]; > > Logically this patch makes sense, but I feel as though there may be a > slightly better option. Possibly this: > > diff --git a/net/ipv4/fib_semantics.c b/net/ipv4/fib_semantics.c > index 42778d9..7eb7c40 100644 > --- a/net/ipv4/fib_semantics.c > +++ b/net/ipv4/fib_semantics.c > @@ -1376,7 +1376,8 @@ int fib_sync_down_dev(struct net_device *dev, unsigned long event) > nexthop_nh->nh_flags |= RTNH_F_DEAD; > /* fall through */ > case NETDEV_CHANGE: > - nexthop_nh->nh_flags |= RTNH_F_LINKDOWN; > + if (!netif_carrier_ok(dev)) > + nexthop_nh->nh_flags |= RTNH_F_LINKDOWN; There is a problem with this approach. Once the RTNH_F_DEAD flag is set, eg. when last address is removed, any NETDEV_CHANGE events are ignored in this function. As result, we may miss the link-down event if we first remove the addresses, so we will not set RTNH_F_LINKDOWN. Also, when device link goes UP we (FIB) can not guess just based on events what is the actual carrier state because the NETDEV_CHANGE notification comes only when IFF_UP is set. So, this check. I also attempted to fully recalculate the flag in fib_sync_up, i.e. with the option not just to clear it but also to add nexthop_nh->nh_flags |= nh_flags_set logic but it complicates the code. So, while we always set RTNH_F_LINKDOWN when DEAD is set, the logic to conditionally clear RTNH_F_LINKDOWN in fib_sync_up looks the cheapest one. Of course, we have a semantic problem when setting RTNH_F_LINKDOWN on last address removal, i.e. this event has nothing to do with the link state. But it works because RTNH_F_LINKDOWN is valid for lookups only when DEAD flag is not set, so that is why my patch looks this way. > break; > } > dead++; > @@ -1396,7 +1397,8 @@ int fib_sync_down_dev(struct net_device *dev, unsigned long event) > fi->fib_flags |= RTNH_F_DEAD; > /* fall through */ > case NETDEV_CHANGE: > - fi->fib_flags |= RTNH_F_LINKDOWN; > + if (!netif_carrier_ok(dev)) > + fi->fib_flags |= RTNH_F_LINKDOWN; > break; > } > ret++; I think, we even do not need the RTNH_F_LINKDOWN flag in fib_flags, currently it is set but never used. Regards -- Julian Anastasov <ja@ssi.bg> ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCHv2 net 2/2] ipv4: update RTNH_F_LINKDOWN flag on UP event 2015-10-27 7:42 ` Julian Anastasov @ 2015-10-27 18:37 ` Andy Gospodarek 2015-10-29 20:15 ` Julian Anastasov 0 siblings, 1 reply; 8+ messages in thread From: Andy Gospodarek @ 2015-10-27 18:37 UTC (permalink / raw) To: Julian Anastasov; +Cc: David Miller, netdev On Tue, Oct 27, 2015 at 09:42:25AM +0200, Julian Anastasov wrote: > > Hello, > > On Tue, 27 Oct 2015, Andy Gospodarek wrote: > > > I tested this patch and I now see that your reported problem is a result > > of dummy never taking carrier down. There was a presumption that > > carrier notification would go down when hardware went down (or when the > > logical device backing the hardware went down, but this is clearly not > > always the case. > > It seems not all devices play with the carrier > after IFF_UP is set and we can not rely on NETDEV_CHANGE > to update the flag. Agreed. > > > > + if (nh_flags & RTNH_F_DEAD) { > > > + unsigned int flags = dev_get_flags(dev); > > > + > > > + if (flags & (IFF_RUNNING | IFF_LOWER_UP)) > > > + nh_flags |= RTNH_F_LINKDOWN; > > > + } > > > + > > > prev_fi = NULL; > > > hash = fib_devindex_hashfn(dev->ifindex); > > > head = &fib_info_devhash[hash]; > > > > Logically this patch makes sense, but I feel as though there may be a > > slightly better option. Possibly this: > > > > diff --git a/net/ipv4/fib_semantics.c b/net/ipv4/fib_semantics.c > > index 42778d9..7eb7c40 100644 > > --- a/net/ipv4/fib_semantics.c > > +++ b/net/ipv4/fib_semantics.c > > @@ -1376,7 +1376,8 @@ int fib_sync_down_dev(struct net_device *dev, unsigned long event) > > nexthop_nh->nh_flags |= RTNH_F_DEAD; > > /* fall through */ > > case NETDEV_CHANGE: > > - nexthop_nh->nh_flags |= RTNH_F_LINKDOWN; > > + if (!netif_carrier_ok(dev)) > > + nexthop_nh->nh_flags |= RTNH_F_LINKDOWN; > > There is a problem with this approach. Once > the RTNH_F_DEAD flag is set, eg. when last address is removed, > any NETDEV_CHANGE events are ignored in this function. > As result, we may miss the link-down event if we first > remove the addresses, so we will not set RTNH_F_LINKDOWN. Yes, I see that now. I verified with dummy by setting carrier after a flush. Thanks for pointing that out. > Also, when device link goes UP we (FIB) can not guess > just based on events what is the actual carrier state > because the NETDEV_CHANGE notification comes only when > IFF_UP is set. So, this check. > > I also attempted to fully recalculate the flag > in fib_sync_up, i.e. with the option not just to clear it > but also to add nexthop_nh->nh_flags |= nh_flags_set logic > but it complicates the code. So, while we always set > RTNH_F_LINKDOWN when DEAD is set, the logic to conditionally > clear RTNH_F_LINKDOWN in fib_sync_up looks the cheapest one. > > Of course, we have a semantic problem when setting > RTNH_F_LINKDOWN on last address removal, i.e. this event > has nothing to do with the link state. But it works because > RTNH_F_LINKDOWN is valid for lookups only when DEAD flag > is not set, so that is why my patch looks this way. The problem you describe here was a concern of mine as well. I would really like the output of 'ip route show' to properly reflect the link state and fix the problem you describe, but it seems like it will not in this case with your current patch. I'll do a bit more testing and let you know. > > > break; > > } > > dead++; > > @@ -1396,7 +1397,8 @@ int fib_sync_down_dev(struct net_device *dev, unsigned long event) > > fi->fib_flags |= RTNH_F_DEAD; > > /* fall through */ > > case NETDEV_CHANGE: > > - fi->fib_flags |= RTNH_F_LINKDOWN; > > + if (!netif_carrier_ok(dev)) > > + fi->fib_flags |= RTNH_F_LINKDOWN; > > break; > > } > > ret++; > > I think, we even do not need the RTNH_F_LINKDOWN flag > in fib_flags, currently it is set but never used. > > Regards > > -- > Julian Anastasov <ja@ssi.bg> ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCHv2 net 2/2] ipv4: update RTNH_F_LINKDOWN flag on UP event 2015-10-27 18:37 ` Andy Gospodarek @ 2015-10-29 20:15 ` Julian Anastasov 0 siblings, 0 replies; 8+ messages in thread From: Julian Anastasov @ 2015-10-29 20:15 UTC (permalink / raw) To: Andy Gospodarek; +Cc: David Miller, netdev Hello, On Tue, 27 Oct 2015, Andy Gospodarek wrote: > > Of course, we have a semantic problem when setting > > RTNH_F_LINKDOWN on last address removal, i.e. this event > > has nothing to do with the link state. But it works because > > RTNH_F_LINKDOWN is valid for lookups only when DEAD flag > > is not set, so that is why my patch looks this way. > The problem you describe here was a concern of mine as well. I would > really like the output of 'ip route show' to properly reflect the link > state and fix the problem you describe, but it seems like it will not in > this case with your current patch. I'll do a bit more testing and let > you know. Another option is to remove the RTNH_F_LINKDOWN usage from any event, from FIB structs. In case only netif_carrier_ok check is needed, it looks cheap to just call it after the IN_DEV_IGNORE_ROUTES_WITH_LINKDOWN check. When showing it to user space we can again use netif_carrier_ok. The new fib_rebalance() is special, it still needs to be called, just like now on NETDEV_CHANGE event but only when ignore_routes_with_linkdown=1, i.e. we can avoid calling fib_sync_up/fib_sync_down_dev in fib_netdev_event if the flag is not set, guarded by CONFIG_IP_ROUTE_MULTIPATH check. To make this work we can also call somehow fib_rebalance() from devinet_conf_proc() context when the flag is changed, all this is for the CONFIG_IP_ROUTE_MULTIPATH case. Regards -- Julian Anastasov <ja@ssi.bg> ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2015-10-30 3:18 UTC | newest] Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2015-10-26 21:59 [PATCHv2 net 0/2] ipv4: fix problems from the RTNH_F_LINKDOWN introduction Julian Anastasov 2015-10-26 21:59 ` [PATCHv2 net 1/2] ipv4: fix to not remove local route on link down Julian Anastasov 2015-10-30 3:18 ` David Miller 2015-10-26 21:59 ` [PATCHv2 net 2/2] ipv4: update RTNH_F_LINKDOWN flag on UP event Julian Anastasov 2015-10-27 4:52 ` Andy Gospodarek 2015-10-27 7:42 ` Julian Anastasov 2015-10-27 18:37 ` Andy Gospodarek 2015-10-29 20:15 ` Julian Anastasov
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).