From: Marek Vasut <marex@denx.de>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, andrew@lunn.ch, f.fainelli@gmail.com,
george.mccollister@gmail.com, Tristram.Ha@microchip.com,
vivien.didelot@savoirfairelinux.com, woojung.huh@microchip.com
Subject: Re: [PATCH] net: dsa: microchip: Always set regmap stride to 1
Date: Thu, 26 Sep 2019 00:09:06 +0200 [thread overview]
Message-ID: <b1d256eb-85d0-4bdc-e49a-1ec00d2a2cb7@denx.de> (raw)
In-Reply-To: <20190925.134424.1566106400449419934.davem@davemloft.net>
On 9/25/19 1:44 PM, David Miller wrote:
> From: Marek Vasut <marex@denx.de>
> Date: Sat, 21 Sep 2019 19:53:09 +0200
>
>> The regmap stride is set to 1 for regmap describing 8bit registers already.
>> However, for 16/32/64bit registers, the stride is 2/4/8 respectively. This
>> is not correct, as the switch protocol supports unaligned register reads
>> and writes and the KSZ87xx even uses such unaligned register accesses to
>> read e.g. MIB counter.
>>
>> This patch fixes MIB counter access on KSZ87xx.
>>
>> Signed-off-by: Marek Vasut <marex@denx.de>
>
> Please resubmit with an appropriate Fixes: tag as per Florian's feedback.
Done
prev parent reply other threads:[~2019-09-25 22:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-21 17:53 [PATCH] net: dsa: microchip: Always set regmap stride to 1 Marek Vasut
2019-09-22 17:58 ` Florian Fainelli
2019-09-25 11:44 ` David Miller
2019-09-25 22:09 ` Marek Vasut [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b1d256eb-85d0-4bdc-e49a-1ec00d2a2cb7@denx.de \
--to=marex@denx.de \
--cc=Tristram.Ha@microchip.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=george.mccollister@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@savoirfairelinux.com \
--cc=woojung.huh@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).