From: Jamal Hadi Salim <jhs@mojatatu.com>
To: Victor Nogueira <victor@mojatatu.com>,
Baowen Zheng <baowen.zheng@corigine.com>
Cc: David Ahern <dsahern@gmail.com>,
netdev@vger.kernel.org, oss-drivers@corigine.com,
Simon Horman <simon.horman@corigine.com>
Subject: Re: [PATCH iproute2-next v2] tc: add skip_hw and skip_sw to control action offload
Date: Mon, 31 Jan 2022 14:40:43 -0500 [thread overview]
Message-ID: <b24054ae-7267-b5ca-363b-9c219fb05a98@mojatatu.com> (raw)
In-Reply-To: <CA+NMeC_RKJXwbpjejTXKViUzUjDi0N-ZKoSa9fun=ySfThV5gA@mail.gmail.com>
On 2022-01-26 08:41, Victor Nogueira wrote:
> On Wed, Jan 26, 2022 at 3:55 AM Baowen Zheng <baowen.zheng@corigine.com> wrote:
>>
>> Add skip_hw and skip_sw flags for user to control whether
>> offload action to hardware.
>>
>> Also we add hw_count to show how many hardwares accept to offload
>> the action.
>>
>> Change man page to describe the usage of skip_sw and skip_hw flag.
>>
>> An example to add and query action as below.
>>
>> $ tc actions add action police rate 1mbit burst 100k index 100 skip_sw
>>
>> $ tc -s -d actions list action police
>> total acts 1
>> action order 0: police 0x64 rate 1Mbit burst 100Kb mtu 2Kb action reclassify overhead 0b linklayer ethernet
>> ref 1 bind 0 installed 2 sec used 2 sec
>> Action statistics:
>> Sent 0 bytes 0 pkt (dropped 0, overlimits 0 requeues 0)
>> backlog 0b 0p requeues 0
>> skip_sw in_hw in_hw_count 1
>> used_hw_stats delayed
>>
>> Signed-off-by: baowen zheng <baowen.zheng@corigine.com>
>> Signed-off-by: Simon Horman <simon.horman@corigine.com>
>
> I applied this version, tested it and can confirm the breakage in tdc is gone.
> Tested-by: Victor Nogueira <victor@mojatatu.com>
Acked-by: Jamal Hadi Salim <jhs@mojatatu.com>
cheers,
jamal
next prev parent reply other threads:[~2022-01-31 19:40 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-26 6:54 [PATCH iproute2-next v2] tc: add skip_hw and skip_sw to control action offload Baowen Zheng
2022-01-26 13:41 ` Victor Nogueira
2022-01-31 19:40 ` Jamal Hadi Salim [this message]
2022-02-02 8:39 ` Roi Dayan
2022-02-02 8:46 ` Roi Dayan
2022-02-02 9:37 ` Baowen Zheng
2022-02-02 11:15 ` Roi Dayan
2022-02-02 11:47 ` Jamal Hadi Salim
2022-02-11 10:01 ` Baowen Zheng
2022-02-16 12:51 ` Jamal Hadi Salim
2022-02-16 14:18 ` Roi Dayan
2022-02-17 1:51 ` Baowen Zheng
2022-02-01 3:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b24054ae-7267-b5ca-363b-9c219fb05a98@mojatatu.com \
--to=jhs@mojatatu.com \
--cc=baowen.zheng@corigine.com \
--cc=dsahern@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=oss-drivers@corigine.com \
--cc=simon.horman@corigine.com \
--cc=victor@mojatatu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).