From: Roi Dayan <roid@nvidia.com>
To: Jamal Hadi Salim <jhs@mojatatu.com>,
Victor Nogueira <victor@mojatatu.com>,
Baowen Zheng <baowen.zheng@corigine.com>
Cc: David Ahern <dsahern@gmail.com>, <netdev@vger.kernel.org>,
<oss-drivers@corigine.com>,
Simon Horman <simon.horman@corigine.com>
Subject: Re: [PATCH iproute2-next v2] tc: add skip_hw and skip_sw to control action offload
Date: Wed, 2 Feb 2022 10:46:47 +0200 [thread overview]
Message-ID: <caeac129-25f4-6be5-76ce-9e0b20b68e7c@nvidia.com> (raw)
In-Reply-To: <1861edc9-7185-42f6-70dc-bfbfdd348462@nvidia.com>
On 2022-02-02 10:39 AM, Roi Dayan wrote:
>
>
> On 2022-01-31 9:40 PM, Jamal Hadi Salim wrote:
>> On 2022-01-26 08:41, Victor Nogueira wrote:
>>> On Wed, Jan 26, 2022 at 3:55 AM Baowen Zheng
>>> <baowen.zheng@corigine.com> wrote:
>>>>
>>>> Add skip_hw and skip_sw flags for user to control whether
>>>> offload action to hardware.
>>>>
>>>> Also we add hw_count to show how many hardwares accept to offload
>>>> the action.
>>>>
>>>> Change man page to describe the usage of skip_sw and skip_hw flag.
>>>>
>>>> An example to add and query action as below.
>>>>
>>>> $ tc actions add action police rate 1mbit burst 100k index 100 skip_sw
>>>>
>>>> $ tc -s -d actions list action police
>>>> total acts 1
>>>> action order 0: police 0x64 rate 1Mbit burst 100Kb mtu 2Kb
>>>> action reclassify overhead 0b linklayer ethernet
>>>> ref 1 bind 0 installed 2 sec used 2 sec
>>>> Action statistics:
>>>> Sent 0 bytes 0 pkt (dropped 0, overlimits 0 requeues 0)
>>>> backlog 0b 0p requeues 0
>>>> skip_sw in_hw in_hw_count 1
>>>> used_hw_stats delayed
>>>>
>>>> Signed-off-by: baowen zheng <baowen.zheng@corigine.com>
>>>> Signed-off-by: Simon Horman <simon.horman@corigine.com>
>>>
>>> I applied this version, tested it and can confirm the breakage in tdc
>>> is gone.
>>> Tested-by: Victor Nogueira <victor@mojatatu.com>
>>
>> Acked-by: Jamal Hadi Salim <jhs@mojatatu.com>
>>
>> cheers,
>> jamal
>
>
> Hi Sorry for not catching this early enough but I see an issue now with
> this patch. adding an offload tc rule and dumping it shows actions
> not_in_hw.
>
> example rule in_hw and action marked as not_in_hw
>
> filter parent ffff: protocol arp pref 8 flower chain 0 handle 0x1
> dst_mac e4:11:22:11:4a:51
> src_mac e4:11:22:11:4a:50
> eth_type arp
> in_hw in_hw_count 1
> action order 1: gact action drop
> random type none pass val 0
> index 2 ref 1 bind 1
> not_in_hw
> used_hw_stats delayed
>
>
> so the action was not created/offloaded outside the filter
> but it is acting as offloaded.
>
> also shouldn't the indent be more 1 space in like random/index to
> note it's part of the action order 1.
>
> Thanks,
> Roi
>
also, not tested. what is printed if match is not supported but uses
offloaded action?
it could print filter not_in_hw but action in_hw?
next prev parent reply other threads:[~2022-02-02 8:46 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-26 6:54 [PATCH iproute2-next v2] tc: add skip_hw and skip_sw to control action offload Baowen Zheng
2022-01-26 13:41 ` Victor Nogueira
2022-01-31 19:40 ` Jamal Hadi Salim
2022-02-02 8:39 ` Roi Dayan
2022-02-02 8:46 ` Roi Dayan [this message]
2022-02-02 9:37 ` Baowen Zheng
2022-02-02 11:15 ` Roi Dayan
2022-02-02 11:47 ` Jamal Hadi Salim
2022-02-11 10:01 ` Baowen Zheng
2022-02-16 12:51 ` Jamal Hadi Salim
2022-02-16 14:18 ` Roi Dayan
2022-02-17 1:51 ` Baowen Zheng
2022-02-01 3:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=caeac129-25f4-6be5-76ce-9e0b20b68e7c@nvidia.com \
--to=roid@nvidia.com \
--cc=baowen.zheng@corigine.com \
--cc=dsahern@gmail.com \
--cc=jhs@mojatatu.com \
--cc=netdev@vger.kernel.org \
--cc=oss-drivers@corigine.com \
--cc=simon.horman@corigine.com \
--cc=victor@mojatatu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).