netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Ahern <dsahern@gmail.com>
To: Donald Sharp <sharpd@cumulusnetworks.com>,
	netdev@vger.kernel.org, dsahern@kernel.org,
	roopa@cumulusnetworks.com, sworley@cumulusnetworks.com
Subject: Re: [PATCH] ip link: Prevent duplication of table id for vrf tables
Date: Sun, 8 Mar 2020 20:22:05 -0600	[thread overview]
Message-ID: <b36df09f-2e15-063e-4b58-1b864bed8751@gmail.com> (raw)
In-Reply-To: <20200307205916.15646-1-sharpd@cumulusnetworks.com>

On 3/7/20 1:59 PM, Donald Sharp wrote:
> Creation of different vrf's with duplicate table id's creates
> a situation where two different routing entities believe
> they have exclusive access to a particular table.  This
> leads to situations where different routing processes
> clash for control of a route due to inadvertent table
> id overlap.  Prevent end user from making this mistake
> on accident.

I get the pain, but it is a user management problem and ip is but one
tool. I think at most ip warns the user about the table duplication; it
can't fail the create.

  reply	other threads:[~2020-03-09  2:22 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-07 20:59 [PATCH] ip link: Prevent duplication of table id for vrf tables Donald Sharp
2020-03-09  2:22 ` David Ahern [this message]
2020-03-09 12:16   ` Donald Sharp
2020-03-10 23:33     ` David Ahern
2020-03-09 14:04   ` Ben Greear

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b36df09f-2e15-063e-4b58-1b864bed8751@gmail.com \
    --to=dsahern@gmail.com \
    --cc=dsahern@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=roopa@cumulusnetworks.com \
    --cc=sharpd@cumulusnetworks.com \
    --cc=sworley@cumulusnetworks.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).