netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ben Greear <greearb@candelatech.com>
To: David Ahern <dsahern@gmail.com>,
	Donald Sharp <sharpd@cumulusnetworks.com>,
	netdev@vger.kernel.org, dsahern@kernel.org,
	roopa@cumulusnetworks.com, sworley@cumulusnetworks.com
Subject: Re: [PATCH] ip link: Prevent duplication of table id for vrf tables
Date: Mon, 9 Mar 2020 07:04:37 -0700	[thread overview]
Message-ID: <c8145b59-6f26-ab55-c33a-362fe87fd59b@candelatech.com> (raw)
In-Reply-To: <b36df09f-2e15-063e-4b58-1b864bed8751@gmail.com>



On 03/08/2020 07:22 PM, David Ahern wrote:
> On 3/7/20 1:59 PM, Donald Sharp wrote:
>> Creation of different vrf's with duplicate table id's creates
>> a situation where two different routing entities believe
>> they have exclusive access to a particular table.  This
>> leads to situations where different routing processes
>> clash for control of a route due to inadvertent table
>> id overlap.  Prevent end user from making this mistake
>> on accident.
>
> I get the pain, but it is a user management problem and ip is but one
> tool. I think at most ip warns the user about the table duplication; it
> can't fail the create.

You could default 'ip' to use the safe mode, and allow a --force option if
there is some reason why it should be allowed?

Thanks,
Ben

-- 
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc  http://www.candelatech.com

      parent reply	other threads:[~2020-03-09 14:04 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-07 20:59 [PATCH] ip link: Prevent duplication of table id for vrf tables Donald Sharp
2020-03-09  2:22 ` David Ahern
2020-03-09 12:16   ` Donald Sharp
2020-03-10 23:33     ` David Ahern
2020-03-09 14:04   ` Ben Greear [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c8145b59-6f26-ab55-c33a-362fe87fd59b@candelatech.com \
    --to=greearb@candelatech.com \
    --cc=dsahern@gmail.com \
    --cc=dsahern@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=roopa@cumulusnetworks.com \
    --cc=sharpd@cumulusnetworks.com \
    --cc=sworley@cumulusnetworks.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).