* [PATCH net] qed: Disable "MFW indication via attention" SPAM every 5 minutes
@ 2020-07-14 22:08 Laurence Oberman
2020-07-14 22:16 ` David Miller
2020-07-15 8:04 ` [EXT] " Igor Russkikh
0 siblings, 2 replies; 3+ messages in thread
From: Laurence Oberman @ 2020-07-14 22:08 UTC (permalink / raw)
To: loberman, linux-scsi, QLogic-Storage-Upstream, netdev, aelior,
GR-everest-linux-l2
This is likely firmware causing this but its starting to annoy customers.
Change the message level to verbose to prevent the spam.
Note that this seems to only show up with ISCSI enabled on the HBA via the
qedi driver.
Signed-off-by: Laurence Oberman <loberman@redhat.com>
---
drivers/net/ethernet/qlogic/qed/qed_int.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/qlogic/qed/qed_int.c b/drivers/net/ethernet/qlogic/qed/qed_int.c
index b7b974f..d853eb9 100644
--- a/drivers/net/ethernet/qlogic/qed/qed_int.c
+++ b/drivers/net/ethernet/qlogic/qed/qed_int.c
@@ -1193,7 +1193,8 @@ static int qed_int_attentions(struct qed_hwfn *p_hwfn)
index, attn_bits, attn_acks, asserted_bits,
deasserted_bits, p_sb_attn_sw->known_attn);
} else if (asserted_bits == 0x100) {
- DP_INFO(p_hwfn, "MFW indication via attention\n");
+ DP_VERBOSE(p_hwfn, NETIF_MSG_INTR,
+ "MFW indication via attention\n");
} else {
DP_VERBOSE(p_hwfn, NETIF_MSG_INTR,
"MFW indication [deassertion]\n");
--
1.8.3.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net] qed: Disable "MFW indication via attention" SPAM every 5 minutes
2020-07-14 22:08 [PATCH net] qed: Disable "MFW indication via attention" SPAM every 5 minutes Laurence Oberman
@ 2020-07-14 22:16 ` David Miller
2020-07-15 8:04 ` [EXT] " Igor Russkikh
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2020-07-14 22:16 UTC (permalink / raw)
To: loberman
Cc: linux-scsi, QLogic-Storage-Upstream, netdev, aelior, GR-everest-linux-l2
From: Laurence Oberman <loberman@redhat.com>
Date: Tue, 14 Jul 2020 18:08:05 -0400
> This is likely firmware causing this but its starting to annoy customers.
> Change the message level to verbose to prevent the spam.
> Note that this seems to only show up with ISCSI enabled on the HBA via the
> qedi driver.
>
> Signed-off-by: Laurence Oberman <loberman@redhat.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [EXT] [PATCH net] qed: Disable "MFW indication via attention" SPAM every 5 minutes
2020-07-14 22:08 [PATCH net] qed: Disable "MFW indication via attention" SPAM every 5 minutes Laurence Oberman
2020-07-14 22:16 ` David Miller
@ 2020-07-15 8:04 ` Igor Russkikh
1 sibling, 0 replies; 3+ messages in thread
From: Igor Russkikh @ 2020-07-15 8:04 UTC (permalink / raw)
To: Laurence Oberman, linux-scsi, QLogic-Storage-Upstream, netdev,
Ariel Elior, GR-everest-linux-l2
> ----------------------------------------------------------------------
> This is likely firmware causing this but its starting to annoy customers.
> Change the message level to verbose to prevent the spam.
> Note that this seems to only show up with ISCSI enabled on the HBA via the
>
> qedi driver.
>
> Signed-off-by: Laurence Oberman <loberman@redhat.com>
Thanks for handling this, Laurence, we actually had the same fix in out of
tree driver recently, just missed upstreaming it.
Acked-by: Igor Russkikh <irusskikh@marvell.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-07-15 8:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-14 22:08 [PATCH net] qed: Disable "MFW indication via attention" SPAM every 5 minutes Laurence Oberman
2020-07-14 22:16 ` David Miller
2020-07-15 8:04 ` [EXT] " Igor Russkikh
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).