From: Saeed Mahameed <saeedm@mellanox.com>
To: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"gerlitz.or@gmail.com" <gerlitz.or@gmail.com>
Cc: "sashal@kernel.org" <sashal@kernel.org>,
"ecree@solarflare.com" <ecree@solarflare.com>,
"stable@vger.kernel.org" <stable@vger.kernel.org>,
"kuba@kernel.org" <kuba@kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"davem@davemloft.net" <davem@davemloft.net>
Subject: Re: [PATCH AUTOSEL 4.9 09/26] net/mlx5e: Init ethtool steering for representors
Date: Thu, 16 Apr 2020 19:31:25 +0000 [thread overview]
Message-ID: <b8651ce6d7d6c6dcb8b2d66f07148413892b48d0.camel@mellanox.com> (raw)
In-Reply-To: <20200416172001.GC1388618@kroah.com>
On Thu, 2020-04-16 at 19:20 +0200, Greg KH wrote:
> On Thu, Apr 16, 2020 at 04:40:31PM +0300, Or Gerlitz wrote:
> > On Thu, Apr 16, 2020 at 3:00 AM Sasha Levin <sashal@kernel.org>
> > wrote:
> > > I'd maybe point out that the selection process is based on a
> > > neural
> > > network which knows about the existence of a Fixes tag in a
> > > commit.
> > >
> > > It does exactly what you're describing, but also taking a bunch
> > > more
> > > factors into it's desicion process ("panic"? "oops"? "overflow"?
> > > etc).
> >
> > As Saeed commented, every extra line in stable / production kernel
> > is wrong.
>
> What? On what do you base that crazy statement on? I have 18+ years
> of
> direct experience of that being the exact opposite.
>
Oh, I never said such a thing .. :(
I think Or meant to say: every extra line that no one asked for.
And all i wanted to say is that it can have a catastrophic result..
I know in many cases it is working well, and i didn't say it is wrong,
I am just worried about it and wanted to show an example of how it can
screw up under the radar with a simple single liner patch..
> > IMHO it doesn't make any sense to take into stable automatically
> > any patch that doesn't have fixes line. Do you have 1/2/3/4/5
> > concrete
> > examples from your (referring to your Microsoft employee hat
> > comment
> > below) or other's people production environment where patches
> > proved to
> > be necessary but they lacked the fixes tag - would love to see
> > them.
>
> Oh wow, where do you want me to start. I have zillions of these.
>
> But wait, don't trust me, trust a 3rd party. Here's what Google's
> security team said about the last 9 months of 2019:
> - 209 known vulnerabilities patched in LTS kernels, most
> without
> CVEs
> - 950+ criticial non-security bugs fixes for device XXXX alone
> with LTS releases
>
So opt-in for these critical or _always_ in use basic kernel sections.
but make the default opt-out..
> > We've been coaching new comers for years during internal and on-
> > list
> > code reviews to put proper fixes tag. This serves (A) for the
> > upstream
> > human review of the patch and (B) reasonable human stable
> > considerations.
>
> If your driver/subsystem is doing this, wonderful, just opt-out of
> the
> autosel process and you will never be bothered again.
>
There are many legacy devices in the kernel that are not well
maintained and being rarely fixed from random users.. if a fix will be
picked up to the wrong kernel, it can go unnoticed for years..
> But, trust me, I think I know a bit about tagging stuff for stable
> kernels, and yet the AUTOSEL tool keeps finding patches that _I_
> forgot
> to tag as such. So, don't be so sure of yourself, it's humbling :)
>
> Let the AUTOSEL tool run, and if it finds things you don't agree
> with, a
> simple "No, please do not include this" email is all you need to do
> to
> keep it out of a stable kernel.
>
> So far the AUTOSEL tool has found so many real bugfixes that it isn't
> funny. If you don't like it, fine, but it has proven itself _way_
> beyond my wildest hopes already, and it just keeps getting better.
>
Now i really don't know what the right balance here, in on one hand,
autosel is doing a great job, on the other hand we know it can screw up
in some cases, and we know it will.
So we decided to make sacrifices for the greater good ? :)
> greg k-h
next prev parent reply other threads:[~2020-04-16 19:31 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-11 23:13 [PATCH AUTOSEL 4.9 01/26] net: wan: wanxl: use allow to pass CROSS_COMPILE_M68k for rebuilding firmware Sasha Levin
2020-04-11 23:13 ` [PATCH AUTOSEL 4.9 02/26] net: phy: probe PHY drivers synchronously Sasha Levin
2020-04-11 23:13 ` [PATCH AUTOSEL 4.9 04/26] net: phy: mscc: accept all RGMII species in vsc85xx_mac_if_set Sasha Levin
2020-04-11 23:13 ` [PATCH AUTOSEL 4.9 06/26] mwifiex: set needed_headroom, not hard_header_len Sasha Levin
2020-04-11 23:13 ` [PATCH AUTOSEL 4.9 07/26] Bluetooth: L2CAP: handle l2cap config request during open state Sasha Levin
2020-04-11 23:13 ` [PATCH AUTOSEL 4.9 09/26] net/mlx5e: Init ethtool steering for representors Sasha Levin
2020-04-12 7:10 ` Or Gerlitz
2020-04-12 17:59 ` Jakub Kicinski
2020-04-12 18:29 ` Or Gerlitz
2020-04-14 1:56 ` Sasha Levin
2020-04-14 7:16 ` Leon Romanovsky
2020-04-14 10:22 ` Or Gerlitz
2020-04-14 11:09 ` Greg KH
2020-04-14 14:38 ` Or Gerlitz
2020-04-14 15:16 ` Sasha Levin
2020-04-14 15:49 ` Edward Cree
2020-04-14 17:37 ` Leon Romanovsky
2020-04-14 19:03 ` Jakub Kicinski
2020-04-14 21:00 ` Sasha Levin
2020-04-14 22:50 ` Michal Kubecek
2020-04-15 5:31 ` Leon Romanovsky
2020-04-15 14:07 ` Sasha Levin
2020-04-14 20:57 ` Sasha Levin
2020-04-15 16:18 ` Edward Cree
2020-04-16 0:00 ` Sasha Levin
2020-04-16 4:08 ` Saeed Mahameed
2020-04-16 5:24 ` Leon Romanovsky
2020-04-16 13:30 ` Sasha Levin
2020-04-16 19:07 ` Saeed Mahameed
2020-04-16 19:58 ` Sasha Levin
2020-04-16 21:08 ` Saeed Mahameed
2020-04-17 8:28 ` gregkh
2020-04-17 22:23 ` Saeed Mahameed
2020-04-18 10:51 ` gregkh
2020-04-17 13:21 ` Sasha Levin
2020-04-17 22:38 ` Saeed Mahameed
2020-04-16 13:40 ` Or Gerlitz
2020-04-16 14:04 ` Sasha Levin
2020-04-16 14:17 ` Or Gerlitz
2020-04-16 14:36 ` Sasha Levin
2020-04-16 17:20 ` Greg KH
2020-04-16 19:31 ` Saeed Mahameed [this message]
2020-04-16 19:53 ` Sasha Levin
2020-04-16 21:32 ` Saeed Mahameed
2020-04-16 23:23 ` Sasha Levin
2020-04-21 3:07 ` Saeed Mahameed
2020-04-16 20:08 ` Jakub Kicinski
2020-04-16 21:11 ` Saeed Mahameed
2020-04-17 8:25 ` gregkh
2020-04-16 16:06 ` Edward Cree
2020-04-16 18:49 ` Sasha Levin
2020-04-20 11:45 ` Edward Cree
2020-04-20 12:53 ` Sasha Levin
2020-04-11 23:13 ` [PATCH AUTOSEL 4.9 10/26] Bluetooth: Fix calculation of SCO handle for packet processing Sasha Levin
2020-04-11 23:13 ` [PATCH AUTOSEL 4.9 11/26] Bluetooth: guard against controllers sending zero'd events Sasha Levin
2020-04-11 23:14 ` [PATCH AUTOSEL 4.9 13/26] net: intel: e1000e: fix possible sleep-in-atomic-context bugs in e1000e_get_hw_semaphore() Sasha Levin
2020-04-11 23:14 ` [PATCH AUTOSEL 4.9 19/26] Bluetooth: RFCOMM: fix ODEBUG bug in rfcomm_dev_ioctl Sasha Levin
2020-04-11 23:14 ` [PATCH AUTOSEL 4.9 20/26] brcmfmac: Fix driver crash on USB control transfer timeout Sasha Levin
2020-04-11 23:14 ` [PATCH AUTOSEL 4.9 26/26] svcrdma: Fix leak of transport addresses Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b8651ce6d7d6c6dcb8b2d66f07148413892b48d0.camel@mellanox.com \
--to=saeedm@mellanox.com \
--cc=davem@davemloft.net \
--cc=ecree@solarflare.com \
--cc=gerlitz.or@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sashal@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).