From: Florian Fainelli <f.fainelli@gmail.com>
To: Russell King - ARM Linux admin <linux@armlinux.org.uk>,
Vivien Didelot <vivien.didelot@gmail.com>
Cc: Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org
Subject: Re: [PATCH net-next v2 2/3] net: dsa: mv88e6xxx: add support for bridge flags
Date: Tue, 19 Feb 2019 15:53:50 -0800 [thread overview]
Message-ID: <bbea158f-c541-4a64-958f-c86eeedcbfcb@gmail.com> (raw)
In-Reply-To: <20190219233408.th2wukhmtxdmeivj@shell.armlinux.org.uk>
On 2/19/19 3:34 PM, Russell King - ARM Linux admin wrote:
> On Tue, Feb 19, 2019 at 05:00:59PM +0000, Russell King - ARM Linux admin wrote:
>> I've just changed my last patch to set these modes from
>> dsa_port_bridge_join() and dsa_port_bridge_leave(), and while testing,
>> I notice this on the ZII rev B board:
>>
>> At boot (without anything connected to any of the switch ports):
>>
>> br0: port 1(lan0) entered blocking state
>> br0: port 1(lan0) entered disabled state
>> device lan0 entered promiscuous mode
>> device eth1 entered promiscuous mode
>> br0: port 2(lan1) entered blocking state
>> br0: port 2(lan1) entered disabled state
>> device lan1 entered promiscuous mode
>> ...
>>
>> I then removed lan0 from the bridge:
>>
>> device lan0 left promiscuous mode
>> br0: port 1(lan0) entered disabled state
>>
>> and then added it back:
>>
>> br0: port 1(lan0) entered blocking state
>> br0: port 1(lan0) entered disabled state
>> device lan0 entered promiscuous mode
>>
>> Now, you'd expect lan0 and lan1 to be configured the same at this
>> point, and the same as it was before lan0 was removed from the bridge?
>> lan0 is port 0, lan1 is port 1 on this switch - and the register debug
>> says:
>>
>> GLOBAL GLOBAL2 SERDES 0 1 2 3 4 5 6
>> 0: c800 0 1140 500f 500f 500f 500f 500f 4e07 4d04
>> ...
>> 4: 40a8 258 1e0 43c 43d 43d 7c 430 53f 373f
>>
>> Note that port 0 is in disabled state, but port 1 and 2 are in
>> blocking state... but wait, the kernel printed a message saying it was
>> in disabled state!
>>
>> If I do the same for lan1, port 1 above changed from 0x43d to 0x433 as
>> expected, and then returns to 0x43c.
>>
>> It looks like DSA isn't always in sync with bridge as per port state.
>
> Okay, the problem is what we do when we up the port.
>
> When the port is added to the bridge device, and it's down, the bridge
> code sets the STP state to "disabled".
>
> Then when we up the interface, dsa_slave_open() calls dsa_port_enable(),
> which then decides to change the STP state on its own without reference
> to the state assigned by net/bridge:
>
> int dsa_port_enable(struct dsa_port *dp, struct phy_device *phy)
> {
> u8 stp_state = dp->bridge_dev ? BR_STATE_BLOCKING : BR_STATE_FORWARDING;
> ...
> dsa_port_set_state_now(dp, stp_state);
> ...
> }
>
> I can understand setting the state to BR_STATE_FORWARDING for
> stand-alone ports, but why for bridged ports when the bridge code has
> already taken care of configuring the STP state of the port?
There was no reason for doing that in commit
b73adef67765b72f2a0d01ef15aff9d784dc85da ("net: dsa: integrate with
SWITCHDEV for HW bridging") other than copying what rocker had done
(which served as model back then), and which got changed the next day in
rocker with: e47172ab7e4176883077b454286bbd5b87b5f488 ("rocker: put port
in FORWADING state after leaving bridge")
Good catch!
--
Florian
next prev parent reply other threads:[~2019-02-19 23:53 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-17 14:24 [PATCH net-next 0/3] net: dsa: mv88e6xxx: fix IPv6 Russell King - ARM Linux admin
2019-02-17 14:25 ` [PATCH net-next 1/3] net: dsa: add support for bridge flags Russell King
2019-02-17 21:37 ` Florian Fainelli
2019-02-17 22:04 ` Russell King - ARM Linux admin
2019-02-17 22:07 ` Florian Fainelli
2019-02-18 0:50 ` Russell King - ARM Linux admin
2019-02-18 11:23 ` Russell King - ARM Linux admin
2019-02-19 15:42 ` Vivien Didelot
2019-02-17 14:25 ` [PATCH net-next 2/3] net: dsa: mv88e6xxx: " Russell King
2019-02-17 21:38 ` Florian Fainelli
2019-02-17 14:25 ` [PATCH net-next 3/3] net: dsa: mv88e6xxx: defautl to multicast and unicast flooding Russell King
2019-02-17 14:27 ` Russell King - ARM Linux admin
2019-02-17 16:34 ` Russell King - ARM Linux admin
2019-02-17 21:45 ` Florian Fainelli
2019-02-17 21:58 ` Russell King - ARM Linux admin
2019-02-17 22:03 ` Florian Fainelli
2019-02-17 22:19 ` Russell King - ARM Linux admin
2019-02-17 22:30 ` Florian Fainelli
2019-02-17 16:31 ` [PATCH net-next v2 0/3] net: dsa: mv88e6xxx: fix IPv6 Russell King - ARM Linux admin
2019-02-17 16:32 ` [PATCH net-next v2 1/3] net: dsa: add support for bridge flags Russell King
2019-02-17 16:32 ` [PATCH net-next v2 2/3] net: dsa: mv88e6xxx: " Russell King
2019-02-19 16:16 ` Vivien Didelot
2019-02-19 16:24 ` Russell King - ARM Linux admin
2019-02-19 17:00 ` Vivien Didelot
2019-02-19 17:14 ` Russell King - ARM Linux admin
2019-02-19 17:38 ` Vivien Didelot
2019-02-19 17:44 ` Florian Fainelli
2019-02-19 18:20 ` Vivien Didelot
2019-02-19 18:08 ` Russell King - ARM Linux admin
2019-02-19 19:04 ` Vivien Didelot
2019-02-19 19:10 ` Russell King - ARM Linux admin
2019-02-19 19:37 ` Florian Fainelli
2019-02-19 19:56 ` Vivien Didelot
2019-02-19 22:52 ` Russell King - ARM Linux admin
2019-02-19 17:00 ` Russell King - ARM Linux admin
2019-02-19 17:23 ` Vivien Didelot
2019-02-19 17:27 ` Russell King - ARM Linux admin
2019-02-19 23:34 ` Russell King - ARM Linux admin
2019-02-19 23:53 ` Florian Fainelli [this message]
2019-02-20 0:07 ` Russell King - ARM Linux admin
2019-02-17 16:32 ` [PATCH net-next v2 3/3] net: dsa: mv88e6xxx: default to multicast and unicast flooding Russell King
2019-02-18 12:53 ` Russell King - ARM Linux admin
2019-02-19 16:05 ` Vivien Didelot
2019-02-19 16:18 ` Russell King - ARM Linux admin
2019-02-18 11:34 ` [PATCH net-next v2 0/3] net: dsa: mv88e6xxx: fix IPv6 Russell King - ARM Linux admin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bbea158f-c541-4a64-958f-c86eeedcbfcb@gmail.com \
--to=f.fainelli@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=hkallweit1@gmail.com \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).