* for newbies, it would be useful to document values of netdev_state_t
@ 2018-08-04 15:30 Robert P. J. Day
2018-08-04 18:10 ` Florian Fainelli
2018-08-08 8:45 ` Julian Wiedmann
0 siblings, 2 replies; 3+ messages in thread
From: Robert P. J. Day @ 2018-08-04 15:30 UTC (permalink / raw)
To: Linux kernel ntedev mailing list
i'm sure this is second nature for the experts here, but in
netdevice.h:
/* These flag bits are private to the generic network queueing
* layer; they may not be explicitly referenced by any other
* code.
*/
enum netdev_state_t {
__LINK_STATE_START,
__LINK_STATE_PRESENT,
__LINK_STATE_NOCARRIER,
__LINK_STATE_LINKWATCH_PENDING,
__LINK_STATE_DORMANT,
};
it would be handy to have a short explanation of what each state
represents, perhaps what combinations are possible and how one moves
from one state to another.
rday
--
========================================================================
Robert P. J. Day Ottawa, Ontario, CANADA
http://crashcourse.ca/dokuwiki
Twitter: http://twitter.com/rpjday
LinkedIn: http://ca.linkedin.com/in/rpjday
========================================================================
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: for newbies, it would be useful to document values of netdev_state_t
2018-08-04 15:30 for newbies, it would be useful to document values of netdev_state_t Robert P. J. Day
@ 2018-08-04 18:10 ` Florian Fainelli
2018-08-08 8:45 ` Julian Wiedmann
1 sibling, 0 replies; 3+ messages in thread
From: Florian Fainelli @ 2018-08-04 18:10 UTC (permalink / raw)
To: Robert P. J. Day, Linux kernel ntedev mailing list
On 08/04/2018 08:30 AM, Robert P. J. Day wrote:
>
> i'm sure this is second nature for the experts here, but in
> netdevice.h:
>
> /* These flag bits are private to the generic network queueing
> * layer; they may not be explicitly referenced by any other
> * code.
> */
>
> enum netdev_state_t {
> __LINK_STATE_START,
> __LINK_STATE_PRESENT,
> __LINK_STATE_NOCARRIER,
> __LINK_STATE_LINKWATCH_PENDING,
> __LINK_STATE_DORMANT,
> };
>
> it would be handy to have a short explanation of what each state
> represents, perhaps what combinations are possible and how one moves
> from one state to another.
This has been like that for some time, and with the exception of the
problem you reported in your email before that one, people generally
don't muck with that enum, or the state machine consuming it. There
might be other places that could deserve better documentation ;)
--
Florian
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: for newbies, it would be useful to document values of netdev_state_t
2018-08-04 15:30 for newbies, it would be useful to document values of netdev_state_t Robert P. J. Day
2018-08-04 18:10 ` Florian Fainelli
@ 2018-08-08 8:45 ` Julian Wiedmann
1 sibling, 0 replies; 3+ messages in thread
From: Julian Wiedmann @ 2018-08-08 8:45 UTC (permalink / raw)
To: Robert P. J. Day, Linux kernel ntedev mailing list
On 08/04/2018 05:30 PM, Robert P. J. Day wrote:
>
> i'm sure this is second nature for the experts here, but in
> netdevice.h:
>
> /* These flag bits are private to the generic network queueing
> * layer; they may not be explicitly referenced by any other
> * code.
> */
>
> enum netdev_state_t {
> __LINK_STATE_START,
> __LINK_STATE_PRESENT,
> __LINK_STATE_NOCARRIER,
> __LINK_STATE_LINKWATCH_PENDING,
> __LINK_STATE_DORMANT,
> };
>
> it would be handy to have a short explanation of what each state
> represents, perhaps what combinations are possible and how one moves
> from one state to another.
>
> rday
>
It is far from perfect, but Documentation/networking/operstates.txt
might get you started.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-08-08 11:03 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-08-04 15:30 for newbies, it would be useful to document values of netdev_state_t Robert P. J. Day
2018-08-04 18:10 ` Florian Fainelli
2018-08-08 8:45 ` Julian Wiedmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).