From: Christophe Leroy <christophe.leroy@csgroup.eu>
To: Zheng Yongjun <zhengyongjun3@huawei.com>,
"pantelis.antoniou@gmail.com" <pantelis.antoniou@gmail.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"edumazet@google.com" <edumazet@google.com>,
"kuba@kernel.org" <kuba@kernel.org>,
"pabeni@redhat.com" <pabeni@redhat.com>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: "zhengbin13@huawei.com" <zhengbin13@huawei.com>
Subject: Re: [PATCH -next] net: fs_enet: Fix wrong check in do_pd_setup
Date: Thu, 15 Sep 2022 06:27:10 +0000 [thread overview]
Message-ID: <c84e673c-3542-c5e5-3779-17312779871d@csgroup.eu> (raw)
In-Reply-To: <20220908135513.53449-1-zhengyongjun3@huawei.com>
Le 08/09/2022 à 15:55, Zheng Yongjun a écrit :
> [Vous ne recevez pas souvent de courriers de zhengyongjun3@huawei.com. Découvrez pourquoi ceci est important à https://aka.ms/LearnAboutSenderIdentification ]
>
> Should check of_iomap return value 'fep->fec.fecp' instead of 'fep->fcc.fccp'
>
> Fixes: 976de6a8c304 ("fs_enet: Be an of_platform device when CONFIG_PPC_CPM_NEW_BINDING is set.")
> Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com>
Reviewed-by: Christophe Leroy <christophe.leroy@csgroup.eu>
> ---
> drivers/net/ethernet/freescale/fs_enet/mac-fec.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/freescale/fs_enet/mac-fec.c b/drivers/net/ethernet/freescale/fs_enet/mac-fec.c
> index 99fe2c210d0f..61f4b6e50d29 100644
> --- a/drivers/net/ethernet/freescale/fs_enet/mac-fec.c
> +++ b/drivers/net/ethernet/freescale/fs_enet/mac-fec.c
> @@ -98,7 +98,7 @@ static int do_pd_setup(struct fs_enet_private *fep)
> return -EINVAL;
>
> fep->fec.fecp = of_iomap(ofdev->dev.of_node, 0);
> - if (!fep->fcc.fccp)
> + if (!fep->fec.fecp)
> return -EINVAL;
>
> return 0;
> --
> 2.17.1
>
prev parent reply other threads:[~2022-09-15 6:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-08 13:55 [PATCH -next] net: fs_enet: Fix wrong check in do_pd_setup Zheng Yongjun
2022-09-15 6:27 ` Christophe Leroy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c84e673c-3542-c5e5-3779-17312779871d@csgroup.eu \
--to=christophe.leroy@csgroup.eu \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pantelis.antoniou@gmail.com \
--cc=zhengbin13@huawei.com \
--cc=zhengyongjun3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).