* [PATCH -next] net: fs_enet: Fix wrong check in do_pd_setup
@ 2022-09-08 13:55 Zheng Yongjun
2022-09-15 6:27 ` Christophe Leroy
0 siblings, 1 reply; 2+ messages in thread
From: Zheng Yongjun @ 2022-09-08 13:55 UTC (permalink / raw)
To: pantelis.antoniou, davem, edumazet, kuba, pabeni, linuxppc-dev,
netdev, linux-kernel
Cc: zhengbin13
Should check of_iomap return value 'fep->fec.fecp' instead of 'fep->fcc.fccp'
Fixes: 976de6a8c304 ("fs_enet: Be an of_platform device when CONFIG_PPC_CPM_NEW_BINDING is set.")
Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com>
---
drivers/net/ethernet/freescale/fs_enet/mac-fec.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/freescale/fs_enet/mac-fec.c b/drivers/net/ethernet/freescale/fs_enet/mac-fec.c
index 99fe2c210d0f..61f4b6e50d29 100644
--- a/drivers/net/ethernet/freescale/fs_enet/mac-fec.c
+++ b/drivers/net/ethernet/freescale/fs_enet/mac-fec.c
@@ -98,7 +98,7 @@ static int do_pd_setup(struct fs_enet_private *fep)
return -EINVAL;
fep->fec.fecp = of_iomap(ofdev->dev.of_node, 0);
- if (!fep->fcc.fccp)
+ if (!fep->fec.fecp)
return -EINVAL;
return 0;
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] net: fs_enet: Fix wrong check in do_pd_setup
2022-09-08 13:55 [PATCH -next] net: fs_enet: Fix wrong check in do_pd_setup Zheng Yongjun
@ 2022-09-15 6:27 ` Christophe Leroy
0 siblings, 0 replies; 2+ messages in thread
From: Christophe Leroy @ 2022-09-15 6:27 UTC (permalink / raw)
To: Zheng Yongjun, pantelis.antoniou, davem, edumazet, kuba, pabeni,
linuxppc-dev, netdev, linux-kernel
Cc: zhengbin13
Le 08/09/2022 à 15:55, Zheng Yongjun a écrit :
> [Vous ne recevez pas souvent de courriers de zhengyongjun3@huawei.com. Découvrez pourquoi ceci est important à https://aka.ms/LearnAboutSenderIdentification ]
>
> Should check of_iomap return value 'fep->fec.fecp' instead of 'fep->fcc.fccp'
>
> Fixes: 976de6a8c304 ("fs_enet: Be an of_platform device when CONFIG_PPC_CPM_NEW_BINDING is set.")
> Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com>
Reviewed-by: Christophe Leroy <christophe.leroy@csgroup.eu>
> ---
> drivers/net/ethernet/freescale/fs_enet/mac-fec.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/freescale/fs_enet/mac-fec.c b/drivers/net/ethernet/freescale/fs_enet/mac-fec.c
> index 99fe2c210d0f..61f4b6e50d29 100644
> --- a/drivers/net/ethernet/freescale/fs_enet/mac-fec.c
> +++ b/drivers/net/ethernet/freescale/fs_enet/mac-fec.c
> @@ -98,7 +98,7 @@ static int do_pd_setup(struct fs_enet_private *fep)
> return -EINVAL;
>
> fep->fec.fecp = of_iomap(ofdev->dev.of_node, 0);
> - if (!fep->fcc.fccp)
> + if (!fep->fec.fecp)
> return -EINVAL;
>
> return 0;
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-09-15 6:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-08 13:55 [PATCH -next] net: fs_enet: Fix wrong check in do_pd_setup Zheng Yongjun
2022-09-15 6:27 ` Christophe Leroy
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).