* [PATCH] qed: remove an unneed NULL check on list iterator
@ 2022-03-19 4:36 Xiaomeng Tong
2022-03-22 8:52 ` Paolo Abeni
0 siblings, 1 reply; 5+ messages in thread
From: Xiaomeng Tong @ 2022-03-19 4:36 UTC (permalink / raw)
To: davem, kuba; +Cc: aelior, manishc, netdev, linux-kernel, Xiaomeng Tong
The define for_each_pci_dev(d) is:
while ((d = pci_get_device(PCI_ANY_ID, PCI_ANY_ID, d)) != NULL)
Thus, the list iterator 'd' is always non-NULL so it doesn't need to
be checked. So just remove the unnecessary NULL check. Also remove the
unnecessary initializer because the list iterator is always initialized.
Signed-off-by: Xiaomeng Tong <xiam0nd.tong@gmail.com>
---
drivers/net/ethernet/qlogic/qed/qed_nvmetcp_ip_services.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/qlogic/qed/qed_nvmetcp_ip_services.c b/drivers/net/ethernet/qlogic/qed/qed_nvmetcp_ip_services.c
index 96a2077fd315..37af8395f1bd 100644
--- a/drivers/net/ethernet/qlogic/qed/qed_nvmetcp_ip_services.c
+++ b/drivers/net/ethernet/qlogic/qed/qed_nvmetcp_ip_services.c
@@ -161,11 +161,11 @@ EXPORT_SYMBOL(qed_vlan_get_ndev);
struct pci_dev *qed_validate_ndev(struct net_device *ndev)
{
- struct pci_dev *pdev = NULL;
+ struct pci_dev *pdev;
struct net_device *upper;
for_each_pci_dev(pdev) {
- if (pdev && pdev->driver &&
+ if (pdev->driver &&
!strcmp(pdev->driver->name, "qede")) {
upper = pci_get_drvdata(pdev);
if (upper->ifindex == ndev->ifindex)
--
2.17.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] qed: remove an unneed NULL check on list iterator
2022-03-19 4:36 [PATCH] qed: remove an unneed NULL check on list iterator Xiaomeng Tong
@ 2022-03-22 8:52 ` Paolo Abeni
0 siblings, 0 replies; 5+ messages in thread
From: Paolo Abeni @ 2022-03-22 8:52 UTC (permalink / raw)
To: Xiaomeng Tong, davem, kuba; +Cc: aelior, manishc, netdev, linux-kernel
Hello,
On Sat, 2022-03-19 at 12:36 +0800, Xiaomeng Tong wrote:
> The define for_each_pci_dev(d) is:
> while ((d = pci_get_device(PCI_ANY_ID, PCI_ANY_ID, d)) != NULL)
>
> Thus, the list iterator 'd' is always non-NULL so it doesn't need to
> be checked. So just remove the unnecessary NULL check. Also remove the
> unnecessary initializer because the list iterator is always initialized.
>
> Signed-off-by: Xiaomeng Tong <xiam0nd.tong@gmail.com>
This looks like a net-next change, but net-next is now closed. please
repost 2 weeks, thanks!
Paolo
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] qed: remove an unneed NULL check on list iterator
2022-04-06 1:26 ` Jakub Kicinski
@ 2022-04-07 1:22 ` Xiaomeng Tong
0 siblings, 0 replies; 5+ messages in thread
From: Xiaomeng Tong @ 2022-04-07 1:22 UTC (permalink / raw)
To: kuba; +Cc: aelior, davem, linux-kernel, manishc, netdev, pabeni, xiam0nd.tong
On Tue, 5 Apr 2022 18:26:41 -0700, Jakub Kicinski wrote:
> On Tue, 5 Apr 2022 08:22:56 +0800 Xiaomeng Tong wrote:
> > struct pci_dev *qed_validate_ndev(struct net_device *ndev)
> > {
> > - struct pci_dev *pdev = NULL;
> > + struct pci_dev *pdev;
> > struct net_device *upper;
>
> Please keep the longest-to-shortest ordering of variable declaration
> lines.
I have fix it in v2 patch [1], as you suggested. Please check it.
Thank you very much.
[1] https://lore.kernel.org/lkml/20220406015921.29267-1-xiam0nd.tong@gmail.com/
--
Xiaomeng Tong
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] qed: remove an unneed NULL check on list iterator
2022-04-05 0:22 Xiaomeng Tong
@ 2022-04-06 1:26 ` Jakub Kicinski
2022-04-07 1:22 ` Xiaomeng Tong
0 siblings, 1 reply; 5+ messages in thread
From: Jakub Kicinski @ 2022-04-06 1:26 UTC (permalink / raw)
To: Xiaomeng Tong; +Cc: aelior, manishc, davem, pabeni, netdev, linux-kernel
On Tue, 5 Apr 2022 08:22:56 +0800 Xiaomeng Tong wrote:
> struct pci_dev *qed_validate_ndev(struct net_device *ndev)
> {
> - struct pci_dev *pdev = NULL;
> + struct pci_dev *pdev;
> struct net_device *upper;
Please keep the longest-to-shortest ordering of variable declaration
lines.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] qed: remove an unneed NULL check on list iterator
@ 2022-04-05 0:22 Xiaomeng Tong
2022-04-06 1:26 ` Jakub Kicinski
0 siblings, 1 reply; 5+ messages in thread
From: Xiaomeng Tong @ 2022-04-05 0:22 UTC (permalink / raw)
To: aelior, manishc, davem, kuba, pabeni; +Cc: netdev, linux-kernel, Xiaomeng Tong
The define for_each_pci_dev(d) is:
while ((d = pci_get_device(PCI_ANY_ID, PCI_ANY_ID, d)) != NULL)
Thus, the list iterator 'd' is always non-NULL so it doesn't need to
be checked. So just remove the unnecessary NULL check. Also remove the
unnecessary initializer because the list iterator is always initialized.
Signed-off-by: Xiaomeng Tong <xiam0nd.tong@gmail.com>
---
drivers/net/ethernet/qlogic/qed/qed_nvmetcp_ip_services.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/qlogic/qed/qed_nvmetcp_ip_services.c b/drivers/net/ethernet/qlogic/qed/qed_nvmetcp_ip_services.c
index 96a2077fd315..37af8395f1bd 100644
--- a/drivers/net/ethernet/qlogic/qed/qed_nvmetcp_ip_services.c
+++ b/drivers/net/ethernet/qlogic/qed/qed_nvmetcp_ip_services.c
@@ -161,11 +161,11 @@ EXPORT_SYMBOL(qed_vlan_get_ndev);
struct pci_dev *qed_validate_ndev(struct net_device *ndev)
{
- struct pci_dev *pdev = NULL;
+ struct pci_dev *pdev;
struct net_device *upper;
for_each_pci_dev(pdev) {
- if (pdev && pdev->driver &&
+ if (pdev->driver &&
!strcmp(pdev->driver->name, "qede")) {
upper = pci_get_drvdata(pdev);
if (upper->ifindex == ndev->ifindex)
--
2.17.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-04-07 1:31 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-19 4:36 [PATCH] qed: remove an unneed NULL check on list iterator Xiaomeng Tong
2022-03-22 8:52 ` Paolo Abeni
2022-04-05 0:22 Xiaomeng Tong
2022-04-06 1:26 ` Jakub Kicinski
2022-04-07 1:22 ` Xiaomeng Tong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).