From: Dan Murphy <dmurphy@ti.com>
To: Florian Fainelli <f.fainelli@gmail.com>, <davem@davemloft.net>,
<andrew@lunn.ch>, <hkallweit1@gmail.com>
Cc: <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next 1/2] dt-bindings: dp83td510: Add binding for DP83TD510 Ethernet PHY
Date: Thu, 8 Oct 2020 13:18:09 -0500 [thread overview]
Message-ID: <cb44ea1f-4c7a-98c6-6206-526169d8f24b@ti.com> (raw)
In-Reply-To: <b704d919-b665-04e7-39bf-fadd5bc35ecf@gmail.com>
Florian
Thanks for the review
On 10/8/20 12:11 PM, Florian Fainelli wrote:
>
>
> On 10/8/2020 9:23 AM, Dan Murphy wrote:
>> The DP83TD510 is a 10M single twisted pair Ethernet PHY
>>
>> Signed-off-by: Dan Murphy <dmurphy@ti.com>
>> ---
>> .../devicetree/bindings/net/ti,dp83td510.yaml | 70 +++++++++++++++++++
>> 1 file changed, 70 insertions(+)
>> create mode 100644
>> Documentation/devicetree/bindings/net/ti,dp83td510.yaml
>>
>> diff --git a/Documentation/devicetree/bindings/net/ti,dp83td510.yaml
>> b/Documentation/devicetree/bindings/net/ti,dp83td510.yaml
>> new file mode 100644
>> index 000000000000..0f0eac77a11a
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/net/ti,dp83td510.yaml
>> @@ -0,0 +1,70 @@
>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>> +# Copyright (C) 2020 Texas Instruments Incorporated
>> +%YAML 1.2
>> +---
>> +$id: "http://devicetree.org/schemas/net/ti,dp83td510.yaml#"
>> +$schema: "http://devicetree.org/meta-schemas/core.yaml#"
>> +
>> +title: TI DP83TD510 ethernet PHY
>> +
>> +allOf:
>> + - $ref: "ethernet-controller.yaml#"
>> +
>> +maintainers:
>> + - Dan Murphy <dmurphy@ti.com>
>> +
>> +description: |
>> + The PHY is an twisted pair 10Mbps Ethernet PHY that support MII,
>> RMII and
>> + RGMII interfaces.
>> +
>> + Specifications about the Ethernet PHY can be found at:
>> + http://www.ti.com/lit/ds/symlink/dp83td510e.pdf
>> +
>> +properties:
>> + reg:
>> + maxItems: 1
>> +
>> + tx-fifo-depth:
>> + description: |
>> + Transmitt FIFO depth for RMII mode. The PHY only exposes 4
>> nibble
>> + depths. The valid nibble depths are 4, 5, 6 and 8.
>> + default: 5
>> +
>> + rx-internal-delay-ps:
>> + description: |
>> + Setting this property to a non-zero number sets the RX
>> internal delay
>> + for the PHY. The internal delay for the PHY is fixed to 30ns
>> relative
>> + to receive data.
>> +
>> + tx-internal-delay-ps:
>> + description: |
>> + Setting this property to a non-zero number sets the TX
>> internal delay
>> + for the PHY. The internal delay for the PHY has a range of
>> -4 to 4ns
>> + relative to transmit data.
>
> Those two properties are already defined as part of
> Documentation/devicetree/bindings/net/ethernet-phy.yaml, so you can
> reference that binding, too.
OK I referenced the ethernet-controller.yaml for the delay. I am
wondering if we should add rx/tx-fifo-depth to the ethernet-phy.yaml as
well. That way PHYs only have to reference ethernet-phy.yaml.
Or maybe remove the internal-delay from the ethernet-phy.yaml and
reference the ethernet-controller.yaml in the ethernet-phy.yaml so we
don't have to maintain duplicate properties
>
>> +
>> + ti,master-slave-mode:
>> + $ref: /schemas/types.yaml#definitions/uint32
>> + default: 0
>> + description: |
>> + Force the PHY to be configured to a specific mode.
>> + Force Auto Negotiation - 0
>> + Force Master mode at 1v p2p - 1
>> + Force Master mode at 2.4v p2p - 2
>> + Force Slave mode at 1v p2p - 3
>> + Force Slave mode at 2.4v p2p - 4
>
> If you accept different values you should be indicating which values
> are supported with an enumeration.
Ah yes forgot the min/max
next prev parent reply other threads:[~2020-10-08 18:18 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-08 16:23 [PATCH net-next 0/2] DP83TD510 Single Pair 10Mbps Ethernet PHY Dan Murphy
2020-10-08 16:23 ` [PATCH net-next 1/2] dt-bindings: dp83td510: Add binding for DP83TD510 " Dan Murphy
2020-10-08 17:11 ` Florian Fainelli
2020-10-08 18:18 ` Dan Murphy [this message]
2020-10-08 16:23 ` [PATCH net-next 2/2] net: phy: dp83td510: Add support for the " Dan Murphy
2020-10-08 16:51 ` Heiner Kallweit
2020-10-08 17:00 ` Dan Murphy
2020-10-16 22:02 ` Andrew Lunn
2020-10-19 21:33 ` Dan Murphy
2020-10-19 21:55 ` Andrew Lunn
2020-10-19 22:04 ` Dan Murphy
2020-10-20 12:00 ` Dan Murphy
2020-10-20 13:46 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cb44ea1f-4c7a-98c6-6206-526169d8f24b@ti.com \
--to=dmurphy@ti.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).