From: Sergei Shtylyov <sergei.shtylyov@gmail.com>
To: Yuusuke Ashizuka <ashiduka@fujitsu.com>
Cc: netdev@vger.kernel.org, linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH v2] ravb: Fixed the problem that rmmod can not be done
Date: Thu, 30 Jul 2020 19:04:01 +0300 [thread overview]
Message-ID: <ce81e95d-b3b0-7f1c-8f97-8bdcb23d5a8e@gmail.com> (raw)
In-Reply-To: <20200730100151.7490-1-ashiduka@fujitsu.com>
Hello!
On 7/30/20 1:01 PM, Yuusuke Ashizuka wrote:
> ravb is a module driver, but I cannot rmmod it after insmod it.
Modular. And "insmod'ing it".
> ravb does mdio_init() at the time of probe, and module->refcnt is incremented
> by alloc_mdio_bitbang() called after that.
That seems a common pattern, inlluding the Renesas sh_eth driver...
> Therefore, even if ifup is not performed, the driver is in use and rmmod cannot
> be performed.
No, the driver's remove() method calls ravb_mdio_release() and that one calls
free_mdio_bitbang() that calls module_put(); the actual reason lies somewehre deeper
than this... Unfortunately I don't have the affected hardware anymore... :-(
[...]
MBR, Sergei
next prev parent reply other threads:[~2020-07-30 16:04 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-30 3:56 [PATCH] ravb: Fixed the problem that rmmod can not be done Yuusuke Ashizuka
2020-07-30 7:55 ` kernel test robot
2020-07-30 10:01 ` [PATCH v2] " Yuusuke Ashizuka
2020-07-30 11:37 ` Yoshihiro Shimoda
2020-07-30 16:24 ` Sergei Shtylyov
2020-07-31 6:43 ` Yoshihiro Shimoda
2020-07-31 17:45 ` Sergei Shtylyov
2020-07-30 16:04 ` Sergei Shtylyov [this message]
2020-07-31 10:18 ` ashiduka
2020-07-31 16:28 ` Sergei Shtylyov
2020-08-06 2:26 ` ashiduka
2020-07-31 18:32 ` Sergei Shtylyov
2020-08-06 2:28 ` ashiduka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ce81e95d-b3b0-7f1c-8f97-8bdcb23d5a8e@gmail.com \
--to=sergei.shtylyov@gmail.com \
--cc=ashiduka@fujitsu.com \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).