netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH net-next] net: phy: aquantia: add support for AQR114C PHY ID
@ 2024-03-15  8:06 Paweł Owoc
  2024-03-15 19:58 ` Andrew Lunn
  2024-04-01 14:51 ` [PATCH net-next v2] " Paweł Owoc
  0 siblings, 2 replies; 5+ messages in thread
From: Paweł Owoc @ 2024-03-15  8:06 UTC (permalink / raw)
  Cc: Paweł Owoc, Andrew Lunn, Heiner Kallweit, Russell King,
	David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
	Christian Marangi, Robert Marko, Russell King (Oracle),
	netdev, linux-kernel

Add support for AQR114C PHY ID. This PHY advertise 10G speed
but supports only up to 5G speed.

Signed-off-by: Paweł Owoc <frut3k7@gmail.com>
---
 drivers/net/phy/aquantia/aquantia_main.c | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)

diff --git a/drivers/net/phy/aquantia/aquantia_main.c b/drivers/net/phy/aquantia/aquantia_main.c
index 71bfddb8f453..e1fdfa537452 100644
--- a/drivers/net/phy/aquantia/aquantia_main.c
+++ b/drivers/net/phy/aquantia/aquantia_main.c
@@ -28,6 +28,7 @@
 #define PHY_ID_AQR412	0x03a1b712
 #define PHY_ID_AQR113	0x31c31c40
 #define PHY_ID_AQR113C	0x31c31c12
+#define PHY_ID_AQR114C	0x31c31c22
 #define PHY_ID_AQR813	0x31c31cb2
 
 #define MDIO_PHYXS_VEND_IF_STATUS		0xe812
@@ -962,6 +963,25 @@ static struct phy_driver aqr_driver[] = {
 	.get_stats      = aqr107_get_stats,
 	.link_change_notify = aqr107_link_change_notify,
 },
+{
+	PHY_ID_MATCH_MODEL(PHY_ID_AQR114C),
+	.name		= "Aquantia AQR114C",
+	.probe		= aqr107_probe,
+	.get_rate_matching = aqr107_get_rate_matching,
+	.config_init	= aqr111_config_init,
+	.config_aneg    = aqr_config_aneg,
+	.config_intr	= aqr_config_intr,
+	.handle_interrupt = aqr_handle_interrupt,
+	.read_status	= aqr107_read_status,
+	.get_tunable    = aqr107_get_tunable,
+	.set_tunable    = aqr107_set_tunable,
+	.suspend	= aqr107_suspend,
+	.resume		= aqr107_resume,
+	.get_sset_count	= aqr107_get_sset_count,
+	.get_strings	= aqr107_get_strings,
+	.get_stats	= aqr107_get_stats,
+	.link_change_notify = aqr107_link_change_notify,
+},
 {
 	PHY_ID_MATCH_MODEL(PHY_ID_AQR813),
 	.name		= "Aquantia AQR813",
@@ -999,6 +1019,7 @@ static struct mdio_device_id __maybe_unused aqr_tbl[] = {
 	{ PHY_ID_MATCH_MODEL(PHY_ID_AQR412) },
 	{ PHY_ID_MATCH_MODEL(PHY_ID_AQR113) },
 	{ PHY_ID_MATCH_MODEL(PHY_ID_AQR113C) },
+	{ PHY_ID_MATCH_MODEL(PHY_ID_AQR114C) },
 	{ PHY_ID_MATCH_MODEL(PHY_ID_AQR813) },
 	{ }
 };
-- 
2.44.0


^ permalink raw reply related	[flat|nested] 5+ messages in thread
* Re: [PATCH net-next] net: phy: aquantia: add support for AQR114C PHY ID
  2024-03-15  8:06 [PATCH net-next] net: phy: aquantia: add support for AQR114C PHY ID Paweł Owoc
@ 2024-03-15 19:58 ` Andrew Lunn
  2024-04-01 14:51 ` [PATCH net-next v2] " Paweł Owoc
  1 sibling, 0 replies; 5+ messages in thread
From: Andrew Lunn @ 2024-03-15 19:58 UTC (permalink / raw)
  To: Paweł Owoc
  Cc: Heiner Kallweit, Russell King, David S. Miller, Eric Dumazet,
	Jakub Kicinski, Paolo Abeni, Christian Marangi, Robert Marko,
	Russell King (Oracle),
	netdev, linux-kernel

On Fri, Mar 15, 2024 at 09:06:50AM +0100, Paweł Owoc wrote:
> Add support for AQR114C PHY ID. This PHY advertise 10G speed
> but supports only up to 5G speed.

net-next is closed at the moment. Please repost when it opens.

Additionally, please could you extend the commit message to explain
how this patch actually deals with it advertising 10G when it should
not.

	Andrew

^ permalink raw reply	[flat|nested] 5+ messages in thread
* [PATCH net-next v2] net: phy: aquantia: add support for AQR114C PHY ID
  2024-03-15  8:06 [PATCH net-next] net: phy: aquantia: add support for AQR114C PHY ID Paweł Owoc
  2024-03-15 19:58 ` Andrew Lunn
@ 2024-04-01 14:51 ` Paweł Owoc
  2024-04-01 14:54   ` Andrew Lunn
  2024-04-03  1:10   ` patchwork-bot+netdevbpf
  1 sibling, 2 replies; 5+ messages in thread
From: Paweł Owoc @ 2024-04-01 14:51 UTC (permalink / raw)
  Cc: Paweł Owoc, Andrew Lunn, Heiner Kallweit, Russell King,
	David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
	Christian Marangi, Robert Marko, Russell King (Oracle),
	netdev, linux-kernel

Add support for AQR114C PHY ID. This PHY advertise 10G speed:
SPEED(0x04): 0x6031
  capabilities: -400g +5g +2.5g -200g -25g -10g-xr -100g -40g -10g/1g -10
                +100 +1000 -10-ts -2-tl +10g
EXTABLE(0x0B): 0x40fc
  capabilities: -10g-cx4 -10g-lrm +10g-t +10g-kx4 +10g-kr +1000-t +1000-kx
                +100-tx -10-t -p2mp -40g/100g -1000/100-t1 -25g -200g/400g
                +2.5g/5g -1000-h

but supports only up to 5G speed (as with AQR111/111B0).
AQR111 init config is used to set max speed 5G.

Signed-off-by: Paweł Owoc <frut3k7@gmail.com>
---
 drivers/net/phy/aquantia/aquantia_main.c | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)

diff --git a/drivers/net/phy/aquantia/aquantia_main.c b/drivers/net/phy/aquantia/aquantia_main.c
index 71bfddb8f453..d34cdec47636 100644
--- a/drivers/net/phy/aquantia/aquantia_main.c
+++ b/drivers/net/phy/aquantia/aquantia_main.c
@@ -28,6 +28,7 @@
 #define PHY_ID_AQR412	0x03a1b712
 #define PHY_ID_AQR113	0x31c31c40
 #define PHY_ID_AQR113C	0x31c31c12
+#define PHY_ID_AQR114C	0x31c31c22
 #define PHY_ID_AQR813	0x31c31cb2
 
 #define MDIO_PHYXS_VEND_IF_STATUS		0xe812
@@ -962,6 +963,25 @@ static struct phy_driver aqr_driver[] = {
 	.get_stats      = aqr107_get_stats,
 	.link_change_notify = aqr107_link_change_notify,
 },
+{
+	PHY_ID_MATCH_MODEL(PHY_ID_AQR114C),
+	.name           = "Aquantia AQR114C",
+	.probe          = aqr107_probe,
+	.get_rate_matching = aqr107_get_rate_matching,
+	.config_init    = aqr111_config_init,
+	.config_aneg    = aqr_config_aneg,
+	.config_intr    = aqr_config_intr,
+	.handle_interrupt = aqr_handle_interrupt,
+	.read_status    = aqr107_read_status,
+	.get_tunable    = aqr107_get_tunable,
+	.set_tunable    = aqr107_set_tunable,
+	.suspend        = aqr107_suspend,
+	.resume         = aqr107_resume,
+	.get_sset_count = aqr107_get_sset_count,
+	.get_strings    = aqr107_get_strings,
+	.get_stats      = aqr107_get_stats,
+	.link_change_notify = aqr107_link_change_notify,
+},
 {
 	PHY_ID_MATCH_MODEL(PHY_ID_AQR813),
 	.name		= "Aquantia AQR813",
@@ -999,6 +1019,7 @@ static struct mdio_device_id __maybe_unused aqr_tbl[] = {
 	{ PHY_ID_MATCH_MODEL(PHY_ID_AQR412) },
 	{ PHY_ID_MATCH_MODEL(PHY_ID_AQR113) },
 	{ PHY_ID_MATCH_MODEL(PHY_ID_AQR113C) },
+	{ PHY_ID_MATCH_MODEL(PHY_ID_AQR114C) },
 	{ PHY_ID_MATCH_MODEL(PHY_ID_AQR813) },
 	{ }
 };
-- 
2.44.0


^ permalink raw reply related	[flat|nested] 5+ messages in thread
* Re: [PATCH net-next v2] net: phy: aquantia: add support for AQR114C PHY ID
  2024-04-01 14:51 ` [PATCH net-next v2] " Paweł Owoc
@ 2024-04-01 14:54   ` Andrew Lunn
  2024-04-03  1:10   ` patchwork-bot+netdevbpf
  1 sibling, 0 replies; 5+ messages in thread
From: Andrew Lunn @ 2024-04-01 14:54 UTC (permalink / raw)
  To: Paweł Owoc
  Cc: Heiner Kallweit, Russell King, David S. Miller, Eric Dumazet,
	Jakub Kicinski, Paolo Abeni, Christian Marangi, Robert Marko,
	Russell King (Oracle),
	netdev, linux-kernel

On Mon, Apr 01, 2024 at 04:51:06PM +0200, Paweł Owoc wrote:
> Add support for AQR114C PHY ID. This PHY advertise 10G speed:
> SPEED(0x04): 0x6031
>   capabilities: -400g +5g +2.5g -200g -25g -10g-xr -100g -40g -10g/1g -10
>                 +100 +1000 -10-ts -2-tl +10g
> EXTABLE(0x0B): 0x40fc
>   capabilities: -10g-cx4 -10g-lrm +10g-t +10g-kx4 +10g-kr +1000-t +1000-kx
>                 +100-tx -10-t -p2mp -40g/100g -1000/100-t1 -25g -200g/400g
>                 +2.5g/5g -1000-h
> 
> but supports only up to 5G speed (as with AQR111/111B0).
> AQR111 init config is used to set max speed 5G.
> 
> Signed-off-by: Paweł Owoc <frut3k7@gmail.com>

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH net-next v2] net: phy: aquantia: add support for AQR114C PHY ID
  2024-04-01 14:51 ` [PATCH net-next v2] " Paweł Owoc
  2024-04-01 14:54   ` Andrew Lunn
@ 2024-04-03  1:10   ` patchwork-bot+netdevbpf
  1 sibling, 0 replies; 5+ messages in thread
From: patchwork-bot+netdevbpf @ 2024-04-03  1:10 UTC (permalink / raw)
  To: =?utf-8?q?Pawe=C5=82_Owoc_=3Cfrut3k7=40gmail=2Ecom=3E?=
  Cc: andrew, hkallweit1, linux, davem, edumazet, kuba, pabeni,
	ansuelsmth, robimarko, rmk+kernel, netdev, linux-kernel

Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Mon,  1 Apr 2024 16:51:06 +0200 you wrote:
> Add support for AQR114C PHY ID. This PHY advertise 10G speed:
> SPEED(0x04): 0x6031
>   capabilities: -400g +5g +2.5g -200g -25g -10g-xr -100g -40g -10g/1g -10
>                 +100 +1000 -10-ts -2-tl +10g
> EXTABLE(0x0B): 0x40fc
>   capabilities: -10g-cx4 -10g-lrm +10g-t +10g-kx4 +10g-kr +1000-t +1000-kx
>                 +100-tx -10-t -p2mp -40g/100g -1000/100-t1 -25g -200g/400g
>                 +2.5g/5g -1000-h
> 
> [...]

Here is the summary with links:
  - [net-next,v2] net: phy: aquantia: add support for AQR114C PHY ID
    https://git.kernel.org/netdev/net-next/c/c278ec644377

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-04-03  1:10 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-03-15  8:06 [PATCH net-next] net: phy: aquantia: add support for AQR114C PHY ID Paweł Owoc
2024-03-15 19:58 ` Andrew Lunn
2024-04-01 14:51 ` [PATCH net-next v2] " Paweł Owoc
2024-04-01 14:54   ` Andrew Lunn
2024-04-03  1:10   ` patchwork-bot+netdevbpf

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).