From: Markus Elfring <Markus.Elfring@web.de>
To: Dan Carpenter <dan.carpenter@linaro.org>,
kernel-janitors@vger.kernel.org, netdev@vger.kernel.org,
intel-wired-lan@lists.osuosl.org,
Maciej Fijalkowski <maciej.fijalkowski@intel.com>,
Przemek Kitszel <przemyslaw.kitszel@intel.com>,
Tony Nguyen <anthony.l.nguyen@intel.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Alexander Lobakin <aleksander.lobakin@intel.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
David Laight <David.Laight@aculab.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
Jesse Brandeburg <jesse.brandeburg@intel.com>,
Jiri Pirko <jiri@resnulli.us>,
Jonathan Cameron <jic23@kernel.org>,
Julia Lawall <julia.lawall@inria.fr>,
Kees Cook <keescook@chromium.org>,
Lukasz Czapnik <lukasz.czapnik@intel.com>,
Paolo Abeni <pabeni@redhat.com>,
Pucha Himasekhar Reddy <himasekharx.reddy.pucha@intel.com>
Subject: Re: [PATCH net] ice: Fix freeing uninitialized pointers
Date: Thu, 21 Mar 2024 18:59:00 +0100 [thread overview]
Message-ID: <d2b1f3bd-42f1-483b-916e-3735b39a30e1@web.de> (raw)
In-Reply-To: <77145930-e3df-4e77-a22d-04851cf3a426@moroto.mountain>
> Automatically cleaned up pointers need to be initialized before exiting
> their scope. In this case, they need to be initialized to NULL before
> any return statement.
How will development interests evolve further for such design aspects?
…
> +++ b/drivers/net/ethernet/intel/ice/ice_ethtool.c
> @@ -941,11 +941,11 @@ static u64 ice_loopback_test(struct net_device *netdev)
> struct ice_netdev_priv *np = netdev_priv(netdev);
> struct ice_vsi *orig_vsi = np->vsi, *test_vsi;
> struct ice_pf *pf = orig_vsi->back;
> + u8 *tx_frame __free(kfree) = NULL;
> u8 broadcast[ETH_ALEN], ret = 0;
> int num_frames, valid_frames;
> struct ice_tx_ring *tx_ring;
> struct ice_rx_ring *rx_ring;
> - u8 *tx_frame __free(kfree);
> int i;
>
> netdev_info(netdev, "loopback test\n");
How do you think about to reduce the scope for the affected local variable instead
with the help of a small script (like the following) for the semantic patch language?
@movement@
attribute name __free;
@@
-u8 *tx_frame __free(kfree);
int i;
... when any
if (ice_fltr_add_mac(test_vsi, ...))
{ ... }
+
+{
+u8 *tx_frame __free(kfree) = NULL;
if (ice_lbtest_create_frame(pf, &tx_frame, ...))
{ ... }
... when any
+}
+
valid_frames = ice_lbtest_receive_frames(...);
Regards,
Markus
next prev parent reply other threads:[~2024-03-21 17:59 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-16 9:44 [PATCH net] ice: Fix freeing uninitialized pointers Dan Carpenter
2024-03-18 7:58 ` Jiri Pirko
2024-03-18 8:10 ` Dan Carpenter
2024-03-19 19:43 ` Jakub Kicinski
2024-03-20 5:01 ` Dan Carpenter
2024-03-20 7:32 ` Julia Lawall
2024-03-20 16:33 ` Jonathan Cameron
2024-03-21 3:29 ` Jakub Kicinski
2024-03-21 9:59 ` Przemek Kitszel
2024-03-21 10:34 ` Dan Carpenter
2024-03-20 12:18 ` Markus Elfring
2024-03-21 17:59 ` Markus Elfring [this message]
2024-03-21 18:03 ` Andy Shevchenko
2024-03-21 18:14 ` Markus Elfring
2024-03-21 20:20 ` Julia Lawall
2024-03-21 22:27 ` Jesse Brandeburg
2024-03-22 1:48 ` Jakub Kicinski
2024-03-22 1:56 ` Jakub Kicinski
2024-03-22 7:24 ` Julia Lawall
2024-03-22 15:03 ` Jakub Kicinski
2024-03-22 5:30 ` Dan Carpenter
2024-03-22 8:48 ` Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d2b1f3bd-42f1-483b-916e-3735b39a30e1@web.de \
--to=markus.elfring@web.de \
--cc=David.Laight@aculab.com \
--cc=aleksander.lobakin@intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=dan.carpenter@linaro.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=himasekharx.reddy.pucha@intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jesse.brandeburg@intel.com \
--cc=jic23@kernel.org \
--cc=jiri@resnulli.us \
--cc=julia.lawall@inria.fr \
--cc=keescook@chromium.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lukasz.czapnik@intel.com \
--cc=maciej.fijalkowski@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=przemyslaw.kitszel@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).