From: Paul Menzel <pmenzel@molgen.mpg.de>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Kai-Heng Feng <kai.heng.feng@canonical.com>,
Jeff Kirsher <jeffrey.t.kirsher@intel.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
intel-wired-lan@lists.osuosl.org,
Jakub Kicinski <kuba@kernel.org>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [Intel-wired-lan] [PATCH] e1000e: Power cycle phy on PM resume
Date: Thu, 24 Sep 2020 15:02:36 +0200 [thread overview]
Message-ID: <d4c72cf9-930d-7559-9ca8-3336626e29d9@molgen.mpg.de> (raw)
In-Reply-To: <20200923192813.GE3764123@lunn.ch>
Dear Andrew,
Am 23.09.20 um 21:28 schrieb Andrew Lunn:
>>>> How much does this increase the resume time?
>
> Define resume time? Until you get the display manager unlock screen?
> Or do you need working networking?
Until network is functional again. Currently, the speed negotiation
alone takes three(?) seconds, so making it even longer is unacceptable.
(You wrote it below.)
> It takes around 1.5 seconds for auto negotiation to get a link. I know
> it takes me longer than that to move my fingers to the keyboard and
> type in my password to unlock the screen. So by the time you actually
> get to see your desktop, you should have link.
Not here.
> I've no idea about how the e1000e driver does link negotiation. But
> powering the PHY off means there is going to be a negotiation sometime
> later. But if you don't turn it off, the driver might be able to avoid
> doing an autoneg if the PHY has already done one when it got powered
> up.
Indeed.
Kind regards,
Paul
next prev parent reply other threads:[~2020-09-24 13:02 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-23 7:47 [PATCH] e1000e: Power cycle phy on PM resume Kai-Heng Feng
2020-09-23 12:17 ` Andrew Lunn
2020-09-23 14:44 ` Kai-Heng Feng
2020-09-23 15:37 ` Andrew Lunn
2020-09-24 12:50 ` Kai-Heng Feng
2020-09-23 13:28 ` [Intel-wired-lan] " Paul Menzel
2020-09-23 14:46 ` Kai-Heng Feng
2020-09-23 15:02 ` Paul Menzel
2020-09-23 19:28 ` Andrew Lunn
2020-09-24 13:02 ` Paul Menzel [this message]
2020-09-24 15:09 ` [PATCH v2] e1000e: Increase iteration on polling MDIC ready bit Kai-Heng Feng
2020-09-24 15:32 ` [Intel-wired-lan] " Paul Menzel
2020-09-24 16:04 ` Andrew Lunn
2020-09-24 15:53 ` Andrew Lunn
2020-09-24 16:04 ` Kai-Heng Feng
2020-09-25 8:50 ` David Laight
2020-09-25 13:29 ` Andrew Lunn
2020-09-26 10:08 ` David Laight
2020-09-24 16:45 ` [PATCH v3] " Kai-Heng Feng
2020-09-24 19:57 ` Andrew Lunn
2020-09-25 3:57 ` Kai-Heng Feng
2020-09-25 5:16 ` [Intel-wired-lan] " Paul Menzel
2020-09-28 8:36 ` [PATCH v4] e1000e: Increase polling timeout on " Kai-Heng Feng
2020-09-29 13:08 ` [Intel-wired-lan] " Neftin, Sasha
2020-09-29 13:31 ` Kai-Heng Feng
2020-09-29 13:46 ` Neftin, Sasha
2020-09-29 15:08 ` Kai-Heng Feng
2020-09-29 15:11 ` David Laight
2020-09-29 15:12 ` Kai-Heng Feng
2020-09-30 6:54 ` Vitaly Lifshits
2020-10-05 6:23 ` Kai-Heng Feng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d4c72cf9-930d-7559-9ca8-3336626e29d9@molgen.mpg.de \
--to=pmenzel@molgen.mpg.de \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jeffrey.t.kirsher@intel.com \
--cc=kai.heng.feng@canonical.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).