* [PATCH net-next] net: use rcu_dereference_protected to fetch sk_dst_cache in sk_destruct
@ 2019-03-13 13:29 Xin Long
2019-03-13 17:52 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Xin Long @ 2019-03-13 13:29 UTC (permalink / raw)
To: network dev; +Cc: davem, Eric Dumazet
As Eric noticed, in .sk_destruct, sk->sk_dst_cache update is prevented, and
no barrier is needed for this. So change to use rcu_dereference_protected()
instead of rcu_dereference_check() to fetch sk_dst_cache in there.
Reported-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: Xin Long <lucien.xin@gmail.com>
---
net/decnet/af_decnet.c | 2 +-
net/ipv4/af_inet.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/decnet/af_decnet.c b/net/decnet/af_decnet.c
index bdccc46..c1fa478 100644
--- a/net/decnet/af_decnet.c
+++ b/net/decnet/af_decnet.c
@@ -444,7 +444,7 @@ static void dn_destruct(struct sock *sk)
skb_queue_purge(&scp->other_xmit_queue);
skb_queue_purge(&scp->other_receive_queue);
- dst_release(rcu_dereference_check(sk->sk_dst_cache, 1));
+ dst_release(rcu_dereference_protected(sk->sk_dst_cache, 1));
}
static unsigned long dn_memory_pressure;
diff --git a/net/ipv4/af_inet.c b/net/ipv4/af_inet.c
index eab3ebd..375be06 100644
--- a/net/ipv4/af_inet.c
+++ b/net/ipv4/af_inet.c
@@ -156,7 +156,7 @@ void inet_sock_destruct(struct sock *sk)
WARN_ON(sk->sk_forward_alloc);
kfree(rcu_dereference_protected(inet->inet_opt, 1));
- dst_release(rcu_dereference_check(sk->sk_dst_cache, 1));
+ dst_release(rcu_dereference_protected(sk->sk_dst_cache, 1));
dst_release(sk->sk_rx_dst);
sk_refcnt_debug_dec(sk);
}
--
2.1.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] net: use rcu_dereference_protected to fetch sk_dst_cache in sk_destruct
2019-03-13 13:29 [PATCH net-next] net: use rcu_dereference_protected to fetch sk_dst_cache in sk_destruct Xin Long
@ 2019-03-13 17:52 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2019-03-13 17:52 UTC (permalink / raw)
To: lucien.xin; +Cc: netdev, edumazet
net-next is closed
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-03-13 17:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-13 13:29 [PATCH net-next] net: use rcu_dereference_protected to fetch sk_dst_cache in sk_destruct Xin Long
2019-03-13 17:52 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).